* [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
@ 2026-07-04 3:41 Freeman Yuan
2026-07-04 6:40 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Freeman Yuan @ 2026-07-04 3:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Freeman Yuan
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
From: Freeman Yuan <freemanyuan15@gmail.com>
Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
Signed-off-by: Your Real Name <freemanyuan15@gmail.com>
---
--- a/drivers/staging/rtl8723bs/include/drv_types.h 2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-03 20:13:13.040001710 -0700
@@ -307,7 +307,7 @@
u8 init_adpt_in_progress;
u8 bHaltInProgress;
- void *cmdThread;
+ void *cmd_thread;
void *evtThread;
void *xmitThread;
void *recvThread;
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-06-28 12:01:31.000000000 -0700
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-03 20:13:13.046001687 -0700
@@ -11,7 +11,7 @@
#include <linux/delay.h>
static struct _cmd_callback rtw_cmd_callback[] = {
- {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
+ {GEN_CMD_CODE(read_macreg), NULL}, /*0*/
{GEN_CMD_CODE(_Write_MACREG), NULL},
{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_BBREG), NULL},
@@ -163,7 +163,7 @@
int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
{
init_completion(&pcmdpriv->cmd_queue_comp);
- init_completion(&pcmdpriv->terminate_cmdthread_comp);
+ init_completion(&pcmdpriv->terminate_cmd_thread_comp);
INIT_LIST_HEAD(&pcmdpriv->cmd_queue.queue);
spin_lock_init(&pcmdpriv->cmd_queue.lock);
@@ -363,12 +363,12 @@
void rtw_stop_cmd_thread(struct adapter *adapter)
{
- if (adapter->cmdThread &&
+ if (adapter->cmd_thread &&
atomic_read(&adapter->cmdpriv.cmdthd_running) &&
adapter->cmdpriv.stop_req == 0) {
adapter->cmdpriv.stop_req = 1;
complete(&adapter->cmdpriv.cmd_queue_comp);
- wait_for_completion(&adapter->cmdpriv.terminate_cmdthread_comp);
+ wait_for_completion(&adapter->cmdpriv.terminate_cmd_thread_comp);
}
}
@@ -389,7 +389,7 @@
pcmdpriv->stop_req = 0;
atomic_set(&pcmdpriv->cmdthd_running, true);
- complete(&pcmdpriv->terminate_cmdthread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
while (1) {
if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
@@ -511,7 +511,7 @@
rtw_free_cmd_obj(pcmd);
} while (1);
- complete(&pcmdpriv->terminate_cmdthread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
atomic_set(&pcmdpriv->cmdthd_running, false);
return 0;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
2026-07-04 3:41 [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning Freeman Yuan
@ 2026-07-04 6:40 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2026-07-04 6:40 UTC (permalink / raw)
To: Freeman Yuan; +Cc: linux-staging, linux-kernel
On Fri, Jul 03, 2026 at 08:41:52PM -0700, Freeman Yuan wrote:
> Rename the CamelCase variable structure member cmdThread to cmd_thread
> inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
> coding style guidelines.
> From: Freeman Yuan <freemanyuan15@gmail.com>
> Subject: [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
>
> Rename the CamelCase variable structure member cmdThread to cmd_thread
> inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
> coding style guidelines.
>
> Signed-off-by: Your Real Name <freemanyuan15@gmail.com>
Interesting name :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
@ 2026-07-05 19:48 Freeman Yuan
2026-07-06 5:18 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Freeman Yuan @ 2026-07-05 19:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Freeman Yuan
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
Signed-off-by: Freeman Yuan <freemanyuan15@gmail.com>
---
--- a/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-05 12:48:26.445848305 -0700
+++ b/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-05 12:43:05.869520819 -0700
@@ -307,7 +307,7 @@
u8 init_adpt_in_progress;
u8 bHaltInProgress;
- void *cmdThread;
+ void *cmd_thread;
void *evtThread;
void *xmitThread;
void *recvThread;
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-05 12:48:26.463848308 -0700
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-05 12:43:05.867520813 -0700
@@ -156,14 +156,14 @@
};
/*
- * Caller and the rtw_cmdThread can protect cmd_q by spin_lock.
+ * Caller and the rtw_cmd_thread can protect cmd_q by spin_lock.
* No irqsave is necessary.
*/
int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
{
init_completion(&pcmdpriv->cmd_queue_comp);
- init_completion(&pcmdpriv->terminate_cmdThread_comp);
+ init_completion(&pcmdpriv->terminate_cmd_thread_comp);
INIT_LIST_HEAD(&pcmdpriv->cmd_queue.queue);
spin_lock_init(&pcmdpriv->cmd_queue.lock);
@@ -361,18 +361,18 @@
kfree(pcmd);
}
-void rtw_stop_cmdThread(struct adapter *adapter)
+void rtw_stop_cmd_thread(struct adapter *adapter)
{
- if (adapter->cmdThread &&
+ if (adapter->cmd_thread &&
atomic_read(&adapter->cmdpriv.cmdthd_running) &&
adapter->cmdpriv.stop_req == 0) {
adapter->cmdpriv.stop_req = 1;
complete(&adapter->cmdpriv.cmd_queue_comp);
- wait_for_completion(&adapter->cmdpriv.terminate_cmdThread_comp);
+ wait_for_completion(&adapter->cmdpriv.terminate_cmd_thread_comp);
}
}
-int rtw_cmdThread(void *context)
+int rtw_cmd_thread(void *context)
{
u8 ret;
struct cmd_obj *pcmd;
@@ -389,7 +389,7 @@
pcmdpriv->stop_req = 0;
atomic_set(&pcmdpriv->cmdthd_running, true);
- complete(&pcmdpriv->terminate_cmdThread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
while (1) {
if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
@@ -511,7 +511,7 @@
rtw_free_cmd_obj(pcmd);
} while (1);
- complete(&pcmdpriv->terminate_cmdThread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
atomic_set(&pcmdpriv->cmdthd_running, false);
return 0;
@@ -1733,7 +1733,7 @@
rtw_hal_c2h_handler(adapter, c2h_evt);
kfree(c2h_evt);
} else {
- /* Enqueue into cmdThread for others */
+ /* Enqueue into cmd_thread for others */
rtw_c2h_wk_cmd(adapter, c2h_evt);
}
}
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning
@ 2026-07-06 0:44 Freeman Yuan
0 siblings, 0 replies; 5+ messages in thread
From: Freeman Yuan @ 2026-07-06 0:44 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Freeman Yuan
Rename the CamelCase variable structure member cmdThread to cmd_thread
inside drv_types.h and rtw_cmd.c to align with standard Linux kernel
coding style guidelines.
Signed-off-by: Freeman Yuan <freemanyuan15@gmail.com>
---
--- a/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-05 12:48:26.445848305 -0700
+++ b/drivers/staging/rtl8723bs/include/drv_types.h 2026-07-05 12:43:05.869520819 -0700
@@ -307,7 +307,7 @@
u8 init_adpt_in_progress;
u8 bHaltInProgress;
- void *cmdThread;
+ void *cmd_thread;
void *evtThread;
void *xmitThread;
void *recvThread;
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-05 12:48:26.463848308 -0700
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c 2026-07-05 12:43:05.867520813 -0700
@@ -156,14 +156,14 @@
};
/*
- * Caller and the rtw_cmdThread can protect cmd_q by spin_lock.
+ * Caller and the rtw_cmd_thread can protect cmd_q by spin_lock.
* No irqsave is necessary.
*/
int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
{
init_completion(&pcmdpriv->cmd_queue_comp);
- init_completion(&pcmdpriv->terminate_cmdThread_comp);
+ init_completion(&pcmdpriv->terminate_cmd_thread_comp);
INIT_LIST_HEAD(&pcmdpriv->cmd_queue.queue);
spin_lock_init(&pcmdpriv->cmd_queue.lock);
@@ -361,18 +361,18 @@
kfree(pcmd);
}
-void rtw_stop_cmdThread(struct adapter *adapter)
+void rtw_stop_cmd_thread(struct adapter *adapter)
{
- if (adapter->cmdThread &&
+ if (adapter->cmd_thread &&
atomic_read(&adapter->cmdpriv.cmdthd_running) &&
adapter->cmdpriv.stop_req == 0) {
adapter->cmdpriv.stop_req = 1;
complete(&adapter->cmdpriv.cmd_queue_comp);
- wait_for_completion(&adapter->cmdpriv.terminate_cmdThread_comp);
+ wait_for_completion(&adapter->cmdpriv.terminate_cmd_thread_comp);
}
}
-int rtw_cmdThread(void *context)
+int rtw_cmd_thread(void *context)
{
u8 ret;
struct cmd_obj *pcmd;
@@ -389,7 +389,7 @@
pcmdpriv->stop_req = 0;
atomic_set(&pcmdpriv->cmdthd_running, true);
- complete(&pcmdpriv->terminate_cmdThread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
while (1) {
if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
@@ -511,7 +511,7 @@
rtw_free_cmd_obj(pcmd);
} while (1);
- complete(&pcmdpriv->terminate_cmdThread_comp);
+ complete(&pcmdpriv->terminate_cmd_thread_comp);
atomic_set(&pcmdpriv->cmdthd_running, false);
return 0;
@@ -1733,7 +1733,7 @@
rtw_hal_c2h_handler(adapter, c2h_evt);
kfree(c2h_evt);
} else {
- /* Enqueue into cmdThread for others */
+ /* Enqueue into cmd_thread for others */
rtw_c2h_wk_cmd(adapter, c2h_evt);
}
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-06 5:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 3:41 [PATCH] staging: rtl8723bs: fix cmdThread CamelCase style warning Freeman Yuan
2026-07-04 6:40 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-07-05 19:48 Freeman Yuan
2026-07-06 5:18 ` Greg KH
2026-07-06 0:44 Freeman Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox