From: goutongchen@uniontech.com
To: mpearson-lenovo@squebb.ca
Cc: derekjohn.clark@gmail.com, hansg@kernel.org,
ilpojarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, raoxu@uniontech.com,
shaoyang@uniontech.com, goutongchen <goutongchen@uniontech.com>
Subject: [PATCH] platform/x86: think-lmi: Fix "Call Trace" error warning
Date: Tue, 7 Jul 2026 17:15:55 +0800 [thread overview]
Message-ID: <20260707091555.71007-1-goutongchen@uniontech.com> (raw)
From: goutongchen <goutongchen@uniontech.com>
The maximum BIOS password length returned by the Lenovo platform BIOS/WMI
exceeded the size assumed by the think_lmi driver's internal static
buffer, causing the driver to trigger a WARN_ON() during self-checks.
Increase TLMI_PWD_BUFSIZE from 128 to 256 to eliminate the recurring
Call Trace warnings.
Here is the kernel warning triggered by the bug:
kernel: WARNING: CPU: 4 PID: 665 at drivers/platform/x86/think-lmi.c:326
kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
kernel: Call Trace:
kernel: tlmi_analyze+0x31c/0x640 [think_lmi]
...
Fixes: 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")
Signed-off-by: goutongchen <goutongchen@uniontech.com>
---
drivers/platform/x86/lenovo/think-lmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/lenovo/think-lmi.h b/drivers/platform/x86/lenovo/think-lmi.h
index 017644323d46..d643cf3b81b0 100644
--- a/drivers/platform/x86/lenovo/think-lmi.h
+++ b/drivers/platform/x86/lenovo/think-lmi.h
@@ -8,7 +8,7 @@
#define TLMI_SETTINGS_COUNT 256
#define TLMI_SETTINGS_MAXLEN 512
-#define TLMI_PWD_BUFSIZE 129
+#define TLMI_PWD_BUFSIZE 256
#define TLMI_LANG_MAXLEN 4
#define TLMI_INDEX_MAX 32
--
2.20.1
next reply other threads:[~2026-07-07 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 9:15 goutongchen [this message]
2026-07-07 13:31 ` [PATCH] platform/x86: think-lmi: Fix "Call Trace" error warning Mark Pearson
2026-07-08 4:14 ` Gou Tongchen
2026-07-09 11:09 ` Ilpo Järvinen
2026-07-07 15:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707091555.71007-1-goutongchen@uniontech.com \
--to=goutongchen@uniontech.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpojarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=shaoyang@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox