From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: goutongchen@uniontech.com
Cc: mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com,
hansg@kernel.org, ilpojarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, raoxu@uniontech.com,
shaoyang@uniontech.com
Subject: Re: [PATCH] platform/x86: think-lmi: Fix "Call Trace" error warning
Date: Tue, 7 Jul 2026 18:16:59 +0300 [thread overview]
Message-ID: <ak0YaxtDFRs8iV7T@ashevche-desk.local> (raw)
In-Reply-To: <20260707091555.71007-1-goutongchen@uniontech.com>
On Tue, Jul 07, 2026 at 05:15:55PM +0800, goutongchen@uniontech.com wrote:
> From: goutongchen <goutongchen@uniontech.com>
Use your real name and not an alias.
> The maximum BIOS password length returned by the Lenovo platform BIOS/WMI
Which platform? We need more details about the BIOS/HW.
> exceeded the size assumed by the think_lmi driver's internal static
> buffer, causing the driver to trigger a WARN_ON() during self-checks.
>
> Increase TLMI_PWD_BUFSIZE from 128 to 256 to eliminate the recurring
> Call Trace warnings.
>
> Here is the kernel warning triggered by the bug:
>
> kernel: WARNING: CPU: 4 PID: 665 at drivers/platform/x86/think-lmi.c:326
> kernel: tlmi_get_pwd_settings.constprop.0+0xe6/0x130 [think_lmi]
> kernel: Call Trace:
> kernel: tlmi_analyze+0x31c/0x640 [think_lmi]
> ...
> Fixes: 651b57dd4087 ("platform/x86: Move Lenovo files into lenovo subdir")
> Signed-off-by: goutongchen <goutongchen@uniontech.com>
Ditto.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-07 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 9:15 [PATCH] platform/x86: think-lmi: Fix "Call Trace" error warning goutongchen
2026-07-07 13:31 ` Mark Pearson
2026-07-08 4:14 ` Gou Tongchen
2026-07-09 11:09 ` Ilpo Järvinen
2026-07-07 15:16 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak0YaxtDFRs8iV7T@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=derekjohn.clark@gmail.com \
--cc=goutongchen@uniontech.com \
--cc=hansg@kernel.org \
--cc=ilpojarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=shaoyang@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox