The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.c
@ 2026-05-24 11:17 Atharv Margur
  0 siblings, 0 replies; 3+ messages in thread
From: Atharv Margur @ 2026-05-24 11:17 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Atharv Margur

Remove unnecessary braces around a single statement block
to improve readability and conform to kernel coding style.

No functional changes intended.

Signed-off-by: Atharv Margur <atharvmargur@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
index c88d669cb..171625264 100644
--- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
@@ -236,9 +236,8 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
 	if (is_cck_rate) {
 		phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, pwdb_all));
 	} else {
-		if (rf_rx_num != 0) {
+		if (rf_rx_num != 0)
 			phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, total_rssi /= rf_rx_num));
-		}
 	}
 }
 
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.c
@ 2026-06-24 19:34 Alonso Garrigues
  2026-07-07 11:29 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Alonso Garrigues @ 2026-06-24 19:34 UTC (permalink / raw)
  To: gregkh; +Cc: error27, linux-staging, linux-kernel, Alonso Garrigues

Single statement block does not need braces.

Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
index c88d669cb086..1716252641d3 100644
--- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
@@ -236,9 +236,8 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
 	if (is_cck_rate) {
 		phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, pwdb_all));
 	} else {
-		if (rf_rx_num != 0) {
+		if (rf_rx_num != 0)
 			phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, total_rssi /= rf_rx_num));
-		}
 	}
 }
 
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.c
  2026-06-24 19:34 [PATCH] staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.c Alonso Garrigues
@ 2026-07-07 11:29 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-07-07 11:29 UTC (permalink / raw)
  To: Alonso Garrigues; +Cc: error27, linux-staging, linux-kernel

On Wed, Jun 24, 2026 at 08:34:46PM +0100, Alonso Garrigues wrote:
> Single statement block does not need braces.
> 
> Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
> ---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index c88d669cb086..1716252641d3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -236,9 +236,8 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
>  	if (is_cck_rate) {
>  		phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, pwdb_all));
>  	} else {
> -		if (rf_rx_num != 0) {
> +		if (rf_rx_num != 0)
>  			phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, total_rssi /= rf_rx_num));
> -		}
>  	}
>  }
>  
> -- 
> 2.54.0
> 
> 

Someone else already submitted this change before you, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-07 11:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-24 19:34 [PATCH] staging: rtl8723bs: remove unnecessary braces in odm_HWConfig.c Alonso Garrigues
2026-07-07 11:29 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2026-05-24 11:17 Atharv Margur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox