* [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear()
@ 2026-07-08 9:58 Jiri Slaby (SUSE)
2026-07-08 11:38 ` Dmitry Baryshkov
2026-07-08 17:59 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby (SUSE) @ 2026-07-08 9:58 UTC (permalink / raw)
To: tiwai
Cc: linux-kernel, Jiri Slaby (SUSE), Thomas Gleixner,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
linux-sound, linux-arm-msm
irq_domain_add_linear() is going away as being obsolete now. Switch to
the preferred irq_domain_create_linear(). That differs in the first
parameter: It takes more generic struct fwnode_handle instead of struct
device_node. Therefore, of_fwnode_handle() is added around the
parameter.
Note some of the users can likely use dev->fwnode directly instead of
indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
guaranteed to be set for all, so this has to be investigated on case to
case basis (by people who can actually test with the HW).
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>
---
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
---
sound/soc/codecs/pm4125.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c
index 29655175ea28..674a2fbc4eda 100644
--- a/sound/soc/codecs/pm4125.c
+++ b/sound/soc/codecs/pm4125.c
@@ -5,6 +5,7 @@
#include <linux/component.h>
#include <linux/delay.h>
#include <linux/device.h>
+#include <linux/irqdomain.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
@@ -1295,7 +1296,7 @@ static const struct irq_domain_ops pm4125_domain_ops = {
static int pm4125_irq_init(struct pm4125_priv *pm4125, struct device *dev)
{
- pm4125->virq = irq_domain_add_linear(NULL, 1, &pm4125_domain_ops, NULL);
+ pm4125->virq = irq_domain_create_linear(NULL, 1, &pm4125_domain_ops, NULL);
if (!(pm4125->virq)) {
dev_err(dev, "%s: Failed to add IRQ domain\n", __func__);
return -EINVAL;
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear()
2026-07-08 9:58 [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear() Jiri Slaby (SUSE)
@ 2026-07-08 11:38 ` Dmitry Baryshkov
2026-07-08 17:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-07-08 11:38 UTC (permalink / raw)
To: Jiri Slaby (SUSE)
Cc: tiwai, linux-kernel, Thomas Gleixner, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Jaroslav Kysela, linux-sound,
linux-arm-msm
On Wed, Jul 08, 2026 at 11:58:40AM +0200, Jiri Slaby (SUSE) wrote:
> irq_domain_add_linear() is going away as being obsolete now. Switch to
> the preferred irq_domain_create_linear(). That differs in the first
> parameter: It takes more generic struct fwnode_handle instead of struct
> device_node. Therefore, of_fwnode_handle() is added around the
> parameter.
>
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Thomas Gleixner <tglx@kernel.org>
> Cc: Srinivas Kandagatla <srini@kernel.org>
> ---
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: linux-sound@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> ---
> sound/soc/codecs/pm4125.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear()
2026-07-08 9:58 [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear() Jiri Slaby (SUSE)
2026-07-08 11:38 ` Dmitry Baryshkov
@ 2026-07-08 17:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-07-08 17:59 UTC (permalink / raw)
To: tiwai, Jiri Slaby (SUSE)
Cc: linux-kernel, Thomas Gleixner, Srinivas Kandagatla, Liam Girdwood,
Jaroslav Kysela, linux-sound, linux-arm-msm
On Wed, 08 Jul 2026 11:58:40 +0200, Jiri Slaby (SUSE) wrote:
> ASoC: pm4125: Switch to irq_domain_create_linear()
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/1] ASoC: pm4125: Switch to irq_domain_create_linear()
https://git.kernel.org/broonie/sound/c/907e6a701029
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-09 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08 9:58 [PATCH] ASoC: pm4125: Switch to irq_domain_create_linear() Jiri Slaby (SUSE)
2026-07-08 11:38 ` Dmitry Baryshkov
2026-07-08 17:59 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox