The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "André Moreira" <andrem.33333@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] staging: sm750fb: Remove unused variable 'setAllEngOff'
Date: Wed, 8 Jul 2026 13:59:45 +0200	[thread overview]
Message-ID: <2026070828-arrange-degrading-a2ed@gregkh> (raw)
In-Reply-To: <20260708060307.12237-1-andrem.33333@gmail.com>

On Wed, Jul 08, 2026 at 03:03:07AM -0300, André Moreira wrote:
> The variable 'setAllEngOff' within the 'init_status' struct is only
> set to zero during setup but its value is never read anywhere else
> in the driver. Remove it entirely to clean up the code.
> 
> Signed-off-by: André Moreira <andrem.33333@gmail.com>
> ---
> v6:
>   - Change patch approach from renaming CamelCase to entirely removing
>     the unused 'setAllEngOff' variable, based on Greg KH's feedback.

This doesn't apply to my tree at all.  Can you rebase against the
staging-testing branch and resend?

thanks,

greg k-h

  reply	other threads:[~2026-07-08 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 22:06 [PATCH] staging: sm750fb: rename variables to avoid CamelCase André Moreira
2026-07-07  9:11 ` Greg KH
2026-07-07 10:27   ` [PATCH v2] staging: sm750fb: rename variables to comply with kernel style André Moreira
2026-07-07 10:56     ` Greg Kroah-Hartman
2026-07-07 11:43   ` [PATCH v3] " André Moreira
2026-07-07 11:49     ` Greg Kroah-Hartman
2026-07-07 13:15   ` [PATCH v4] " André Moreira
2026-07-07 13:28     ` Andre Moreira
2026-07-07 14:17     ` Greg Kroah-Hartman
2026-07-07 20:15   ` [PATCH v5] " André Moreira
2026-07-08  5:03     ` Greg Kroah-Hartman
2026-07-08  6:03   ` [PATCH v6] staging: sm750fb: Remove unused variable 'setAllEngOff' André Moreira
2026-07-08 11:59     ` Greg Kroah-Hartman [this message]
2026-07-08 13:09       ` Andre Moreira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070828-arrange-degrading-a2ed@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andrem.33333@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox