From: Aditya Tipre <tipreaditya@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Aditya Tipre <tipreaditya@gmail.com>
Subject: [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe
Date: Thu, 9 Jul 2026 00:03:48 -0400 [thread overview]
Message-ID: <20260709040419.216324-1-tipreaditya@gmail.com> (raw)
The duplicate-frame path returns immediately, so the following else is
unnecessary. Use continue while walking the reorder queue and fall through
to break once the insertion point is found.
Signed-off-by: Aditya Tipre <tipreaditya@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 86c5e2c4e7dd..c97c5fb73bb7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1783,14 +1783,17 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
pnextrframe = (union recv_frame *)plist;
pnextattrib = &pnextrframe->u.hdr.attrib;
- if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
+ if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) {
plist = get_next(plist);
- else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
+ continue;
+ }
+
+ if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
/* Duplicate entry is found!! Do not insert current entry. */
/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
return false;
- else
- break;
+
+ break;
}
/* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */
--
2.54.0
next reply other threads:[~2026-07-09 4:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 4:03 Aditya Tipre [this message]
2026-07-09 11:22 ` [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709040419.216324-1-tipreaditya@gmail.com \
--to=tipreaditya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox