* [PATCH 0/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes DT property @ 2026-07-07 7:02 Wojciech Dubowik 2026-07-07 7:02 ` [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property Wojciech Dubowik 2026-07-07 7:02 ` [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add reverse lvds " Wojciech Dubowik 0 siblings, 2 replies; 6+ messages in thread From: Wojciech Dubowik @ 2026-07-07 7:02 UTC (permalink / raw) To: linux-kernel Cc: Wojciech Dubowik, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, dri-devel, devicetree From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> Add lvds reverse lanes device tree property. When set, the endpoint lvds data lanes are configured in <4 3 2 1> order instead of default <1 2 3 4>. This is needed for layouts where lanes have been swapped. Wojciech Dubowik (2): dt-bindings: display: sn65dsi83: Add reverse lanes property drm/bridge: ti-sn65dsi83: Add reverse lvds lanes property .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ drivers/gpu/drm/bridge/ti-sn65dsi83.c | 8 ++++++++ 2 files changed, 12 insertions(+) -- 2.47.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property 2026-07-07 7:02 [PATCH 0/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes DT property Wojciech Dubowik @ 2026-07-07 7:02 ` Wojciech Dubowik 2026-07-09 8:33 ` Alexander Stein 2026-07-07 7:02 ` [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add reverse lvds " Wojciech Dubowik 1 sibling, 1 reply; 6+ messages in thread From: Wojciech Dubowik @ 2026-07-07 7:02 UTC (permalink / raw) To: linux-kernel Cc: Wojciech Dubowik, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, dri-devel, devicetree From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> Add reverse lvds lanes property for endpoints. It reverses the data-lanes order i.e. <4 3 2 1> instead of default <1 2 3 4>. Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com> --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index e69b6343a8eb..44483e808af9 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -115,6 +115,10 @@ $defs: enum: [100, 200] default: 200 + ti,lvds-reverse-lanes: + description: Reverse the order of LVDS lanes. + type: boolean + ti,lvds-vod-swing-clock-microvolt: description: LVDS diferential output voltage <min max> for clock lanes in microvolts. -- 2.47.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property 2026-07-07 7:02 ` [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property Wojciech Dubowik @ 2026-07-09 8:33 ` Alexander Stein 2026-07-09 9:17 ` Laurent Pinchart 0 siblings, 1 reply; 6+ messages in thread From: Alexander Stein @ 2026-07-09 8:33 UTC (permalink / raw) To: linux-kernel, dri-devel Cc: Wojciech Dubowik, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, dri-devel, devicetree, Wojciech Dubowik Hi, Am Dienstag, 7. Juli 2026, 09:02:42 CEST schrieb Wojciech Dubowik: > From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > > Add reverse lvds lanes property for endpoints. It reverses > the data-lanes order i.e. <4 3 2 1> instead of default > <1 2 3 4>. Wouldn't it be more reasonable to parse the data-lanes property and check for the order instead of introducing a new property? Best regards Alexander > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > --- > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > index e69b6343a8eb..44483e808af9 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > @@ -115,6 +115,10 @@ $defs: > enum: [100, 200] > default: 200 > > + ti,lvds-reverse-lanes: > + description: Reverse the order of LVDS lanes. > + type: boolean > + > ti,lvds-vod-swing-clock-microvolt: > description: LVDS diferential output voltage <min max> for clock > lanes in microvolts. > -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property 2026-07-09 8:33 ` Alexander Stein @ 2026-07-09 9:17 ` Laurent Pinchart 2026-07-09 12:57 ` Wojciech Dubowik 0 siblings, 1 reply; 6+ messages in thread From: Laurent Pinchart @ 2026-07-09 9:17 UTC (permalink / raw) To: Alexander Stein Cc: linux-kernel, dri-devel, Wojciech Dubowik, Andrzej Hajda, Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, devicetree On Thu, Jul 09, 2026 at 10:33:36AM +0200, Alexander Stein wrote: > Am Dienstag, 7. Juli 2026, 09:02:42 CEST schrieb Wojciech Dubowik: > > From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > > > > Add reverse lvds lanes property for endpoints. It reverses > > the data-lanes order i.e. <4 3 2 1> instead of default > > <1 2 3 4>. > > Wouldn't it be more reasonable to parse the data-lanes property and check > for the order instead of introducing a new property? I think so. That's the intended usage of data-lanes, the property is meant to convey the order of lanes in addition to the count. Otherwise we would have used a data-lanes-count property instead. > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > > --- > > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > index e69b6343a8eb..44483e808af9 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > @@ -115,6 +115,10 @@ $defs: > > enum: [100, 200] > > default: 200 > > > > + ti,lvds-reverse-lanes: > > + description: Reverse the order of LVDS lanes. > > + type: boolean > > + > > ti,lvds-vod-swing-clock-microvolt: > > description: LVDS diferential output voltage <min max> for clock > > lanes in microvolts. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property 2026-07-09 9:17 ` Laurent Pinchart @ 2026-07-09 12:57 ` Wojciech Dubowik 0 siblings, 0 replies; 6+ messages in thread From: Wojciech Dubowik @ 2026-07-09 12:57 UTC (permalink / raw) To: Laurent Pinchart Cc: Alexander Stein, linux-kernel, dri-devel, Andrzej Hajda, Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, devicetree On Thu, Jul 09, 2026 at 12:17:05PM +0300, Laurent Pinchart wrote: > On Thu, Jul 09, 2026 at 10:33:36AM +0200, Alexander Stein wrote: > > Am Dienstag, 7. Juli 2026, 09:02:42 CEST schrieb Wojciech Dubowik: > > > From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > > > > > > Add reverse lvds lanes property for endpoints. It reverses > > > the data-lanes order i.e. <4 3 2 1> instead of default > > > <1 2 3 4>. > > > > Wouldn't it be more reasonable to parse the data-lanes property and check > > for the order instead of introducing a new property? > > I think so. That's the intended usage of data-lanes, the property is > meant to convey the order of lanes in addition to the count. Otherwise > we would have used a data-lanes-count property instead. I will send v2 with data-lanes parsing instead of adding new dt property. Regards, Wojtek > > > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com> > > > --- > > > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > index e69b6343a8eb..44483e808af9 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > @@ -115,6 +115,10 @@ $defs: > > > enum: [100, 200] > > > default: 200 > > > > > > + ti,lvds-reverse-lanes: > > > + description: Reverse the order of LVDS lanes. > > > + type: boolean > > > + > > > ti,lvds-vod-swing-clock-microvolt: > > > description: LVDS diferential output voltage <min max> for clock > > > lanes in microvolts. > > -- > Regards, > > Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes property 2026-07-07 7:02 [PATCH 0/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes DT property Wojciech Dubowik 2026-07-07 7:02 ` [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property Wojciech Dubowik @ 2026-07-07 7:02 ` Wojciech Dubowik 1 sibling, 0 replies; 6+ messages in thread From: Wojciech Dubowik @ 2026-07-07 7:02 UTC (permalink / raw) To: linux-kernel Cc: Wojciech Dubowik, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marek Vasut, dri-devel, devicetree From: Wojciech Dubowik <Wojciech.Dubowik@mt.com> Add parsing of lvds reverse lanes device tree property. When set, the endpoint lvds data lanes are configured in <4 3 2 1> order instead of default <1 2 3 4>. This is needed for layouts where lanes have been swapped. Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@mt.com> --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 42b451432bbb..2ab2764065c4 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -163,6 +163,7 @@ struct sn65dsi83 { struct regulator *vcc; bool lvds_dual_link; bool lvds_dual_link_even_odd_swap; + bool lvds_reverse_lanes_conf[2]; int lvds_vod_swing_conf[2]; int lvds_term_conf[2]; int irq; @@ -644,6 +645,10 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge, regmap_write(ctx->regmap, REG_LVDS_LANE, (ctx->lvds_dual_link_even_odd_swap ? REG_LVDS_LANE_EVEN_ODD_SWAP : 0) | + (ctx->lvds_reverse_lanes_conf[CHANNEL_A] ? + REG_LVDS_LANE_CHA_REVERSE_LVDS : 0) | + (ctx->lvds_reverse_lanes_conf[CHANNEL_B] ? + REG_LVDS_LANE_CHB_REVERSE_LVDS : 0) | (ctx->lvds_term_conf[CHANNEL_A] ? REG_LVDS_LANE_CHA_LVDS_TERM : 0) | (ctx->lvds_term_conf[CHANNEL_B] ? @@ -854,6 +859,9 @@ static int sn65dsi83_parse_lvds_endpoint(struct sn65dsi83 *ctx, int channel) goto exit; } + ctx->lvds_reverse_lanes_conf[channel] = + of_property_read_bool(endpoint, "ti,lvds-reverse-lanes"); + ret_data = of_property_read_u32_array(endpoint, "ti,lvds-vod-swing-data-microvolt", lvds_vod_swing_data, ARRAY_SIZE(lvds_vod_swing_data)); if (ret_data != 0 && ret_data != -EINVAL) { -- 2.47.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-09 12:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-07 7:02 [PATCH 0/2] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes DT property Wojciech Dubowik 2026-07-07 7:02 ` [PATCH 1/2] dt-bindings: display: sn65dsi83: Add reverse lanes property Wojciech Dubowik 2026-07-09 8:33 ` Alexander Stein 2026-07-09 9:17 ` Laurent Pinchart 2026-07-09 12:57 ` Wojciech Dubowik 2026-07-07 7:02 ` [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add reverse lvds " Wojciech Dubowik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox