The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Louis Kotze <loukot@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	loukot@gmail.com
Subject: Re: [PATCH 0/4] wifi: rtw89: advertise WFA-certified EHT capabilities for 8922a
Date: Thu,  9 Jul 2026 12:31:38 +0200	[thread overview]
Message-ID: <20260709103138.1269594-1-loukot@gmail.com> (raw)
In-Reply-To: <7e092f6cf82c4bb18b59ba5eca40dbb5@realtek.com>

On Tue, 6 May 2026, Ping-Ke Shih wrote:

> Wi-Fi Component Operating System: Windows
>
> That means hardware is capable, but Linux driver might need more
> implementation, not just declaration. I will ask internal to check them.
>
> But I think it is not necessary to add this link as reference.

Agreed on both points, thanks for the correction. I went back over
each capability with that lens, and it changed the series more than
I expected:

- TTLM (was 3/4): you are right. H2C_FUNC_MLO_TTLM is defined but
  not wired anywhere in the driver, so advertising it would be
  declaration without implementation. Dropped.

- Restricted TWT (was part of 1/4): no in-tree driver advertises
  IEEE80211_EHT_MAC_CAP0_RESTRICTED_TWT for a STA today, and I
  cannot verify what the firmware needs. Dropped.

- Rx 1024/4096-QAM in less-than-242-tone RU (was 2/4): I had
  mischaracterized this bit as generic multi-RU receive support;
  it is specifically about high-order QAM on small RUs, which I
  cannot verify at the PHY level. Dropped.

- EHT OM Control (was 4/4): the drivers that set this for a STA
  (iwlwifi, mt7925) also advertise HE OMI control on the STA
  iftype, which rtw89 sets only for AP. Advertising the EHT
  extension without the HE base looked inconsistent, so I dropped
  it rather than widen the change to the shared HE path.

If your internal check concludes any of these are supportable as-is,
I am happy to bring them back as follow-ups with the right
justification.

> I'd like to know if these patches have explicit improvement to you?
> Or you only test these without regression?

Only the EML capabilities patch has an explicit improvement: in A/B
testing on my RTL8922AU against a TP-Link Deco BE63, ML association
without it came up with a single link, and with it both the 5 GHz
and 6 GHz links are set up (debugfs link-1/link-2, active_links
behaving as expected for EMLSR), stable across 60+ hour soaks. The
other three were no-regression only, which is part of why v2 drops
them.

v2 is therefore that single patch, and follows.

Louis

      reply	other threads:[~2026-07-09 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  4:48 [PATCH 0/4] wifi: rtw89: advertise WFA-certified EHT capabilities for 8922a Louis Kotze
2026-05-04  4:48 ` [PATCH 1/4] wifi: rtw89: advertise EML Capabilities and Restricted TWT " Louis Kotze
2026-05-04  4:48 ` [PATCH 2/4] wifi: rtw89: advertise Multi-RU OFDMA receive for 8922a per WFA cert Louis Kotze
2026-05-04  4:48 ` [PATCH 3/4] wifi: rtw89: advertise MLD TID-to-link mapping and link reconfiguration Louis Kotze
2026-05-04  4:48 ` [PATCH 4/4] wifi: rtw89: advertise EHT OM Control for 8922a per WFA cert Louis Kotze
2026-05-06  9:12 ` [PATCH 0/4] wifi: rtw89: advertise WFA-certified EHT capabilities for 8922a Ping-Ke Shih
2026-07-09 10:31   ` Louis Kotze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709103138.1269594-1-loukot@gmail.com \
    --to=loukot@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox