The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] wanxl: Remove pci_map_single_debug()
@ 2026-07-03  8:21 Bence Csokas
  2026-07-09 15:14 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Bence Csokas @ 2026-07-03  8:21 UTC (permalink / raw)
  To: Krzysztof Halasa, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
  Cc: Bence Csokas

Since commit 24dd377a76b0 ("wan: wanxl: switch from 'pci_' to 'dma_' API")
this has been dead code anyways. The pci_map_single() function it attempts
to redefine has been removed in 7968778914e5 ("PCI: Remove the deprecated
"pci-dma-compat.h" API").

Signed-off-by: Bence Csokas <bence.csokas@arm.com>
---
 drivers/net/wan/wanxl.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index d4da88c77112..1540ce0a499d 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -88,22 +88,6 @@ static inline port_status_t *get_status(struct port *port)
 	return &port->card->status->port_status[port->node];
 }
 
-#ifdef DEBUG_PCI
-static inline dma_addr_t pci_map_single_debug(struct pci_dev *pdev, void *ptr,
-					      size_t size, int direction)
-{
-	dma_addr_t addr = dma_map_single(&pdev->dev, ptr, size, direction);
-
-	if (addr + size > 0x100000000LL)
-		pr_crit("%s: pci_map_single() returned memory at 0x%llx!\n",
-			pci_name(pdev), (unsigned long long)addr);
-	return addr;
-}
-
-#undef pci_map_single
-#define pci_map_single pci_map_single_debug
-#endif
-
 /* Cable and/or personality module change interrupt service */
 static inline void wanxl_cable_intr(struct port *port)
 {

---
base-commit: 51512e22efe813d8223de27f6fd02a8a48ea2323
change-id: 20260427-wanxl-cleanup-7e59607dc4f9

Best regards,
-- 
Bence Csokas <bence.csokas@arm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wanxl: Remove pci_map_single_debug()
  2026-07-03  8:21 [PATCH] wanxl: Remove pci_map_single_debug() Bence Csokas
@ 2026-07-09 15:14 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2026-07-09 15:14 UTC (permalink / raw)
  To: Bence Csokas
  Cc: Krzysztof Halasa, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

On Fri, Jul 03, 2026 at 10:21:42AM +0200, Bence Csokas wrote:
> Since commit 24dd377a76b0 ("wan: wanxl: switch from 'pci_' to 'dma_' API")
> this has been dead code anyways. The pci_map_single() function it attempts
> to redefine has been removed in 7968778914e5 ("PCI: Remove the deprecated
> "pci-dma-compat.h" API").
> 
> Signed-off-by: Bence Csokas <bence.csokas@arm.com>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-09 15:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-03  8:21 [PATCH] wanxl: Remove pci_map_single_debug() Bence Csokas
2026-07-09 15:14 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox