* [PATCH] smb: client: mask server-provided mode to 07777 in modefromsid
@ 2026-07-09 15:54 Bjoern Doebel
2026-07-09 20:53 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Bjoern Doebel @ 2026-07-09 15:54 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, linux-cifs, linux-kernel, samba-technical
Cc: stable, doebel, nmanthey
From: Norbert Manthey <nmanthey@amazon.de>
When modefromsid is active, parse_dacl() applies the server-provided
sub_auth[2] value from the NFS mode SID to cf_mode without masking to
07777. Apply the correct masking, same as in the read path.
Fixes: e2f8fbfb8d09c ("cifs: get mode bits from special sid on stat")
Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
Assisted-by: Kiro:claude-opus-4.6
Cc: stable@vger.kernel.org
---
fs/smb/client/cifsacl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c
index 6d572dd995d79..a0a68404fbff7 100644
--- a/fs/smb/client/cifsacl.c
+++ b/fs/smb/client/cifsacl.c
@@ -962,7 +962,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,
*/
fattr->cf_mode &= ~07777;
fattr->cf_mode |=
- le32_to_cpu(ppace[i]->sid.sub_auth[2]);
+ le32_to_cpu(ppace[i]->sid.sub_auth[2]) & 07777;
break;
} else {
if (compare_sids(&(ppace[i]->sid), pownersid) == 0) {
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smb: client: mask server-provided mode to 07777 in modefromsid
2026-07-09 15:54 [PATCH] smb: client: mask server-provided mode to 07777 in modefromsid Bjoern Doebel
@ 2026-07-09 20:53 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2026-07-09 20:53 UTC (permalink / raw)
To: Bjoern Doebel
Cc: Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N, Tom Talpey,
Bharath SM, linux-cifs, linux-kernel, samba-technical, stable,
nmanthey
merged into cifs-2.6.git for-next
On Thu, Jul 9, 2026 at 10:55 AM Bjoern Doebel <doebel@amazon.de> wrote:
>
> From: Norbert Manthey <nmanthey@amazon.de>
>
> When modefromsid is active, parse_dacl() applies the server-provided
> sub_auth[2] value from the NFS mode SID to cf_mode without masking to
> 07777. Apply the correct masking, same as in the read path.
>
> Fixes: e2f8fbfb8d09c ("cifs: get mode bits from special sid on stat")
> Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
> Assisted-by: Kiro:claude-opus-4.6
> Cc: stable@vger.kernel.org
> ---
> fs/smb/client/cifsacl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c
> index 6d572dd995d79..a0a68404fbff7 100644
> --- a/fs/smb/client/cifsacl.c
> +++ b/fs/smb/client/cifsacl.c
> @@ -962,7 +962,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,
> */
> fattr->cf_mode &= ~07777;
> fattr->cf_mode |=
> - le32_to_cpu(ppace[i]->sid.sub_auth[2]);
> + le32_to_cpu(ppace[i]->sid.sub_auth[2]) & 07777;
> break;
> } else {
> if (compare_sids(&(ppace[i]->sid), pownersid) == 0) {
> --
> 2.50.1
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-09 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09 15:54 [PATCH] smb: client: mask server-provided mode to 07777 in modefromsid Bjoern Doebel
2026-07-09 20:53 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox