[PATCH 0/2] hwmon: (asus-ec-sensors) add ROG STRIX X870E-E GAMING WIFI7 R2

[PATCH 0/2] hwmon: (asus-ec-sensors) add ROG STRIX X870E-E GAMING WIFI7 R2

[Eugene Shalygin]

Add ROG STRIX X870E-E GAMING WIFI7 R2, which is a copy of ROG STRIX
X870E-E GAMING WIFI7 sensor-wise, and thus enable discovered T_Sensor
for the original board as well.

Vishaal Saraiya (2):
  hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING
    WIFI
  hwmon: (asus-ec-sensors) add ROG STRIX X870E-E GAMING WIFI7 R2

 Documentation/hwmon/asus_ec_sensors.rst | 1 +
 drivers/hwmon/asus-ec-sensors.c         | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.55.0

[PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Eugene Shalygin]

From: Vishaal Saraiya <vishaal.saraiya@gmail.com>

Enable T_Sensor for ROG STRIX X870E-E GAMING WIFI. Board specs list the
sensor, reading return -62, which is one of the blank values for
temperature sensors in the ASUS EC.

Signed-off-by: Vishaal Saraiya <vishaal.saraiya@gmail.com>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
 drivers/hwmon/asus-ec-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 29a23484cbe7..742520c485ca 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -743,7 +743,7 @@ static const struct ec_board_info board_info_strix_x870_i_gaming_wifi = {
 
 static const struct ec_board_info board_info_strix_x870e_e_gaming_wifi = {
 	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
-		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
+		SENSOR_TEMP_MB | SENSOR_TEMP_VRM | SENSOR_TEMP_T_SENSOR |
 		SENSOR_FAN_CPU_OPT,
 	.mutex_path = ASUS_HW_ACCESS_MUTEX_SB_PCI0_SBRG_SIO1_MUT0,
 	.family = family_amd_800_series,
-- 
2.55.0

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Guenter Roeck]

On 7/9/26 13:38, Eugene Shalygin wrote:
> From: Vishaal Saraiya <vishaal.saraiya@gmail.com>
> 
> Enable T_Sensor for ROG STRIX X870E-E GAMING WIFI. Board specs list the
> sensor, reading return -62, which is one of the blank values for
> temperature sensors in the ASUS EC.
> 

Just like Sashiko, I don't really understand this patch or, rather,
its description. What is the point of adding a sensor which is expected
to return -62 ?

Guenter

> Signed-off-by: Vishaal Saraiya <vishaal.saraiya@gmail.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
> ---
>   drivers/hwmon/asus-ec-sensors.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 29a23484cbe7..742520c485ca 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -743,7 +743,7 @@ static const struct ec_board_info board_info_strix_x870_i_gaming_wifi = {
>   
>   static const struct ec_board_info board_info_strix_x870e_e_gaming_wifi = {
>   	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
> -		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
> +		SENSOR_TEMP_MB | SENSOR_TEMP_VRM | SENSOR_TEMP_T_SENSOR |
>   		SENSOR_FAN_CPU_OPT,
>   	.mutex_path = ASUS_HW_ACCESS_MUTEX_SB_PCI0_SBRG_SIO1_MUT0,
>   	.family = family_amd_800_series,

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Eugene Shalygin]

Hi Guenter,

On Fri, 10 Jul 2026 at 06:58, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > Enable T_Sensor for ROG STRIX X870E-E GAMING WIFI. Board specs list the
> > sensor, reading return -62, which is one of the blank values for
> > temperature sensors in the ASUS EC.
> >
>
> Just like Sashiko, I don't really understand this patch or, rather,
> its description. What is the point of adding a sensor which is expected
> to return -62 ?

The motherboard provides sockets where users can connect thermistors
(T_Sensor, Water_In, Water_Out). When the socket is empty, readings
the sensor value returns a special blank value, which is -40 for older
board generations (maybe BIOSes?) and -62 for the newer ones. It is a
good flag that the temperature sensor "exists" at the given EC
registry index. Hope this clarifies the motivations behind the commit.

I should have noted those values and properly return -ENODATA, but now
I'm not sure which board family uses which value. I will try to
salvage this information from my notes and the Libre Hardware Monitor
project (where I implemented blanks from the beginning and users fill
that bit of information when adding support for their motherboards),
but for now the driver returns those blank values as is when actual
sensor is not connected. If that fails I will likely test for both for
all the boards... Anyhow, this shortcomings will be addressed.

Cheers,
Eugene

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Guenter Roeck]

Eugene,

On 7/9/26 22:47, Eugene Shalygin wrote:
> Hi Guenter,
> 
> On Fri, 10 Jul 2026 at 06:58, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>>> Enable T_Sensor for ROG STRIX X870E-E GAMING WIFI. Board specs list the
>>> sensor, reading return -62, which is one of the blank values for
>>> temperature sensors in the ASUS EC.
>>>
>>
>> Just like Sashiko, I don't really understand this patch or, rather,
>> its description. What is the point of adding a sensor which is expected
>> to return -62 ?
> 
> The motherboard provides sockets where users can connect thermistors
> (T_Sensor, Water_In, Water_Out). When the socket is empty, readings
> the sensor value returns a special blank value, which is -40 for older
> board generations (maybe BIOSes?) and -62 for the newer ones. It is a
> good flag that the temperature sensor "exists" at the given EC
> registry index. Hope this clarifies the motivations behind the commit.
> 
> I should have noted those values and properly return -ENODATA, but now
> I'm not sure which board family uses which value. I will try to
> salvage this information from my notes and the Libre Hardware Monitor
> project (where I implemented blanks from the beginning and users fill
> that bit of information when adding support for their motherboards),
> but for now the driver returns those blank values as is when actual
> sensor is not connected. If that fails I will likely test for both for
> all the boards... Anyhow, this shortcomings will be addressed.
> 

Do you expect me (or anyone else) to be able to deduct that from
the patch description above ?

Guenter

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Eugene Shalygin]

Guenter,

On Fri, 10 Jul 2026 at 11:03, Guenter Roeck <linux@roeck-us.net> wrote:
> Do you expect me (or anyone else) to be able to deduct that from
> the patch description above ?

Would it be OK with you if I simply submit v2 with elaborated
explanation, and add those blank value to the code later?

Eugene

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Guenter Roeck]

On 7/10/26 03:10, Eugene Shalygin wrote:
> Guenter,
> 
> On Fri, 10 Jul 2026 at 11:03, Guenter Roeck <linux@roeck-us.net> wrote:
>> Do you expect me (or anyone else) to be able to deduct that from
>> the patch description above ?
> 
> Would it be OK with you if I simply submit v2 with elaborated
> explanation, and add those blank value to the code later?
> 

Yes.

That makes me wonder, though: Are you sure that the negative temperature sensor
values are not really error codes ?

Thanks,
Guenter

Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Eugene Shalygin]

On Fri, 10 Jul 2026 at 16:34, Guenter Roeck <linux@roeck-us.net> wrote:
> That makes me wonder, though: Are you sure that the negative temperature sensor
> values are not really error codes ?

Does it matter? I know one of those two values (-40 or -62) are
delivered by the EC when thermistor is not connected (i.e. the
resistance is infinite). It allows us to detect EC registers with
temperature sensors and the driver to detect whether the [hysical
sensor is connected.

Eugene

[PATCH 2/2] hwmon: (asus-ec-sensors) add ROG STRIX X870E-E GAMING WIFI7 R2

[Eugene Shalygin]

From: Vishaal Saraiya <vishaal.saraiya@gmail.com>

The board sensors is a copy of ROG STRIX X870E-E GAMING WIFI7, thus we
simply reuse its board_info struct.

Signed-off-by: Vishaal Saraiya <vishaal.saraiya@gmail.com>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
 Documentation/hwmon/asus_ec_sensors.rst | 1 +
 drivers/hwmon/asus-ec-sensors.c         | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
index 77a709517437..e288f8ed6602 100644
--- a/Documentation/hwmon/asus_ec_sensors.rst
+++ b/Documentation/hwmon/asus_ec_sensors.rst
@@ -47,6 +47,7 @@ Supported boards:
  * ROG STRIX X870-F GAMING WIFI
  * ROG STRIX X870-I GAMING WIFI
  * ROG STRIX X870E-E GAMING WIFI
+ * ROG STRIX X870E-E GAMING WIFI7 R2
  * ROG STRIX X870E-H GAMING WIFI7
  * ROG STRIX Z390-F GAMING
  * ROG STRIX Z490-F GAMING
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 742520c485ca..473157b5f739 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -927,6 +927,8 @@ static const struct dmi_system_id dmi_table[] = {
 					&board_info_strix_x870_i_gaming_wifi),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX X870E-E GAMING WIFI",
 					&board_info_strix_x870e_e_gaming_wifi),
+	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX X870E-E GAMING WIFI7 R2",
+					&board_info_strix_x870e_e_gaming_wifi),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX X870E-H GAMING WIFI7",
 					&board_info_strix_x870e_h_gaming_wifi7),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX Z390-F GAMING",
-- 
2.55.0

Re: [PATCH 2/2] hwmon: (asus-ec-sensors) add ROG STRIX X870E-E GAMING WIFI7 R2

[Guenter Roeck]

On Thu, Jul 09, 2026 at 10:38:35PM +0200, Eugene Shalygin wrote:
> From: Vishaal Saraiya <vishaal.saraiya@gmail.com>
> 
> The board sensors is a copy of ROG STRIX X870E-E GAMING WIFI7, thus we
> simply reuse its board_info struct.
> 
> Signed-off-by: Vishaal Saraiya <vishaal.saraiya@gmail.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>

Applied.

Thanks,
Guenter