From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Linus Walleij <linusw@kernel.org>
Cc: "Laxman Acharya Padhya" <acharyalaxman8848@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: gp2ap002: Disable regulators on resume failure
Date: Sat, 11 Jul 2026 23:46:07 +0100 [thread overview]
Message-ID: <20260711234607.2eca985f@jic23-huawei> (raw)
In-Reply-To: <CAD++jL=WW1tVFOd=0UE0JxJPgwYTye-oGgTjAw3RuWxYWmykSg@mail.gmail.com>
On Fri, 10 Jul 2026 19:40:50 +0200
Linus Walleij <linusw@kernel.org> wrote:
> On Sat, Jul 4, 2026 at 10:34 AM Laxman Acharya Padhya
> <acharyalaxman8848@gmail.com> wrote:
>
> > If enabling VIO fails after VDD has been enabled, runtime resume
> > returns without disabling VDD. Likewise, if device reinitialization
> > fails, both supplies remain enabled. The runtime PM core keeps the
> > device suspended when its resume callback fails, so the supplies must
> > be restored to the suspended state.
> >
> > Disable the supplies enabled by the callback before returning an error.
> >
> > Fixes: 97d642e23037 ("iio: light: Add a driver for Sharp GP2AP002x00F")
> > Assisted-by: Codex:gpt-5
> > Signed-off-by: Laxman Acharya Padhya <acharyalaxman8848@gmail.com>
>
> Looks right.
> Reviewed-by: Linus Walleij <linusw@kernel.org>
Applied, and marked for stable.
Jonathan
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2026-07-11 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 8:34 [PATCH] iio: light: gp2ap002: Disable regulators on resume failure Laxman Acharya Padhya
2026-07-04 12:12 ` Andy Shevchenko
2026-07-10 17:40 ` Linus Walleij
2026-07-11 22:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711234607.2eca985f@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=acharyalaxman8848@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox