From: Borislav Petkov <bp@kernel.org>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>
Subject: [PATCH] EDAC/mce_amd: Do not print a stray newline
Date: Sat, 11 Jul 2026 20:16:48 -0700 [thread overview]
Message-ID: <20260712031648.486110-1-bp@kernel.org> (raw)
From: "Borislav Petkov (AMD)" <bp@alien8.de>
With error records which don't have FRU text, an empty newline is
printed like this:
[28014.094610] mce: [Hardware Error]: Machine check events logged
[28014.094674] [Hardware Error]: Corrected error, no action required.
[28014.094687] [Hardware Error]: CPU:11 (19:44:1) MC0_STATUS[-|CE|MiscV|AddrV|-|-|SyndV|CECC|-|-|-]: 0x9c20400001010135
[28014.094724] [Hardware Error]: Error Addr: 0x000000019ba9a974
[28014.094732] [Hardware Error]: IPID: 0x001000b000000000, Syndrome: 0x000000081a1f2505
[28014.094744] [Hardware Error]: Load Store Unit Ext. Error Code: 1
[28014.094748] [Hardware Error]: cache level: L1, tx: DATA, mem-tx: DRD
Move the \n into the last printk() call where it belongs.
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
drivers/edac/mce_amd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index bd252cb3c38e..ec7395cb7a70 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -870,12 +870,10 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
memcpy(&frutext[0], &err->vendor.amd.synd1, 8);
memcpy(&frutext[8], &err->vendor.amd.synd2, 8);
- pr_emerg(HW_ERR "FRU Text: %s", frutext);
+ pr_emerg(HW_ERR "FRU Text: %s\n", frutext);
}
}
- pr_cont("\n");
-
decode_smca_error(m);
goto err_code;
}
--
2.53.0
reply other threads:[~2026-07-12 3:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712031648.486110-1-bp@kernel.org \
--to=bp@kernel.org \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox