The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] EDAC/mce_amd: Do not print a stray newline
@ 2026-07-12  3:16 Borislav Petkov
  0 siblings, 0 replies; only message in thread
From: Borislav Petkov @ 2026-07-12  3:16 UTC (permalink / raw)
  To: Yazen Ghannam; +Cc: linux-edac, LKML, Borislav Petkov (AMD)

From: "Borislav Petkov (AMD)" <bp@alien8.de>

With error records which don't have FRU text, an empty newline is
printed like this:

  [28014.094610] mce: [Hardware Error]: Machine check events logged
  [28014.094674] [Hardware Error]: Corrected error, no action required.
  [28014.094687] [Hardware Error]: CPU:11 (19:44:1) MC0_STATUS[-|CE|MiscV|AddrV|-|-|SyndV|CECC|-|-|-]: 0x9c20400001010135
  [28014.094724] [Hardware Error]: Error Addr: 0x000000019ba9a974
  [28014.094732] [Hardware Error]: IPID: 0x001000b000000000, Syndrome: 0x000000081a1f2505

  [28014.094744] [Hardware Error]: Load Store Unit Ext. Error Code: 1
  [28014.094748] [Hardware Error]: cache level: L1, tx: DATA, mem-tx: DRD

Move the \n into the last printk() call where it belongs.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 drivers/edac/mce_amd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index bd252cb3c38e..ec7395cb7a70 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -870,12 +870,10 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
 				memcpy(&frutext[0], &err->vendor.amd.synd1, 8);
 				memcpy(&frutext[8], &err->vendor.amd.synd2, 8);
 
-				pr_emerg(HW_ERR "FRU Text: %s", frutext);
+				pr_emerg(HW_ERR "FRU Text: %s\n", frutext);
 			}
 		}
 
-		pr_cont("\n");
-
 		decode_smca_error(m);
 		goto err_code;
 	}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-12  3:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-12  3:16 [PATCH] EDAC/mce_amd: Do not print a stray newline Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox