The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Willy TARREAU <wtarreau@haproxy.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: mileskrause5200@gmail.com,
	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: panel: Remove unused callback binding code
Date: Mon, 13 Jul 2026 10:25:15 +0200	[thread overview]
Message-ID: <20260713082515.GC18298@haproxy.com> (raw)
In-Reply-To: <CAMuHMdW_5BAKEVFb3QkVQYMni2VZ+xxq8gyehAkV=nLkeiyP=w@mail.gmail.com>

On Mon, Jul 13, 2026 at 10:18:21AM +0200, Geert Uytterhoeven wrote:
> Hi Miles,
> 
> Thanks for your patch!
> 
> On Mon, 13 Jul 2026 at 03:07, Miles Krause via B4 Relay
> <devnull+mileskrause5200.gmail.com@kernel.org> wrote:
> > From: Miles Krause <mileskrause5200@gmail.com>
> >
> > panel_bind_callback() has been compiled out with #if 0 since it was
> > introduced and has no callers. Remove the dead function to reduce
> 
> FTR, that function was used until commit 630231776da4916e ("Staging:
> panel: remove support for smartcards") in v2.6.29.
> 
> > maintenance burden.
> >
> > No functional change.
> >
> > Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
> 
> I do agree it can go. It can be revived from git history when needed.
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert

I, too, strongly doubt it will be reused any day.

Acked-by: Willy Tarreau <willy@haproxy.com>

Willy

  reply	other threads:[~2026-07-13  8:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  1:07 [PATCH] auxdisplay: panel: Remove unused callback binding code Miles Krause via B4 Relay
2026-07-13  8:18 ` Geert Uytterhoeven
2026-07-13  8:25   ` Willy TARREAU [this message]
2026-07-13 11:28 ` Andy Shevchenko
2026-07-14  7:11   ` Geert Uytterhoeven
2026-07-14  8:19     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713082515.GC18298@haproxy.com \
    --to=wtarreau@haproxy.com \
    --cc=andy@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mileskrause5200@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox