The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] auxdisplay: panel: Remove unused callback binding code
@ 2026-07-13  1:07 Miles Krause via B4 Relay
  2026-07-13  8:18 ` Geert Uytterhoeven
  2026-07-13 11:28 ` Andy Shevchenko
  0 siblings, 2 replies; 6+ messages in thread
From: Miles Krause via B4 Relay @ 2026-07-13  1:07 UTC (permalink / raw)
  To: Willy Tarreau, Ksenija Stanojevic, Andy Shevchenko,
	Geert Uytterhoeven
  Cc: linux-kernel, Miles Krause

From: Miles Krause <mileskrause5200@gmail.com>

panel_bind_callback() has been compiled out with #if 0 since it was
introduced and has no callers. Remove the dead function to reduce
maintenance burden.

No functional change.

Signed-off-by: Miles Krause <mileskrause5200@gmail.com>
---
Compile-tested on x86_64 with:

  make O=out allmodconfig
  make O=out W=1 drivers/auxdisplay/panel.o

Sparse-tested with:

  make O=out C=2 CHECK=sparse drivers/auxdisplay/panel.o
---
 drivers/auxdisplay/panel.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index d8854cf15268..a7dfc53157bc 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press,
 	return key;
 }
 
-#if 0
-/* tries to bind a callback function to the signal name <name>. The function
- * <press_fct> will be called with the <press_data> arg when the signal is
- * activated, and so on for <release_fct>/<release_data>
- * Returns the pointer to the new signal if ok, NULL if the signal could not
- * be bound.
- */
-static struct logical_input *panel_bind_callback(char *name,
-						 void (*press_fct)(int),
-						 int press_data,
-						 void (*release_fct)(int),
-						 int release_data)
-{
-	struct logical_input *callback;
-
-	callback = kmalloc(sizeof(*callback), GFP_KERNEL);
-	if (!callback)
-		return NULL;
-
-	memset(callback, 0, sizeof(struct logical_input));
-	if (!input_name2mask(name, &callback->mask, &callback->value,
-			     &scan_mask_i, &scan_mask_o))
-		return NULL;
-
-	callback->type = INPUT_TYPE_STD;
-	callback->state = INPUT_ST_LOW;
-	callback->rise_time = 1;
-	callback->fall_time = 1;
-	callback->u.std.press_fct = press_fct;
-	callback->u.std.press_data = press_data;
-	callback->u.std.release_fct = release_fct;
-	callback->u.std.release_data = release_data;
-	list_add(&callback->list, &logical_inputs);
-	return callback;
-}
-#endif
-
 static void keypad_init(void)
 {
 	int keynum;

---
base-commit: 30a41cf47aecb4dafb81183b5e046e93498773ff
change-id: 20260712-panel-remove-dead-callback-46b2251e4feb

Best regards,
--  
Miles Krause <mileskrause5200@gmail.com>



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-14  8:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13  1:07 [PATCH] auxdisplay: panel: Remove unused callback binding code Miles Krause via B4 Relay
2026-07-13  8:18 ` Geert Uytterhoeven
2026-07-13  8:25   ` Willy TARREAU
2026-07-13 11:28 ` Andy Shevchenko
2026-07-14  7:11   ` Geert Uytterhoeven
2026-07-14  8:19     ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox