The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC
@ 2026-07-22 21:33 Julian Braha
  0 siblings, 0 replies; only message in thread
From: Julian Braha @ 2026-07-22 21:33 UTC (permalink / raw)
  To: aisheng.dong, festevam, Frank.Li, ping.bai, linusw
  Cc: chester62515, mbrugger, ghennadi.procopciuc, s32, kernel,
	bartosz.golaszewski, andrei.stefanescu,
	khristineandreea.barbulescu, arnd, linux-kernel, linux-gpio,
	linux-arm-kernel, Julian Braha

Currently, PINCTRL_S32G2 selects PINCTRL_S32CC which needs GPIOLIB, without
selecting or depending on GPIOLIB.

However, other similar options in this subsystem actually select GPIOLIB
instead of depending, so I think we can do the same here.

This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.

Fixes: 94cb9e8f2707 ("pinctrl: s32cc: implement GPIO functionality")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
v2: fix typo in commit message PINCTRL_S32CC -> PINCTRL_S32G2
Link to v1:
https://lore.kernel.org/all/20260722202638.135277-1-julianbraha@gmail.com/
---
 drivers/pinctrl/nxp/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/nxp/Kconfig b/drivers/pinctrl/nxp/Kconfig
index 711c0fe11565..fab725f250ab 100644
--- a/drivers/pinctrl/nxp/Kconfig
+++ b/drivers/pinctrl/nxp/Kconfig
@@ -1,10 +1,11 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config PINCTRL_S32CC
 	bool
-	depends on ARCH_S32 && OF && GPIOLIB
+	depends on ARCH_S32 && OF
 	select GENERIC_PINCTRL_GROUPS
 	select GENERIC_PINMUX_FUNCTIONS
 	select GENERIC_PINCONF
+	select GPIOLIB
 	select GPIO_REGMAP
 	select REGMAP_MMIO
 
-- 
2.54.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-22 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-22 21:33 [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC Julian Braha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox