From: srini@kernel.org
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Jianping Li <jianping.li@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>
Subject: [PATCH 02/10] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL
Date: Wed, 29 Jul 2026 10:43:44 +0100 [thread overview]
Message-ID: <20260729094352.111065-3-srini@kernel.org> (raw)
In-Reply-To: <20260729094352.111065-1-srini@kernel.org>
From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Make fastrpc_buf_free() a no-op when passed a NULL pointer, allowing
callers to avoid open-coded NULL checks.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
---
drivers/misc/fastrpc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index a9b2ae44c06f..32da4664de58 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -422,6 +422,9 @@ static int fastrpc_map_lookup(struct fastrpc_user *fl, int fd,
static void fastrpc_buf_free(struct fastrpc_buf *buf)
{
+ if (!buf)
+ return;
+
dma_free_coherent(buf->dev, buf->size, buf->virt,
fastrpc_ipa_to_dma_addr(buf->fl->cctx, buf->dma_addr));
kfree(buf);
@@ -514,8 +517,7 @@ static void fastrpc_user_free(struct kref *ref)
struct fastrpc_map *map, *m;
struct fastrpc_buf *buf, *b;
- if (fl->init_mem)
- fastrpc_buf_free(fl->init_mem);
+ fastrpc_buf_free(fl->init_mem);
list_for_each_entry_safe(ctx, n, &fl->pending, node) {
list_del(&ctx->node);
@@ -560,8 +562,7 @@ static void fastrpc_context_free(struct kref *ref)
for (i = 0; i < ctx->nbufs; i++)
fastrpc_map_put(ctx->maps[i]);
- if (ctx->buf)
- fastrpc_buf_free(ctx->buf);
+ fastrpc_buf_free(ctx->buf);
spin_lock_irqsave(&cctx->lock, flags);
idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4);
--
2.53.0
next prev parent reply other threads:[~2026-07-29 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 9:43 [PATCH 00/10] misc: fastrpc: updates for 7.3 srini
2026-07-29 9:43 ` [PATCH 01/10] misc: fastrpc: Move prints outside spinlock in fastrpc_cb_probe srini
2026-07-29 9:43 ` srini [this message]
2026-07-29 9:43 ` [PATCH 03/10] MAINTAINERS: fastrpc: remove inactive maintainer and add reviewer srini
2026-07-29 9:43 ` [PATCH 04/10] misc: fastrpc: Move fdlist to invoke context structure srini
2026-07-29 9:43 ` [PATCH 05/10] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK srini
2026-07-29 9:43 ` [PATCH 06/10] misc: fastrpc: Expand context ID mask for DSP polling mode support srini
2026-07-29 9:43 ` [PATCH 07/10] misc: fastrpc: Add polling mode support for fastRPC driver srini
2026-07-29 9:43 ` [PATCH 08/10] dt-bindings: misc: qcom,fastrpc: Document Nord FastRPC srini
2026-07-29 9:43 ` [PATCH 09/10] dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible srini
2026-07-29 9:43 ` [PATCH 10/10] misc: fastrpc: Drop unhandled DSP PD exit notification srini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729094352.111065-3-srini@kernel.org \
--to=srini@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jianping.li@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox