From: Abid Ali <dev.taqnialabs@gmail.com>
To: qingfang.deng@linux.dev
Cc: alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch,
davem@davemloft.net, dev.taqnialabs@gmail.com,
edumazet@google.com, kuba@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH v2] net: stmmac: enable MAC rx/tx after DMA start
Date: Fri, 31 Jul 2026 07:49:01 +0000 [thread overview]
Message-ID: <20260731074901.1163-1-dev.taqnialabs@gmail.com> (raw)
In-Reply-To: <507ad6a6-52a2-4c68-9ba2-5cc4f92e192d@linux.dev>
On Fri, 31 Jul 2026 10:11:40 +0800 Qingfang Deng wrote:
> This is _not_ correct. Instead it's a bit more complicated, according to
> their programming guidelines:
>
> So the correct order is: stop TX DMA -> stop MAC RX/TX -> stop RX DMA.
You're right, the XGMAC TRM with me documents the same
sequence.
IMO this looks like a fix on its own as the current teardown logic
doesn't take care of any of this. The proper shutdown sequence is
a larger change that needs per-channel status polling and timeout
handling.
I'll remove the teardown change from v3 if that makes sense and keep
only the startup reorder addressing the RX hang.
prev parent reply other threads:[~2026-07-31 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 6:14 [PATCH v2] net: stmmac: enable MAC rx/tx after DMA start Abid Ali
2026-07-27 8:23 ` Maxime Chevallier
2026-07-30 23:07 ` Jakub Kicinski
2026-07-31 7:35 ` Abid Ali
2026-07-31 2:11 ` Qingfang Deng
2026-07-31 7:49 ` Abid Ali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731074901.1163-1-dev.taqnialabs@gmail.com \
--to=dev.taqnialabs@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox