* [PATCH] i3c: dw: fix APB clock name
@ 2026-08-03 14:02 Jisheng Zhang
2026-08-05 20:20 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Jisheng Zhang @ 2026-08-03 14:02 UTC (permalink / raw)
To: Alexandre Belloni, Frank Li, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-i3c, linux-kernel, devicetree
The dt-binding doc says the APB clock name is "apb", but the code uses
"pclk". Since the dt-binding is an ABI, we can only fix this mismatch
by fixing the code.
Fixes: a0d48ebf39ce ("i3c: dw: Add optional apb clock")
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/i3c/master/dw-i3c-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 2f8c0c4683e0..0625587f1527 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1579,7 +1579,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
if (IS_ERR(master->core_clk))
return PTR_ERR(master->core_clk);
- master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
+ master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
if (IS_ERR(master->pclk))
return PTR_ERR(master->pclk);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i3c: dw: fix APB clock name
2026-08-03 14:02 [PATCH] i3c: dw: fix APB clock name Jisheng Zhang
@ 2026-08-05 20:20 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-08-05 20:20 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Alexandre Belloni, Frank Li, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-i3c, linux-kernel, devicetree
On Mon, Aug 03, 2026 at 10:02:24PM +0800, Jisheng Zhang wrote:
> The dt-binding doc says the APB clock name is "apb", but the code uses
> "pclk". Since the dt-binding is an ABI, we can only fix this mismatch
> by fixing the code.
i3c: dw: rename "pclk" to "apb" to match dt-binding
Change clock name "pclk" to "apb" to match dt-binding doc. No upstream
device tree sources currently use the "pclk" clock name, so no any backward
compatibility issues.
Not sure what happen when apply patch a0d48ebf39ce. Anyways, thanks for fix
it.
Frank
>
> Fixes: a0d48ebf39ce ("i3c: dw: Add optional apb clock")
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> drivers/i3c/master/dw-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 2f8c0c4683e0..0625587f1527 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1579,7 +1579,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
> if (IS_ERR(master->core_clk))
> return PTR_ERR(master->core_clk);
>
> - master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
> + master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
> if (IS_ERR(master->pclk))
> return PTR_ERR(master->pclk);
>
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-05 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 14:02 [PATCH] i3c: dw: fix APB clock name Jisheng Zhang
2026-08-05 20:20 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox