* [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema
@ 2026-07-25 18:47 Bhargav Joshi
2026-08-03 21:50 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Bhargav Joshi @ 2026-07-25 18:47 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Tony Lindgren
Cc: linux-clk, devicetree, linux-kernel, goledhruva, m-chawdhry,
daniel.baluta, simona.toaca, j.bhargav.u
Convert the Texas Instruments DM814x ADPLL clock binding to DT schema
format. Add 'clock-output-names' as required which was missing in
legacy binding, as the driver (clk-adpll.c) mandates it and fails
probing if it is missing.
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
.../devicetree/bindings/clock/ti/adpll.txt | 39 --------
.../bindings/clock/ti/ti,dm814-adpll-clock.yaml | 108 +++++++++++++++++++++
2 files changed, 108 insertions(+), 39 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/ti/adpll.txt b/Documentation/devicetree/bindings/clock/ti/adpll.txt
deleted file mode 100644
index 3122360adcf3..000000000000
--- a/Documentation/devicetree/bindings/clock/ti/adpll.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-Binding for Texas Instruments ADPLL clock.
-
-This binding uses the common clock binding[1]. It assumes a
-register-mapped ADPLL with two to three selectable input clocks
-and three to four children.
-
-[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Required properties:
-- compatible : shall be one of "ti,dm814-adpll-s-clock" or
- "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL
-- #clock-cells : from common clock binding; shall be set to 1.
-- clocks : link phandles of parent clocks clkinp and clkinpulow, note
- that the adpll-s-clock also has an optional clkinphif
-- reg : address and length of the register set for controlling the ADPLL.
-
-Examples:
- adpll_mpu_ck: adpll@40 {
- #clock-cells = <1>;
- compatible = "ti,dm814-adpll-s-clock";
- reg = <0x40 0x40>;
- clocks = <&devosc_ck &devosc_ck &devosc_ck>;
- clock-names = "clkinp", "clkinpulow", "clkinphif";
- clock-output-names = "481c5040.adpll.dcoclkldo",
- "481c5040.adpll.clkout",
- "481c5040.adpll.clkoutx2",
- "481c5040.adpll.clkouthif";
- };
-
- adpll_dsp_ck: adpll@80 {
- #clock-cells = <1>;
- compatible = "ti,dm814-adpll-lj-clock";
- reg = <0x80 0x30>;
- clocks = <&devosc_ck &devosc_ck>;
- clock-names = "clkinp", "clkinpulow";
- clock-output-names = "481c5080.adpll.dcoclkldo",
- "481c5080.adpll.clkout",
- "481c5080.adpll.clkoutldo";
- };
diff --git a/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
new file mode 100644
index 000000000000..7f551dfca030
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
@@ -0,0 +1,108 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/ti/ti,dm814-adpll-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DM814x ADPLL Clock
+
+maintainers:
+ - Tony Lindgren <tony@atomide.com>
+
+description:
+ The ADPLL is a register-mapped clock generator found on TI DM814x SoCs. It
+ provides multiple output clocks from two or three selectable input clocks and
+ three to four children.
+
+properties:
+ compatible:
+ enum:
+ - ti,dm814-adpll-s-clock
+ - ti,dm814-adpll-lj-clock
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+ clocks:
+ minItems: 2
+ maxItems: 3
+
+ clock-names:
+ minItems: 2
+ maxItems: 3
+
+ clock-output-names:
+ minItems: 3
+ maxItems: 4
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+ - clocks
+ - clock-output-names
+
+if:
+ properties:
+ compatible:
+ contains:
+ const: ti,dm814-adpll-s-clock
+then:
+ properties:
+ clocks:
+ minItems: 3
+ clock-names:
+ items:
+ - const: clkinp
+ - const: clkinpulow
+ - const: clkinphif
+ clock-output-names:
+ items:
+ - description: dcoclkldo
+ - description: clkout
+ - description: clkoutx2
+ - description: clkouthif
+else:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ items:
+ - const: clkinp
+ - const: clkinpulow
+ clock-output-names:
+ items:
+ - description: dcoclkldo
+ - description: clkout
+ - description: clkoutldo
+
+additionalProperties: false
+
+examples:
+ - |
+ adpll@40 {
+ compatible = "ti,dm814-adpll-s-clock";
+ reg = <0x40 0x40>;
+ #clock-cells = <1>;
+ clocks = <&devosc_ck &devosc_ck &devosc_ck>;
+ clock-names = "clkinp", "clkinpulow", "clkinphif";
+ clock-output-names = "481c5040.adpll.dcoclkldo",
+ "481c5040.adpll.clkout",
+ "481c5040.adpll.clkoutx2",
+ "481c5040.adpll.clkouthif";
+ };
+
+ - |
+ adpll@80 {
+ compatible = "ti,dm814-adpll-lj-clock";
+ reg = <0x80 0x30>;
+ #clock-cells = <1>;
+ clocks = <&devosc_ck &devosc_ck>;
+ clock-names = "clkinp", "clkinpulow";
+ clock-output-names = "481c5080.adpll.dcoclkldo",
+ "481c5080.adpll.clkout",
+ "481c5080.adpll.clkoutldo";
+ };
---
base-commit: 0ce37745d4bfbc493f718169c3974898ffec8ee7
change-id: 20260725-ti-adpll-ddfd84e4ef18
Best regards,
--
Bhargav
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema
2026-07-25 18:47 [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema Bhargav Joshi
@ 2026-08-03 21:50 ` Rob Herring
2026-08-04 18:29 ` Bhargav Joshi
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2026-08-03 21:50 UTC (permalink / raw)
To: Bhargav Joshi
Cc: Michael Turquette, Stephen Boyd, Brian Masney,
Krzysztof Kozlowski, Conor Dooley, Tony Lindgren, linux-clk,
devicetree, linux-kernel, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca
On Sun, Jul 26, 2026 at 12:17:47AM +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments DM814x ADPLL clock binding to DT schema
> format. Add 'clock-output-names' as required which was missing in
> legacy binding, as the driver (clk-adpll.c) mandates it and fails
> probing if it is missing.
>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
> .../devicetree/bindings/clock/ti/adpll.txt | 39 --------
> .../bindings/clock/ti/ti,dm814-adpll-clock.yaml | 108 +++++++++++++++++++++
> 2 files changed, 108 insertions(+), 39 deletions(-)
> diff --git a/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
> new file mode 100644
> index 000000000000..7f551dfca030
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti/ti,dm814-adpll-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments DM814x ADPLL Clock
> +
> +maintainers:
> + - Tony Lindgren <tony@atomide.com>
> +
> +description:
> + The ADPLL is a register-mapped clock generator found on TI DM814x SoCs. It
> + provides multiple output clocks from two or three selectable input clocks and
> + three to four children.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,dm814-adpll-s-clock
> + - ti,dm814-adpll-lj-clock
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> + clocks:
> + minItems: 2
> + maxItems: 3
> +
> + clock-names:
> + minItems: 2
> + maxItems: 3
> +
> + clock-output-names:
> + minItems: 3
> + maxItems: 4
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> + - clocks
> + - clock-output-names
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + const: ti,dm814-adpll-s-clock
> +then:
> + properties:
> + clocks:
> + minItems: 3
> + clock-names:
> + items:
> + - const: clkinp
> + - const: clkinpulow
> + - const: clkinphif
This can move to the top level and just 'minItems: 3' here.
> + clock-output-names:
> + items:
> + - description: dcoclkldo
> + - description: clkout
> + - description: clkoutx2
> + - description: clkouthif
You don't have to document the clock-output-names.
> +else:
> + properties:
> + clocks:
> + maxItems: 2
> + clock-names:
> + items:
> + - const: clkinp
> + - const: clkinpulow
And just 'maxItems: 2' here.
> + clock-output-names:
> + items:
> + - description: dcoclkldo
> + - description: clkout
> + - description: clkoutldo
And drop. Or maybe just 'maxItems: 3'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + adpll@40 {
> + compatible = "ti,dm814-adpll-s-clock";
> + reg = <0x40 0x40>;
> + #clock-cells = <1>;
> + clocks = <&devosc_ck &devosc_ck &devosc_ck>;
> + clock-names = "clkinp", "clkinpulow", "clkinphif";
> + clock-output-names = "481c5040.adpll.dcoclkldo",
> + "481c5040.adpll.clkout",
> + "481c5040.adpll.clkoutx2",
> + "481c5040.adpll.clkouthif";
> + };
> +
> + - |
> + adpll@80 {
> + compatible = "ti,dm814-adpll-lj-clock";
> + reg = <0x80 0x30>;
> + #clock-cells = <1>;
> + clocks = <&devosc_ck &devosc_ck>;
> + clock-names = "clkinp", "clkinpulow";
> + clock-output-names = "481c5080.adpll.dcoclkldo",
> + "481c5080.adpll.clkout",
> + "481c5080.adpll.clkoutldo";
> + };
One example is enough.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema
2026-08-03 21:50 ` Rob Herring
@ 2026-08-04 18:29 ` Bhargav Joshi
0 siblings, 0 replies; 3+ messages in thread
From: Bhargav Joshi @ 2026-08-04 18:29 UTC (permalink / raw)
To: Rob Herring
Cc: Michael Turquette, Stephen Boyd, Brian Masney,
Krzysztof Kozlowski, Conor Dooley, Tony Lindgren, linux-clk,
devicetree, linux-kernel, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca
On Tue, Aug 4, 2026 at 3:21 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Jul 26, 2026 at 12:17:47AM +0530, Bhargav Joshi wrote:
> > Convert the Texas Instruments DM814x ADPLL clock binding to DT schema
> > format. Add 'clock-output-names' as required which was missing in
> > legacy binding, as the driver (clk-adpll.c) mandates it and fails
> > probing if it is missing.
> >
> > Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> > ---
> > .../devicetree/bindings/clock/ti/adpll.txt | 39 --------
> > .../bindings/clock/ti/ti,dm814-adpll-clock.yaml | 108 +++++++++++++++++++++
> > 2 files changed, 108 insertions(+), 39 deletions(-)
>
> > diff --git a/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
> > new file mode 100644
> > index 000000000000..7f551dfca030
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
> > @@ -0,0 +1,108 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/ti/ti,dm814-adpll-clock.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments DM814x ADPLL Clock
> > +
> > +maintainers:
> > + - Tony Lindgren <tony@atomide.com>
> > +
> > +description:
> > + The ADPLL is a register-mapped clock generator found on TI DM814x SoCs. It
> > + provides multiple output clocks from two or three selectable input clocks and
> > + three to four children.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,dm814-adpll-s-clock
> > + - ti,dm814-adpll-lj-clock
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > + clocks:
> > + minItems: 2
> > + maxItems: 3
> > +
> > + clock-names:
> > + minItems: 2
> > + maxItems: 3
> > +
> > + clock-output-names:
> > + minItems: 3
> > + maxItems: 4
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#clock-cells'
> > + - clocks
> > + - clock-output-names
> > +
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: ti,dm814-adpll-s-clock
> > +then:
> > + properties:
> > + clocks:
> > + minItems: 3
> > + clock-names:
> > + items:
> > + - const: clkinp
> > + - const: clkinpulow
> > + - const: clkinphif
>
> This can move to the top level and just 'minItems: 3' here.
yes sure
>
> > + clock-output-names:
> > + items:
> > + - description: dcoclkldo
> > + - description: clkout
> > + - description: clkoutx2
> > + - description: clkouthif
>
> You don't have to document the clock-output-names.
>
Got it. I will drop the item descriptions for clock-output-names.
> > +else:
> > + properties:
> > + clocks:
> > + maxItems: 2
> > + clock-names:
> > + items:
> > + - const: clkinp
> > + - const: clkinpulow
>
> And just 'maxItems: 2' here.
>
> > + clock-output-names:
> > + items:
> > + - description: dcoclkldo
> > + - description: clkout
> > + - description: clkoutldo
>
> And drop. Or maybe just 'maxItems: 3'
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + adpll@40 {
> > + compatible = "ti,dm814-adpll-s-clock";
> > + reg = <0x40 0x40>;
> > + #clock-cells = <1>;
> > + clocks = <&devosc_ck &devosc_ck &devosc_ck>;
> > + clock-names = "clkinp", "clkinpulow", "clkinphif";
> > + clock-output-names = "481c5040.adpll.dcoclkldo",
> > + "481c5040.adpll.clkout",
> > + "481c5040.adpll.clkoutx2",
> > + "481c5040.adpll.clkouthif";
> > + };
> > +
> > + - |
> > + adpll@80 {
> > + compatible = "ti,dm814-adpll-lj-clock";
> > + reg = <0x80 0x30>;
> > + #clock-cells = <1>;
> > + clocks = <&devosc_ck &devosc_ck>;
> > + clock-names = "clkinp", "clkinpulow";
> > + clock-output-names = "481c5080.adpll.dcoclkldo",
> > + "481c5080.adpll.clkout",
> > + "481c5080.adpll.clkoutldo";
> > + };
>
> One example is enough.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-04 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-25 18:47 [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema Bhargav Joshi
2026-08-03 21:50 ` Rob Herring
2026-08-04 18:29 ` Bhargav Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox