The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset
@ 2026-08-04 14:07 Markuss Broks via B4 Relay
  2026-08-05  5:46 ` Arend van Spriel
  0 siblings, 1 reply; 5+ messages in thread
From: Markuss Broks via B4 Relay @ 2026-08-04 14:07 UTC (permalink / raw)
  To: Arend van Spriel
  Cc: Johannes Berg, linux-wireless, brcm80211, brcm80211-dev-list.pdl,
	linux-kernel, Markuss Broks

From: Markuss Broks <markuss.broks@gmail.com>

Those are the required changes for the BCM4361 PCIe chipset support.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://patch.msgid.link/20260803-broadcom-staging-v1-1-f6f77e55b72e@gmail.com
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
 drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
 3 files changed, 8 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
index 4adc0d0e4251..97120a659f8b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
@@ -735,6 +735,8 @@ static u32 brcmf_chip_tcm_rambase(struct brcmf_chip_priv *ci)
 	case BRCM_CC_4355_CHIP_ID:
 	case BRCM_CC_4359_CHIP_ID:
 		return (ci->pub.chiprev < 9) ? 0x180000 : 0x160000;
+	case BRCM_CC_4361_CHIP_ID:
+		return 0x170000;
 	case BRCM_CC_4364_CHIP_ID:
 	case CY_CC_4373_CHIP_ID:
 		return 0x160000;
@@ -1466,6 +1468,7 @@ bool brcmf_chip_sr_capable(struct brcmf_chip *pub)
 		reg = chip->ops->read32(chip->ctx, addr);
 		return (reg & CC_SR_CTL0_ENABLE_MASK) != 0;
 	case BRCM_CC_4359_CHIP_ID:
+	case BRCM_CC_4361_CHIP_ID:
 	case BRCM_CC_43751_CHIP_ID:
 	case BRCM_CC_43752_CHIP_ID:
 	case CY_CC_43012_CHIP_ID:
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 55f4d7b970f2..914ae72a7b74 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
 BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
 BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
 BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
+BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");
 BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
 BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
 BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");
@@ -98,6 +99,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = {
 	BRCMF_FW_ENTRY(BRCM_CC_4358_CHIP_ID, 0xFFFFFFFF, 4358),
 	BRCMF_FW_ENTRY(BRCM_CC_4359_CHIP_ID, 0x000001FF, 4359),
 	BRCMF_FW_ENTRY(BRCM_CC_4359_CHIP_ID, 0xFFFFFE00, 4359C),
+	BRCMF_FW_ENTRY(BRCM_CC_4361_CHIP_ID, 0xFFFFFFFF, 4361),
 	BRCMF_FW_ENTRY(BRCM_CC_4364_CHIP_ID, 0x0000000F, 4364B2), /* 3 */
 	BRCMF_FW_ENTRY(BRCM_CC_4364_CHIP_ID, 0xFFFFFFF0, 4364B3), /* 4 */
 	BRCMF_FW_ENTRY(BRCM_CC_4365_CHIP_ID, 0x0000000F, 4365B),
@@ -2747,6 +2749,7 @@ static const struct pci_device_id brcmf_pcie_devid_table[] = {
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_2G_DEVICE_ID, WCC),
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_5G_DEVICE_ID, WCC),
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_RAW_DEVICE_ID, WCC),
+	BRCMF_PCIE_DEVICE(BRCM_PCIE_4361_DEVICE_ID, WCC),
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_4364_DEVICE_ID, WCC_SEED),
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_4365_DEVICE_ID, BCA),
 	BRCMF_PCIE_DEVICE(BRCM_PCIE_4365_2G_DEVICE_ID, BCA),
diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
index df3b67ba4db2..b800cbfdece1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
+++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
@@ -46,6 +46,7 @@
 #define BRCM_CC_4358_CHIP_ID		0x4358
 #define BRCM_CC_4359_CHIP_ID		0x4359
 #define BRCM_CC_43602_CHIP_ID		43602
+#define BRCM_CC_4361_CHIP_ID		0x4361
 #define BRCM_CC_4364_CHIP_ID		0x4364
 #define BRCM_CC_4365_CHIP_ID		0x4365
 #define BRCM_CC_4366_CHIP_ID		0x4366
@@ -86,6 +87,7 @@
 #define BRCM_PCIE_43602_2G_DEVICE_ID	0x43bb
 #define BRCM_PCIE_43602_5G_DEVICE_ID	0x43bc
 #define BRCM_PCIE_43602_RAW_DEVICE_ID	43602
+#define BRCM_PCIE_4361_DEVICE_ID	0x441f
 #define BRCM_PCIE_4364_DEVICE_ID	0x4464
 #define BRCM_PCIE_4365_DEVICE_ID	0x43ca
 #define BRCM_PCIE_4365_2G_DEVICE_ID	0x43cb

---
base-commit: 6c5fc504d0d6934132637aa3db4b9b58148eaa78
change-id: 20260803-broadcom-staging-59a7d9f559b4

Best regards,
--  
Markuss Broks <markuss.broks@gmail.com>



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset
  2026-08-04 14:07 [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset Markuss Broks via B4 Relay
@ 2026-08-05  5:46 ` Arend van Spriel
  2026-08-05 13:56   ` Markuss Broks
  0 siblings, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2026-08-05  5:46 UTC (permalink / raw)
  To: markuss.broks
  Cc: Johannes Berg, linux-wireless, brcm80211, brcm80211-dev-list.pdl,
	linux-kernel

On 04/08/2026 16:07, Markuss Broks via B4 Relay wrote:
> From: Markuss Broks <markuss.broks@gmail.com>
>
> Those are the required changes for the BCM4361 PCIe chipset support.

Hi Markuss,

That is a brief commit message. Maybe you can provide a bit of context 
for this patch answering these questions: Are you using this device in 
some project? What platform are you using (if any)? What works and what 
does not?

> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.

This really does not look very useful. Those EDITME: are for you! As the
actual patch did not change you can probably say:
   - fix subject format indicating wifi subsystem and wireless-next repo.

> - Link to v1: 
> https://patch.msgid.link/20260803-broadcom-staging-v1-1-f6f77e55b72e@gmail.com
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
> 3 files changed, 8 insertions(+)

[...]

> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index 55f4d7b970f2..914ae72a7b74 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
> BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
> BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
> BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
> +BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");

Are you sure the CLM blob is required? Can you test without it being 
present in /lib/firmware?

> BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
> BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
> BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");

[...]

> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h 
> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> index df3b67ba4db2..b800cbfdece1 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h

[...]

> @@ -86,6 +87,7 @@
> #define BRCM_PCIE_43602_2G_DEVICE_ID 0x43bb
> #define BRCM_PCIE_43602_5G_DEVICE_ID 0x43bc
> #define BRCM_PCIE_43602_RAW_DEVICE_ID 43602
> +#define BRCM_PCIE_4361_DEVICE_ID 0x441f

Please add:
+#define BRCM_PCIE_4361_2G_DEVICE_ID 0x4420
+#define BRCM_PCIE_4361_5G_DEVICE_ID 0x4421

Regards,
Arend

> #define BRCM_PCIE_4364_DEVICE_ID 0x4464
> #define BRCM_PCIE_4365_DEVICE_ID 0x43ca
> #define BRCM_PCIE_4365_2G_DEVICE_ID 0x43cb

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset
  2026-08-05  5:46 ` Arend van Spriel
@ 2026-08-05 13:56   ` Markuss Broks
  2026-08-05 15:16     ` Arend van Spriel
  0 siblings, 1 reply; 5+ messages in thread
From: Markuss Broks @ 2026-08-05 13:56 UTC (permalink / raw)
  To: Arend van Spriel
  Cc: Johannes Berg, linux-wireless, brcm80211, brcm80211-dev-list.pdl,
	linux-kernel

Hi Arend,

On 8/5/26 8:46 AM, Arend van Spriel wrote:
> On 04/08/2026 16:07, Markuss Broks via B4 Relay wrote:
>> From: Markuss Broks <markuss.broks@gmail.com>
>>
>> Those are the required changes for the BCM4361 PCIe chipset support.
>
> Hi Markuss,
>
> That is a brief commit message. Maybe you can provide a bit of context 
> for this patch answering these questions: Are you using this device in 
> some project? What platform are you using (if any)? What works and 
> what does not?
I was just looking at similar device additions in brcmfmac, and noticed 
they didn't have much of a description, so I decided not to add much 
either. Should I add some general info about the BCM4361 into the commit 
message?

BCM4361 is used on the Samsung Galaxy S9 device (samsung-starlte), based 
on Exynos9810. There it's connected via PCIe link. Not sure if perhaps 
there's SDIO or USB or other variants of this chipset. Everything 
"basic" seems to work, seems to connect to both 2.4GHz and 5GHz 
networks, download speed looks good. Haven't tried station mode, but I'm 
not sure what's the proper way to set it up anyway.
>
>> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
>> ---
>> Changes in v2:
>> - EDITME: describe what is new in this series revision.
>> - EDITME: use bulletpoints and terse descriptions.
>
> This really does not look very useful. Those EDITME: are for you! As the
> actual patch did not change you can probably say:
>   - fix subject format indicating wifi subsystem and wireless-next repo.

Oh, sorry, I did not notice that b4 puts the changelog there if it's not 
in the cover letter. It's been a while since I last submitted something 
:) I will add the changelog there for v2 and v3 once I submit a v3.

>
>> - Link to v1: 
>> https://patch.msgid.link/20260803-broadcom-staging-v1-1-f6f77e55b72e@gmail.com
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
>> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
>> 3 files changed, 8 insertions(+)
>
> [...]
>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> index 55f4d7b970f2..914ae72a7b74 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> @@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
>> BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
>> BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
>> BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
>> +BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");
>
> Are you sure the CLM blob is required? Can you test without it being 
> present in /lib/firmware?
I have tried without the CLM blob, it says "no clm blob available, 
device might have limited channels available" but seems to at least 
somewhat work, I haven't noticed a difference. It's still a good idea to 
load it probably, right?
>
>> BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
>> BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
>> BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");
>
> [...]
>
>> diff --git 
>> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h 
>> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> index df3b67ba4db2..b800cbfdece1 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>
> [...]
>
>> @@ -86,6 +87,7 @@
>> #define BRCM_PCIE_43602_2G_DEVICE_ID 0x43bb
>> #define BRCM_PCIE_43602_5G_DEVICE_ID 0x43bc
>> #define BRCM_PCIE_43602_RAW_DEVICE_ID 43602
>> +#define BRCM_PCIE_4361_DEVICE_ID 0x441f
>
> Please add:
> +#define BRCM_PCIE_4361_2G_DEVICE_ID 0x4420
> +#define BRCM_PCIE_4361_5G_DEVICE_ID 0x4421

Are those some special variants of the chipset?

>
> Regards,
> Arend
>
>> #define BRCM_PCIE_4364_DEVICE_ID 0x4464
>> #define BRCM_PCIE_4365_DEVICE_ID 0x43ca
>> #define BRCM_PCIE_4365_2G_DEVICE_ID 0x43cb 

Thanks,

- Markuss


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset
  2026-08-05 13:56   ` Markuss Broks
@ 2026-08-05 15:16     ` Arend van Spriel
  2026-08-05 15:20       ` Markuss Broks
  0 siblings, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2026-08-05 15:16 UTC (permalink / raw)
  To: Markuss Broks
  Cc: Johannes Berg, linux-wireless, brcm80211, brcm80211-dev-list.pdl,
	linux-kernel

On 05/08/2026 15:56, Markuss Broks wrote:
> Hi Arend,
> 
> On 8/5/26 8:46 AM, Arend van Spriel wrote:
>> On 04/08/2026 16:07, Markuss Broks via B4 Relay wrote:
>>> From: Markuss Broks <markuss.broks@gmail.com>
>>>
>>> Those are the required changes for the BCM4361 PCIe chipset support.
>>
>> Hi Markuss,
>>
>> That is a brief commit message. Maybe you can provide a bit of context 
>> for this patch answering these questions: Are you using this device in 
>> some project? What platform are you using (if any)? What works and 
>> what does not?
> I was just looking at similar device additions in brcmfmac, and noticed 
> they didn't have much of a description, so I decided not to add much 
> either. Should I add some general info about the BCM4361 into the commit 
> message?
> 
> BCM4361 is used on the Samsung Galaxy S9 device (samsung-starlte), based 
> on Exynos9810. There it's connected via PCIe link. Not sure if perhaps 
> there's SDIO or USB or other variants of this chipset. Everything 
> "basic" seems to work, seems to connect to both 2.4GHz and 5GHz 
> networks, download speed looks good. Haven't tried station mode, but I'm 
> not sure what's the proper way to set it up anyway.

Mentioning the platform you tested these patches on is sufficient. So 
when you say "connect to both 2.4GHz and 5GHz networks" I somehow 
suspect you already covered station mode.
  >>
>>> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
>>> ---
>>> Changes in v2:
>>> - EDITME: describe what is new in this series revision.
>>> - EDITME: use bulletpoints and terse descriptions.
>>
>> This really does not look very useful. Those EDITME: are for you! As the
>> actual patch did not change you can probably say:
>>   - fix subject format indicating wifi subsystem and wireless-next repo.
> 
> Oh, sorry, I did not notice that b4 puts the changelog there if it's not 
> in the cover letter. It's been a while since I last submitted 
> something :) I will add the changelog there for v2 and v3 once I submit 
> a v3.

Sure. No problem.

>>
>>> - Link to v1: https://patch.msgid.link/20260803-broadcom-staging- 
>>> v1-1-f6f77e55b72e@gmail.com
>>> ---
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
>>> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
>>> 3 files changed, 8 insertions(+)
>>
>> [...]
>>
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> index 55f4d7b970f2..914ae72a7b74 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> @@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
>>> BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
>>> BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
>>> BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
>>> +BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");
>>
>> Are you sure the CLM blob is required? Can you test without it being 
>> present in /lib/firmware?
> I have tried without the CLM blob, it says "no clm blob available, 
> device might have limited channels available" but seems to at least 
> somewhat work, I haven't noticed a difference. It's still a good idea to 
> load it probably, right?

Right. I was just curious whether it has a working CLM blob compiled in 
firmware or not.

>>
>>> BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
>>> BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
>>> BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");
>>
>> [...]
>>
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/ 
>>> brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/ 
>>> brcm_hw_ids.h
>>> index df3b67ba4db2..b800cbfdece1 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>
>> [...]
>>
>>> @@ -86,6 +87,7 @@
>>> #define BRCM_PCIE_43602_2G_DEVICE_ID 0x43bb
>>> #define BRCM_PCIE_43602_5G_DEVICE_ID 0x43bc
>>> #define BRCM_PCIE_43602_RAW_DEVICE_ID 43602
>>> +#define BRCM_PCIE_4361_DEVICE_ID 0x441f
>>
>> Please add:
>> +#define BRCM_PCIE_4361_2G_DEVICE_ID 0x4420
>> +#define BRCM_PCIE_4361_5G_DEVICE_ID 0x4421
> 
> Are those some special variants of the chipset?

Not really. The difference is in the radio frontend. 0x441f is a 
dual-band. The other two have only a single band so the board gets a bit 
cheaper. The device id is programmed in on-chip OTP so firmware knows 
what type of board it is running on.

Regards,
Arend

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset
  2026-08-05 15:16     ` Arend van Spriel
@ 2026-08-05 15:20       ` Markuss Broks
  0 siblings, 0 replies; 5+ messages in thread
From: Markuss Broks @ 2026-08-05 15:20 UTC (permalink / raw)
  To: Arend van Spriel
  Cc: Johannes Berg, linux-wireless, brcm80211, brcm80211-dev-list.pdl,
	linux-kernel

Hi Arend,

On 8/5/26 6:16 PM, Arend van Spriel wrote:
> On 05/08/2026 15:56, Markuss Broks wrote:
>> Hi Arend,
>>
>> On 8/5/26 8:46 AM, Arend van Spriel wrote:
>>> On 04/08/2026 16:07, Markuss Broks via B4 Relay wrote:
>>>> From: Markuss Broks <markuss.broks@gmail.com>
>>>>
>>>> Those are the required changes for the BCM4361 PCIe chipset support.
>>>
>>> Hi Markuss,
>>>
>>> That is a brief commit message. Maybe you can provide a bit of 
>>> context for this patch answering these questions: Are you using this 
>>> device in some project? What platform are you using (if any)? What 
>>> works and what does not?
>> I was just looking at similar device additions in brcmfmac, and 
>> noticed they didn't have much of a description, so I decided not to 
>> add much either. Should I add some general info about the BCM4361 
>> into the commit message?
>>
>> BCM4361 is used on the Samsung Galaxy S9 device (samsung-starlte), 
>> based on Exynos9810. There it's connected via PCIe link. Not sure if 
>> perhaps there's SDIO or USB or other variants of this chipset. 
>> Everything "basic" seems to work, seems to connect to both 2.4GHz and 
>> 5GHz networks, download speed looks good. Haven't tried station mode, 
>> but I'm not sure what's the proper way to set it up anyway.
>
> Mentioning the platform you tested these patches on is sufficient. So 
> when you say "connect to both 2.4GHz and 5GHz networks" I somehow 
> suspect you already covered station mode.
Okay, sure. I guess I kinda mixed up the terminology here, I meant to 
say that I haven't tested the AP mode, not the station mode, sorry for 
the confusion.
>  >>
>>>> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
>>>> ---
>>>> Changes in v2:
>>>> - EDITME: describe what is new in this series revision.
>>>> - EDITME: use bulletpoints and terse descriptions.
>>>
>>> This really does not look very useful. Those EDITME: are for you! As 
>>> the
>>> actual patch did not change you can probably say:
>>>   - fix subject format indicating wifi subsystem and wireless-next 
>>> repo.
>>
>> Oh, sorry, I did not notice that b4 puts the changelog there if it's 
>> not in the cover letter. It's been a while since I last submitted 
>> something :) I will add the changelog there for v2 and v3 once I 
>> submit a v3.
>
> Sure. No problem.
>
>>>
>>>> - Link to v1: https://patch.msgid.link/20260803-broadcom-staging- 
>>>> v1-1-f6f77e55b72e@gmail.com
>>>> ---
>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 3 +++
>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 3 +++
>>>> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 2 ++
>>>> 3 files changed, 8 insertions(+)
>>>
>>> [...]
>>>
>>>> diff --git 
>>>> a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
>>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> index 55f4d7b970f2..914ae72a7b74 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> @@ -59,6 +59,7 @@ BRCMF_FW_CLM_DEF(43570, "brcmfmac43570-pcie");
>>>> BRCMF_FW_DEF(4358, "brcmfmac4358-pcie");
>>>> BRCMF_FW_DEF(4359, "brcmfmac4359-pcie");
>>>> BRCMF_FW_DEF(4359C, "brcmfmac4359c-pcie");
>>>> +BRCMF_FW_CLM_DEF(4361, "brcmfmac4361-pcie");
>>>
>>> Are you sure the CLM blob is required? Can you test without it being 
>>> present in /lib/firmware?
>> I have tried without the CLM blob, it says "no clm blob available, 
>> device might have limited channels available" but seems to at least 
>> somewhat work, I haven't noticed a difference. It's still a good idea 
>> to load it probably, right?
>
> Right. I was just curious whether it has a working CLM blob compiled 
> in firmware or not.
>
>>>
>>>> BRCMF_FW_CLM_DEF(4364B2, "brcmfmac4364b2-pcie");
>>>> BRCMF_FW_CLM_DEF(4364B3, "brcmfmac4364b3-pcie");
>>>> BRCMF_FW_DEF(4365B, "brcmfmac4365b-pcie");
>>>
>>> [...]
>>>
>>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/ 
>>>> brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/ 
>>>> brcm_hw_ids.h
>>>> index df3b67ba4db2..b800cbfdece1 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>
>>> [...]
>>>
>>>> @@ -86,6 +87,7 @@
>>>> #define BRCM_PCIE_43602_2G_DEVICE_ID 0x43bb
>>>> #define BRCM_PCIE_43602_5G_DEVICE_ID 0x43bc
>>>> #define BRCM_PCIE_43602_RAW_DEVICE_ID 43602
>>>> +#define BRCM_PCIE_4361_DEVICE_ID 0x441f
>>>
>>> Please add:
>>> +#define BRCM_PCIE_4361_2G_DEVICE_ID 0x4420
>>> +#define BRCM_PCIE_4361_5G_DEVICE_ID 0x4421
>>
>> Are those some special variants of the chipset?
>
> Not really. The difference is in the radio frontend. 0x441f is a 
> dual-band. The other two have only a single band so the board gets a 
> bit cheaper. The device id is programmed in on-chip OTP so firmware 
> knows what type of board it is running on.
Okay, I see, thanks for the explanation!
>
> Regards,
> Arend

-Markuss


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-05 15:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-04 14:07 [PATCH wireless-next v2] wifi: brcmfmac: Add support for BCM4361 PCIe chipset Markuss Broks via B4 Relay
2026-08-05  5:46 ` Arend van Spriel
2026-08-05 13:56   ` Markuss Broks
2026-08-05 15:16     ` Arend van Spriel
2026-08-05 15:20       ` Markuss Broks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox