* [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
@ 2026-08-04 6:24 Hongfu Li
2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
0 siblings, 1 reply; 5+ messages in thread
From: Hongfu Li @ 2026-08-04 6:24 UTC (permalink / raw)
To: akpm, david, ljs, liam, vbabka, rppt, surenb, mhocko, shuah
Cc: linux-mm, linux-kselftest, linux-kernel, hongfu.li, Hongfu Li
From: Hongfu Li <lihongfu@kylinos.cn>
mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
The second run repeats all assertions with no benefit. Drop the
duplicate call.
Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
---
tools/testing/selftests/mm/mseal_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index 93c2e13094d4..babc217d9dc9 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -1913,7 +1913,6 @@ int main(void)
test_seal_mprotect_partial_mprotect(false);
test_seal_mprotect_partial_mprotect(true);
- test_seal_mprotect_two_vma_with_gap();
test_seal_mprotect_two_vma_with_gap();
test_seal_mprotect_merge(false);
--
2.54.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
2026-08-04 6:24 [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call Hongfu Li
@ 2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
2026-08-04 8:24 ` Lorenzo Stoakes (ARM)
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-08-04 8:20 UTC (permalink / raw)
To: Hongfu Li
Cc: akpm, david, liam, vbabka, rppt, surenb, mhocko, shuah, linux-mm,
linux-kselftest, linux-kernel, Hongfu Li
On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@kylinos.cn>
>
> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> The second run repeats all assertions with no benefit. Drop the
> duplicate call.
>
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
:))
LGTM so
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/mseal_test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index 93c2e13094d4..babc217d9dc9 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1913,7 +1913,6 @@ int main(void)
> test_seal_mprotect_partial_mprotect(false);
> test_seal_mprotect_partial_mprotect(true);
>
> - test_seal_mprotect_two_vma_with_gap();
> test_seal_mprotect_two_vma_with_gap();
>
> test_seal_mprotect_merge(false);
> --
> 2.54.0
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
@ 2026-08-04 8:24 ` Lorenzo Stoakes (ARM)
2026-08-04 8:51 ` Hongfu Li
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-08-04 8:24 UTC (permalink / raw)
To: Hongfu Li
Cc: akpm, david, liam, vbabka, rppt, surenb, mhocko, shuah, linux-mm,
linux-kselftest, linux-kernel, Hongfu Li, Pedro Falcato
On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
> > From: Hongfu Li <lihongfu@kylinos.cn>
> >
> > mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> > The second run repeats all assertions with no benefit. Drop the
> > duplicate call.
> >
> > Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>
> :))
>
> LGTM so
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Sorry Pedro mentioned off-list that you need to update the number of tests
specified, e.g.:
- ksft_set_plan(88);
+ ksft_set_plan(87);
In main().
Update that and send a respin and you can attach my tag to it.
>
> > ---
> > tools/testing/selftests/mm/mseal_test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> > index 93c2e13094d4..babc217d9dc9 100644
> > --- a/tools/testing/selftests/mm/mseal_test.c
> > +++ b/tools/testing/selftests/mm/mseal_test.c
> > @@ -1913,7 +1913,6 @@ int main(void)
> > test_seal_mprotect_partial_mprotect(false);
> > test_seal_mprotect_partial_mprotect(true);
> >
> > - test_seal_mprotect_two_vma_with_gap();
> > test_seal_mprotect_two_vma_with_gap();
> >
> > test_seal_mprotect_merge(false);
> > --
> > 2.54.0
> >
>
> --
> Cheers, Lorenzo
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
2026-08-04 8:24 ` Lorenzo Stoakes (ARM)
@ 2026-08-04 8:51 ` Hongfu Li
2026-08-04 9:25 ` David Hildenbrand (Arm)
0 siblings, 1 reply; 5+ messages in thread
From: Hongfu Li @ 2026-08-04 8:51 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM)
Cc: hongfu.li, akpm, david, liam, vbabka, rppt, surenb, mhocko, shuah,
linux-mm, linux-kselftest, linux-kernel, Hongfu Li, Pedro Falcato,
Hongfu Li
On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
>>> From: Hongfu Li <lihongfu@kylinos.cn>
>>>
>>> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
>>> The second run repeats all assertions with no benefit. Drop the
>>> duplicate call.
>>>
>>> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>> :))
>>
>> LGTM so
>>
>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Sorry Pedro mentioned off-list that you need to update the number of tests
> specified, e.g.:
>
> - ksft_set_plan(88);
> + ksft_set_plan(87);
>
> In main().
>
> Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to
87 in main() and
send a respin carrying your Reviewed-by.
--
Best regards,
Hongfu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
2026-08-04 8:51 ` Hongfu Li
@ 2026-08-04 9:25 ` David Hildenbrand (Arm)
0 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand (Arm) @ 2026-08-04 9:25 UTC (permalink / raw)
To: Hongfu Li, Lorenzo Stoakes (ARM)
Cc: akpm, liam, vbabka, rppt, surenb, mhocko, shuah, linux-mm,
linux-kselftest, linux-kernel, Hongfu Li, Pedro Falcato
On 8/4/26 10:51, Hongfu Li wrote:
>
> On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>>> :))
>>>
>>> LGTM so
>>>
>>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
>> Sorry Pedro mentioned off-list that you need to update the number of tests
>> specified, e.g.:
>>
>> - ksft_set_plan(88);
>> + ksft_set_plan(87);
>>
>> In main().
>>
>> Update that and send a respin and you can attach my tag to it.
> Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 87 in main() and
> send a respin carrying your Reviewed-by.
>
Feel free to add
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
to the respin.
--
Cheers,
David
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-04 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-04 6:24 [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call Hongfu Li
2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
2026-08-04 8:24 ` Lorenzo Stoakes (ARM)
2026-08-04 8:51 ` Hongfu Li
2026-08-04 9:25 ` David Hildenbrand (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox