[PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h

[PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h

[Thorsten Blum]

Include asm-generic/serial.h and use the generic BASE_BAUD definition
instead of redefining it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/parisc/include/asm/serial.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/parisc/include/asm/serial.h b/arch/parisc/include/asm/serial.h
index 77e9b67c87ee..d9fd3f78d31f 100644
--- a/arch/parisc/include/asm/serial.h
+++ b/arch/parisc/include/asm/serial.h
@@ -2,7 +2,4 @@
  * include/asm-parisc/serial.h
  */
 
-/*
- * This is used for 16550-compatible UARTs
- */
-#define BASE_BAUD ( 1843200 / 16 )
+#include <asm-generic/serial.h>

[PATCH 2/3] parisc/serial: Add include guard to asm/serial.h

[Thorsten Blum]

Add an include guard and remove the stale filename comment while at it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/parisc/include/asm/serial.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/parisc/include/asm/serial.h b/arch/parisc/include/asm/serial.h
index d9fd3f78d31f..4f0df8e10a4f 100644
--- a/arch/parisc/include/asm/serial.h
+++ b/arch/parisc/include/asm/serial.h
@@ -1,5 +1,6 @@
-/*
- * include/asm-parisc/serial.h
- */
+#ifndef _ASM_PARISC_SERIAL_H
+#define _ASM_PARISC_SERIAL_H
 
 #include <asm-generic/serial.h>
+
+#endif /* _ASM_PARISC_SERIAL_H */

[PATCH 3/3] parisc/serial: Add SPDX license identifier to asm/serial.h

[Thorsten Blum]

Add the SPDX license identifier.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/parisc/include/asm/serial.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/parisc/include/asm/serial.h b/arch/parisc/include/asm/serial.h
index 4f0df8e10a4f..122430db8cad 100644
--- a/arch/parisc/include/asm/serial.h
+++ b/arch/parisc/include/asm/serial.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _ASM_PARISC_SERIAL_H
 #define _ASM_PARISC_SERIAL_H
 

Re: [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h

[Helge Deller]

Hi Thorsten,

On 8/4/26 15:20, Thorsten Blum wrote:
> Include asm-generic/serial.h and use the generic BASE_BAUD definition
> instead of redefining it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>   arch/parisc/include/asm/serial.h | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h
and adding the patch below the better approach?

Helge

diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild
index d48d158f7241..4fc315085914 100644
--- a/arch/parisc/include/asm/Kbuild
+++ b/arch/parisc/include/asm/Kbuild
@@ -6,3 +6,4 @@ generic-y += kvm_para.h
  generic-y += mcs_spinlock.h
  generic-y += ring_buffer.h
  generic-y += user.h
+generic-y += serial.h

Re: [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h

[Thorsten Blum]

On Tue, Aug 04, 2026 at 03:29:51PM +0200, Helge Deller wrote:
> Hi Thorsten,
> 
> On 8/4/26 15:20, Thorsten Blum wrote:
> > Include asm-generic/serial.h and use the generic BASE_BAUD definition
> > instead of redefining it.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > ---
> >   arch/parisc/include/asm/serial.h | 5 +----
> >   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h
> and adding the patch below the better approach?

It was a single patch at some point, but since serial.h is otherwise
empty, your approach seems a lot nicer. I'll send a v2.

Thanks,
Thorsten

> diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild
> index d48d158f7241..4fc315085914 100644
> --- a/arch/parisc/include/asm/Kbuild
> +++ b/arch/parisc/include/asm/Kbuild
> @@ -6,3 +6,4 @@ generic-y += kvm_para.h
>  generic-y += mcs_spinlock.h
>  generic-y += ring_buffer.h
>  generic-y += user.h
> +generic-y += serial.h