The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] net: eql.c: fix switch case indent
@ 2026-07-31 12:25 oshada imalka
  2026-08-04 23:57 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: oshada imalka @ 2026-07-31 12:25 UTC (permalink / raw)
  To: andrew+netdev, davem, edumazet, kuba, pabeni
  Cc: netdev, linux-kernel, oshada imalka

Fix ERROR: switch and case should be at the same indent

Signed-off-by: oshada imalka <developerimalka@gmail.com>
---
 drivers/net/eql.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/net/eql.c b/drivers/net/eql.c
index 06083b9841ba..5fbcb9a4a31b 100644
--- a/drivers/net/eql.c
+++ b/drivers/net/eql.c
@@ -281,20 +281,20 @@ static int eql_siocdevprivate(struct net_device *dev, struct ifreq *ifr,
 		return -EOPNOTSUPP;
 
 	switch (cmd) {
-		case EQL_ENSLAVE:
-			return eql_enslave(dev, data);
-		case EQL_EMANCIPATE:
-			return eql_emancipate(dev, data);
-		case EQL_GETSLAVECFG:
-			return eql_g_slave_cfg(dev, data);
-		case EQL_SETSLAVECFG:
-			return eql_s_slave_cfg(dev, data);
-		case EQL_GETMASTRCFG:
-			return eql_g_master_cfg(dev, data);
-		case EQL_SETMASTRCFG:
-			return eql_s_master_cfg(dev, data);
-		default:
-			return -EOPNOTSUPP;
+	case EQL_ENSLAVE:
+		return eql_enslave(dev, data);
+	case EQL_EMANCIPATE:
+		return eql_emancipate(dev, data);
+	case EQL_GETSLAVECFG:
+		return eql_g_slave_cfg(dev, data);
+	case EQL_SETSLAVECFG:
+		return eql_s_slave_cfg(dev, data);
+	case EQL_GETMASTRCFG:
+		return eql_g_master_cfg(dev, data);
+	case EQL_SETMASTRCFG:
+		return eql_s_master_cfg(dev, data);
+	default:
+		return -EOPNOTSUPP;
 	}
 }
 
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: eql.c: fix switch case indent
  2026-07-31 12:25 [PATCH] net: eql.c: fix switch case indent oshada imalka
@ 2026-08-04 23:57 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-08-04 23:57 UTC (permalink / raw)
  To: oshada imalka
  Cc: andrew+netdev, davem, edumazet, pabeni, netdev, linux-kernel

On Fri, 31 Jul 2026 17:55:01 +0530 oshada imalka wrote:
> Fix ERROR: switch and case should be at the same indent

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
    
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-04 23:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 12:25 [PATCH] net: eql.c: fix switch case indent oshada imalka
2026-08-04 23:57 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox