From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Crescent Hsieh <crescentcy.hsieh@moxa.com>
Subject: Re: [PATCH] tty: moxa: remove driver.
Date: Tue, 4 Aug 2026 11:57:49 +0200 [thread overview]
Message-ID: <2026080429-deforest-snowiness-90ad@gregkh> (raw)
In-Reply-To: <7a3538e1-444d-42f5-b48a-0a8eb9f2625f@kernel.org>
On Tue, Aug 04, 2026 at 07:12:01AM +0200, Jiri Slaby wrote:
> On 03. 08. 26, 14:52, Greg Kroah-Hartman wrote:
> > This is a very old driver, and no known hardware is still around for it,
> > and the company says they do not need it anymore, so let's remove it as
> > the LLMs are starting to poke at it and find "interesting" things which
> > will just waste everyone's time given it's not actually used.
> >
> > So let's drop it. If someone really needs it, it can come back in the
> > future, in a more "modern" way, as the style here is very old...
> >
> > Reported-by: Jiri Slaby <jirislaby@kernel.org>
> > Cc: Crescent Hsieh <crescentcy.hsieh@moxa.com>
> > Link: https://lore.kernel.org/all/afqyY8FQ8ZfpH48_@moxa-ThinkCentre-M90t/
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> LGTM, there are leftovers though:
> MAINTAINERS
> 18341:MOXA SMARTIO/INDUSTIO/INTELLIO SERIAL CARD
As you said, that one documents the mxser.c file, not moxa.c, so should
I just remove both and this entry too?
And the .rst file needs to go, right?
> Documentation/admin-guide/devices.txt
> 2391: 172 char Moxa Intellio serial card
> 2398: 173 char Moxa Intellio serial card - alternate devices
Oops, missed that.
> =========
>
> Funilly, the MAINTAINERS entry was supposed to be for both mxser
> (SMARTIO/INDUSTIO) and moxa (INTELLIO), but the F: pattern for moxa was
> never added (cf. 679655daffdd). INTELLIO should dismiss from there,
> nonetheless.
As above, should we also just drop mxser? Same age of the hardware from
what I can tell.
thanks,
greg k-h
next prev parent reply other threads:[~2026-08-04 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 12:52 [PATCH] tty: moxa: remove driver Greg Kroah-Hartman
2026-08-04 5:12 ` Jiri Slaby
2026-08-04 9:57 ` Greg Kroah-Hartman [this message]
2026-08-04 10:18 ` Jiri Slaby
2026-08-04 10:19 ` Jiri Slaby
2026-08-04 13:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026080429-deforest-snowiness-90ad@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=crescentcy.hsieh@moxa.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox