* [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data()
@ 2026-08-06 8:43 Joshua Crofts
2026-08-06 8:47 ` Joshua Crofts
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Crofts @ 2026-08-06 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman, Heikki Krogerus
Cc: Andy Shevchenko, linux-usb, linux-kernel,
syzbot+6c7e68b141ebd3a2cadf
In stusb160x_probe(), the return value of i2c_get_match_data() is not
checked, causing a null pointer dereference later on if the device was
registered manually (without devicetree or ACPI).
Fix this by adding a NULL check for the return value of
i2c_get_match_data().
Reported-by: syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=6c7e68b141ebd3a2cadf
Fixes: 823754697556 ("usb: typec: stusb160x: Make use of i2c_get_match_data()")
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/usb/typec/stusb160x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
index 6d85b25b40bc..8f3435c669cd 100644
--- a/drivers/usb/typec/stusb160x.c
+++ b/drivers/usb/typec/stusb160x.c
@@ -645,6 +645,8 @@ static int stusb160x_probe(struct i2c_client *client)
i2c_set_clientdata(client, chip);
regmap_config = i2c_get_match_data(client);
+ if (!regmap_config)
+ return -ENODEV;
chip->regmap = devm_regmap_init_i2c(client, regmap_config);
if (IS_ERR(chip->regmap)) {
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data()
2026-08-06 8:43 [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data() Joshua Crofts
@ 2026-08-06 8:47 ` Joshua Crofts
0 siblings, 0 replies; 2+ messages in thread
From: Joshua Crofts @ 2026-08-06 8:47 UTC (permalink / raw)
To: Greg Kroah-Hartman, Heikki Krogerus
Cc: Andy Shevchenko, linux-usb, linux-kernel,
syzbot+6c7e68b141ebd3a2cadf
On Thu, 6 Aug 2026 08:43:01 +0000
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> In stusb160x_probe(), the return value of i2c_get_match_data() is not
> checked, causing a null pointer dereference later on if the device was
> registered manually (without devicetree or ACPI).
>
> Fix this by adding a NULL check for the return value of
> i2c_get_match_data().
>
> Reported-by: syzbot+6c7e68b141ebd3a2cadf@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6c7e68b141ebd3a2cadf
> Fixes: 823754697556 ("usb: typec: stusb160x: Make use of i2c_get_match_data()")
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
Ugh, forgot to Cc stable.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-06 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 8:43 [PATCH] usb: typec: stusb160x: add missing NULL check for i2c_get_match_data() Joshua Crofts
2026-08-06 8:47 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox