The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [GIT PULL] probes: Fixes for v7.2-rc6
@ 2026-08-06 13:49 Masami Hiramatsu
  2026-08-06 16:01 ` pr-tracker-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Masami Hiramatsu @ 2026-08-06 13:49 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Martin Kaiser, Steven Rostedt, Masami Hiramatsu, linux-kernel

Hi Linus,

Probes fixes for v7.2-rc6:

- selftests/ftrace: Refactor eprobes test to fix argument checks
  Refactor the eprobes selftest to get more stable test result by using
  `sys_enter_chdir` instead of `openat` and filter for exact directory
  names. This resolves test instability after string pointer handling fix.


Please pull the latest probes-fixes-v7.2-rc6 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
probes-fixes-v7.2-rc6

Tag SHA1: f5e412335622b0af9975ea0a3ffffa228f0214ef
Head SHA1: 6e3abef2a27e7402a94111c9eff85d887e64a309


Martin Kaiser (1):
      selftests/ftrace: refactor eprobes test to fix argument checks

----
 .../ftrace/test.d/dynevent/add_remove_eprobe.tc          | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)
---------------------------
commit 6e3abef2a27e7402a94111c9eff85d887e64a309
Author: Martin Kaiser <martin@kaiser.cx>
Date:   Tue Aug 4 21:46:35 2026 +0200

    selftests/ftrace: refactor eprobes test to fix argument checks
    
    The add/remove eprobe test installs an eprobe for the openat syscall and
    runs ls. It checks the filenames that were opened by ls against a
    whitelist and a blacklist.
    
    Commit 206b25c09080 ("tracing: eprobe: read the complete FILTER_PTR_STRING
    pointer") fixed access to some string fields in eprobes. This triggers
    test failures as the blacklist does not allow relative paths for the
    openat parameters.
    
    What makes this test unstable is the fact that the openat calls vary a
    lot between different systems.
    
    Refactor the test to make it more robust. "cd <directory>" will issue a
    chdir syscall with the target directory as parameter. Set an eprobe on
    the sys_enter_chdir event and filter for the exact directory name. Allow
    (fault) as fallback.
    
    Link: https://lore.kernel.org/all/20260804194705.760893-1-martin@kaiser.cx/
    
    Fixes: 206b25c09080 ("tracing: eprobe: read the complete FILTER_PTR_STRING pointer")
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Closes: https://lore.kernel.org/oe-lkp/202607151010.b68428e1-lkp@intel.com
    Signed-off-by: Martin Kaiser <martin@kaiser.cx>
    Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
index c300eb020262..e2322693d0c3 100644
--- a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
+++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
@@ -1,16 +1,16 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Generic dynamic event - add/remove eprobe events
-# requires: dynamic_events events/syscalls/sys_enter_openat "<attached-group>.<attached-event> [<args>]":README
+# requires: dynamic_events events/syscalls/sys_enter_chdir "<attached-group>.<attached-event> [<args>]":README
 
 echo 0 > events/enable
 
 clear_dynamic_events
 
 SYSTEM="syscalls"
-EVENT="sys_enter_openat"
+EVENT="sys_enter_chdir"
 FIELD="filename"
-EPROBE="eprobe_open"
+EPROBE="eprobe_chdir"
 OPTIONS="file=+0(\$filename):ustring"
 echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
 
@@ -18,20 +18,14 @@ grep -q "$EPROBE" dynamic_events
 test -d events/eprobes/$EPROBE
 
 echo 1 > events/eprobes/$EPROBE/enable
-ls
+cd /sys/kernel/tracing
 echo 0 > events/eprobes/$EPROBE/enable
 
-content=`grep '^ *ls-' trace | grep 'file='`
-nocontent=`grep '^ *ls-' trace | grep 'file=' | grep -v -e '"/' -e '"."' -e '(fault)' ` || true
-
+content=`grep -e 'file="/sys/kernel/tracing"\|(fault)' trace`
 if [ -z "$content" ]; then
 	exit_fail
 fi
 
-if [ ! -z "$nocontent" ]; then
-	exit_fail
-fi
-
 echo "-:$EPROBE" >> dynamic_events
 
 ! grep -q "$EPROBE" dynamic_events

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] probes: Fixes for v7.2-rc6
  2026-08-06 13:49 [GIT PULL] probes: Fixes for v7.2-rc6 Masami Hiramatsu
@ 2026-08-06 16:01 ` pr-tracker-bot
  0 siblings, 0 replies; 2+ messages in thread
From: pr-tracker-bot @ 2026-08-06 16:01 UTC (permalink / raw)
  To: Masami Hiramatsu (Google)
  Cc: Linus Torvalds, Martin Kaiser, Steven Rostedt, Masami Hiramatsu,
	linux-kernel

The pull request you sent on Thu, 6 Aug 2026 22:49:50 +0900:

> git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git probes-fixes-v7.2-rc6

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fcaeecb8b0cd44f77d03b28de0671258d4db18f8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-06 16:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 13:49 [GIT PULL] probes: Fixes for v7.2-rc6 Masami Hiramatsu
2026-08-06 16:01 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox