[PATCH] net: qrtr: ns: Raise lookup limit to 128

[PATCH] net: qrtr: ns: Raise lookup limit to 128

[Łukasz Patron]

Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).

Fixes: 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
---
 net/qrtr/ns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
index e5b2adb161d9..c5e7e01db249 100644
--- a/net/qrtr/ns.c
+++ b/net/qrtr/ns.c
@@ -78,7 +78,7 @@ struct qrtr_node {
  */
 #define QRTR_NS_MAX_NODES   512
 #define QRTR_NS_MAX_SERVERS 256
-#define QRTR_NS_MAX_LOOKUPS 64
+#define QRTR_NS_MAX_LOOKUPS 128
 
 static u16 node_count;
 
-- 
2.55.0

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[Simon Horman]

On Tue, Aug 04, 2026 at 10:18:30PM +0200, Łukasz Patron wrote:
> Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).
> 
> Fixes: 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
> Signed-off-by: Łukasz Patron <priv.luk@gmail.com>

Hi Łukasz,

I think that this needs some more explanation.

E.g.:
Why is it insufficient on the cited device?
What is the user experience with the current and new limits?
Why is this considered a bug rather than enabling a device that
didn't work before?

-- 
pw-bot: changes-requested

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[Łukasz Patron]

Hi,

After merging v6.6.142 into a downstream AOSP device, it's stuck on
boot animation and following log spam can be observed in dmesg:

E qrtr    : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
E qrtr    : qrtr_ns_worker(): failed while handling packet from 1:16600

No idea why it needs more than 64 client lookups, but it appears to
work fine with 128 as it did when there were no limits.

Also, I don't really have a good way to investigate what it needs all
these lookups for as most of the userspace is closed source. Perhaps
someone working at Qualcomm could have some ideas.

On Thu, Aug 6, 2026 at 3:26 PM Simon Horman <horms@kernel.org> wrote:
>
> On Tue, Aug 04, 2026 at 10:18:30PM +0200, Łukasz Patron wrote:
> > Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).
> >
> > Fixes: 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
> > Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
>
> Hi Łukasz,
>
> I think that this needs some more explanation.
>
> E.g.:
> Why is it insufficient on the cited device?
> What is the user experience with the current and new limits?
> Why is this considered a bug rather than enabling a device that
> didn't work before?
>
> --
> pw-bot: changes-requested

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[Jakub Kicinski]

On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:
> After merging v6.6.142 into a downstream AOSP device, it's stuck on
> boot animation and following log spam can be observed in dmesg:
> 
> E qrtr    : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
> E qrtr    : qrtr_ns_worker(): failed while handling packet from 1:16600
> 
> No idea why it needs more than 64 client lookups, but it appears to
> work fine with 128 as it did when there were no limits.

Ack, I'll fold the explanation into the commit msg. pls don't repost.

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  4 Aug 2026 22:18:30 +0200 you wrote:
> Current limit of 64 is not enough for Sony Xperia 10 VII (SM6475).
> 
> Fixes: 5640227d9a21 ("net: qrtr: ns: Limit the maximum number of lookups")
> Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
> ---
>  net/qrtr/ns.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - net: qrtr: ns: Raise lookup limit to 128
    https://git.kernel.org/netdev/net/c/7fc1c937b6b3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[Manivannan Sadhasivam]

On Thu, Aug 06, 2026 at 07:27:02AM -0700, Jakub Kicinski wrote:
> On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:
> > After merging v6.6.142 into a downstream AOSP device, it's stuck on
> > boot animation and following log spam can be observed in dmesg:
> > 
> > E qrtr    : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
> > E qrtr    : qrtr_ns_worker(): failed while handling packet from 1:16600
> > 
> > No idea why it needs more than 64 client lookups, but it appears to
> > work fine with 128 as it did when there were no limits.
> 
> Ack, I'll fold the explanation into the commit msg. pls don't repost.

With the added info,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

- Mani

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] net: qrtr: ns: Raise lookup limit to 128

[Simon Horman]

On Thu, Aug 06, 2026 at 06:00:23PM +0200, Manivannan Sadhasivam wrote:
> On Thu, Aug 06, 2026 at 07:27:02AM -0700, Jakub Kicinski wrote:
> > On Thu, 6 Aug 2026 15:38:22 +0200 Łukasz Patron wrote:
> > > After merging v6.6.142 into a downstream AOSP device, it's stuck on
> > > boot animation and following log spam can be observed in dmesg:
> > > 
> > > E qrtr    : ctrl_cmd_new_lookup(): QRTR client node exceeds max lookup limit!
> > > E qrtr    : qrtr_ns_worker(): failed while handling packet from 1:16600
> > > 
> > > No idea why it needs more than 64 client lookups, but it appears to
> > > work fine with 128 as it did when there were no limits.
> > 
> > Ack, I'll fold the explanation into the commit msg. pls don't repost.
> 
> With the added info,
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

Likewise,

Reviewed-by: Simon Horman <horms@kernel.org>