[PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads

[PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads

[Cong Nguyen]

The MAX1363 differential channels are bipolar (scan_type.sign = 's') and
the device returns those samples in two's complement. However
max1363_read_single_chan() masks the raw value to the ADC resolution and
stores it as-is, without sign extension. A negative differential reading
is therefore reported to userspace as a large positive value (for a 12-bit
part, -1 reads back as 4095).

These channels expose only IIO_CHAN_INFO_RAW (no offset), so the raw sysfs
value is expected to be the signed result. Sign-extend the masked value
from the resolution bit for differential channels before returning it.
Single-ended channels are unipolar (sign = 'u') and are left unchanged.

Fixes: 168c9d95a940 ("iio:adc:max1363 move from staging.")
Cc: stable@vger.kernel.org
Assisted-by: Claude:claude-opus-4
Signed-off-by: Cong Nguyen <congnt264@gmail.com>
---
 drivers/iio/adc/max1363.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index 4d0b79cfeb27..497f5daadcea 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -405,6 +405,14 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev,
 
 		data = rxbuf[0];
 	}
+
+	/*
+	 * Differential channels are bipolar and the device returns the sample
+	 * in two's complement, so sign-extend it from the resolution bit.
+	 */
+	if (chan->differential)
+		data = sign_extend32(data, st->chip_info->bits - 1);
+
 	*val = data;
 
 	return 0;
-- 
2.25.1

Re: [PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads

[Andy Shevchenko]

On Mon, Aug 10, 2026 at 9:42 AM Cong Nguyen <congnt264@gmail.com> wrote:
>
> The MAX1363 differential channels are bipolar (scan_type.sign = 's') and
> the device returns those samples in two's complement. However
> max1363_read_single_chan() masks the raw value to the ADC resolution and
> stores it as-is, without sign extension. A negative differential reading
> is therefore reported to userspace as a large positive value (for a 12-bit
> part, -1 reads back as 4095).

Try to make it more compact (remove unneeded or duplicative details,
do not blindly rely on AI).

> These channels expose only IIO_CHAN_INFO_RAW (no offset), so the raw sysfs
> value is expected to be the signed result. Sign-extend the masked value
> from the resolution bit for differential channels before returning it.
> Single-ended channels are unipolar (sign = 'u') and are left unchanged.

Same here.

> Fixes: 168c9d95a940 ("iio:adc:max1363 move from staging.")

This is a wrong reference in case the driver existed before (and that
is suggested by the commit description).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads

[Nguyễn Công]

On Mon, Aug 10, 2026 at 1:45 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Aug 10, 2026 at 9:42 AM Cong Nguyen <congnt264@gmail.com> wrote:
> >
> > The MAX1363 differential channels are bipolar (scan_type.sign = 's') and
> > the device returns those samples in two's complement. However
> > max1363_read_single_chan() masks the raw value to the ADC resolution and
> > stores it as-is, without sign extension. A negative differential reading
> > is therefore reported to userspace as a large positive value (for a 12-bit
> > part, -1 reads back as 4095).
>
> Try to make it more compact (remove unneeded or duplicative details,
> do not blindly rely on AI).

Done in v2 - trimmed both paragraphs down to the bug, one example, and
the fix.

>
> > These channels expose only IIO_CHAN_INFO_RAW (no offset), so the raw sysfs
> > value is expected to be the signed result. Sign-extend the masked value
> > from the resolution bit for differential channels before returning it.
> > Single-ended channels are unipolar (sign = 'u') and are left unchanged.
>
> Same here.
>
> > Fixes: 168c9d95a940 ("iio:adc:max1363 move from staging.")
>
> This is a wrong reference in case the driver existed before (and that
> is suggested by the commit description).
>
> --
> With Best Regards,
> Andy Shevchenko

Right, the bug predates the move. The driver was added in 2010 by
d1325cf45077 ("Staging: IIO: max1363 ADC driver"), which already reads
differential channels with an unsigned mask, so v2 uses that as the
Fixes: tag.
Thanks for the review.
Cong

Re: [PATCH] iio: adc: max1363: sign-extend bipolar differential channel reads

[Jonathan Cameron]

On Mon, 10 Aug 2026 23:50:53 +0700
Nguyễn Công <congnt264@gmail.com> wrote:

> On Mon, Aug 10, 2026 at 1:45 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Mon, Aug 10, 2026 at 9:42 AM Cong Nguyen <congnt264@gmail.com> wrote:  
> > >
> > > The MAX1363 differential channels are bipolar (scan_type.sign = 's') and
> > > the device returns those samples in two's complement. However
> > > max1363_read_single_chan() masks the raw value to the ADC resolution and
> > > stores it as-is, without sign extension. A negative differential reading
> > > is therefore reported to userspace as a large positive value (for a 12-bit
> > > part, -1 reads back as 4095).  
> >
> > Try to make it more compact (remove unneeded or duplicative details,
> > do not blindly rely on AI).  
> 
> Done in v2 - trimmed both paragraphs down to the bug, one example, and
> the fix.
> 
> >  
> > > These channels expose only IIO_CHAN_INFO_RAW (no offset), so the raw sysfs
> > > value is expected to be the signed result. Sign-extend the masked value
> > > from the resolution bit for differential channels before returning it.
> > > Single-ended channels are unipolar (sign = 'u') and are left unchanged.  
> >
> > Same here.
> >  
> > > Fixes: 168c9d95a940 ("iio:adc:max1363 move from staging.")  
> >
> > This is a wrong reference in case the driver existed before (and that
> > is suggested by the commit description).
> >
> > --
> > With Best Regards,
> > Andy Shevchenko  
> 
> Right, the bug predates the move. The driver was added in 2010 by
> d1325cf45077 ("Staging: IIO: max1363 ADC driver"), which already reads
> differential channels with an unsigned mask, so v2 uses that as the
> Fixes: tag.

Trivial thing to watch out for - don't put anything a thread that
smells like a tag.  b4 tends to scrape them and if I'm not paying
attention (or like in this case my git hooks catch it) we end up
with bonus tags.


> Thanks for the review.
> Cong