* [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible
@ 2026-08-05 10:22 Shehryar Ahmad
2026-08-12 1:54 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Shehryar Ahmad @ 2026-08-05 10:22 UTC (permalink / raw)
To: jic23
Cc: nuno.sa, Michael.Hennerich, dlechner, andy, robh, krzk+dt,
conor+dt, linux, linux-iio, devicetree, linux-kernel,
Shehryar Ahmad
The ADIS16203 has the same external interface as the already
documented ADIS16201/ADIS16209, for the properties covered by this
binding (compatible/reg, the DIO-based interrupt pin, and VDD
supply), verified by datasheets Table 5, Pin Function Descriptions,
in the respective Analog Devices datasheets. Some Auxiliary pins
differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203
use them as AUX COM), but these are not represented in this binding.
Add adis16203 to the existing enum rather than creating a separate
file.
Tested with checkpatch.pl --strict and dt_binding_check; both pass
with no warnings.
Three prior attempts to document this part are visible on the
mailing list, all as separate files, each redirected toward this
existing binding approach instead: Saalim Quadri, March 2025 [2],
and Sheng Kun Chang, April 2026 [3]. See below for Jonathan
Cameron's earlier, related attempt [1].
A richer version adding reset-gpios and a second interrupt
(interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in
2023 [1]. I tested the same additions locally for all three
parts; checkpatch and dt_binding_check both pass. It is not
included here, as it hasn't been verified against any real board
dts file, and none in-tree currently reference adis16201,
adis16203, or adis16209. Can send that as a follow-up if
wanted.
Link: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230129155602.740743-13-jic23@kernel.org/
Link: https://lore.kernel.org/all/5390c973-6a92-4de8-b00a-cd62af347ccb@kernel.org/
Link: https://lore.kernel.org/all/20260402-fair-wakeful-okapi-3c6dba@quoll/
Signed-off-by: Shehryar Ahmad <shehryar.amd@gmail.com>
---
.../devicetree/bindings/iio/accel/adi,adis16201.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
index b6ba7ad1..3ce5fb1b 100644
--- a/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/adi,adis16201.yaml
@@ -4,21 +4,23 @@
$id: http://devicetree.org/schemas/iio/accel/adi,adis16201.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: ADIS16201 Dual Axis Inclinometer and similar
+title: ADIS16201 Inclinometer and similar
maintainers:
- Jonathan Cameron <Jonathan.Cameron@huawei.com>
description: |
- Two similar parts from external interface point of view.
+ Three similar parts from external interface point of view.
SPI interface.
https://www.analog.com/en/products/adis16201.html
+ https://www.analog.com/en/products/adis16203.html
https://www.analog.com/en/products/adis16209.html
properties:
compatible:
enum:
- adi,adis16201
+ - adi,adis16203
- adi,adis16209
reg:
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible
2026-08-05 10:22 [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible Shehryar Ahmad
@ 2026-08-12 1:54 ` Rob Herring
2026-08-12 3:35 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2026-08-12 1:54 UTC (permalink / raw)
To: Shehryar Ahmad
Cc: jic23, nuno.sa, Michael.Hennerich, dlechner, andy, krzk+dt,
conor+dt, linux, linux-iio, devicetree, linux-kernel
On Wed, Aug 05, 2026 at 03:22:24PM +0500, Shehryar Ahmad wrote:
> The ADIS16203 has the same external interface as the already
> documented ADIS16201/ADIS16209, for the properties covered by this
> binding (compatible/reg, the DIO-based interrupt pin, and VDD
> supply), verified by datasheets Table 5, Pin Function Descriptions,
> in the respective Analog Devices datasheets. Some Auxiliary pins
> differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203
> use them as AUX COM), but these are not represented in this binding.
> Add adis16203 to the existing enum rather than creating a separate
> file.
>
> Tested with checkpatch.pl --strict and dt_binding_check; both pass
> with no warnings.
This is assumed, no need to record it forever in the commit.
> Three prior attempts to document this part are visible on the
> mailing list, all as separate files, each redirected toward this
> existing binding approach instead: Saalim Quadri, March 2025 [2],
> and Sheng Kun Chang, April 2026 [3]. See below for Jonathan
> Cameron's earlier, related attempt [1].
>
> A richer version adding reset-gpios and a second interrupt
> (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in
> 2023 [1]. I tested the same additions locally for all three
> parts; checkpatch and dt_binding_check both pass. It is not
> included here, as it hasn't been verified against any real board
> dts file, and none in-tree currently reference adis16201,
> adis16203, or adis16209. Can send that as a follow-up if
> wanted.
>
> Link: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230129155602.740743-13-jic23@kernel.org/
> Link: https://lore.kernel.org/all/5390c973-6a92-4de8-b00a-cd62af347ccb@kernel.org/
> Link: https://lore.kernel.org/all/20260402-fair-wakeful-okapi-3c6dba@quoll/
Thanks for the history. It should be after the '---' so it too is not
recorded in the commit.
>
> Signed-off-by: Shehryar Ahmad <shehryar.amd@gmail.com>
> ---
> .../devicetree/bindings/iio/accel/adi,adis16201.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible
2026-08-12 1:54 ` Rob Herring
@ 2026-08-12 3:35 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2026-08-12 3:35 UTC (permalink / raw)
To: Rob Herring
Cc: Shehryar Ahmad, nuno.sa, Michael.Hennerich, dlechner, andy,
krzk+dt, conor+dt, linux, linux-iio, devicetree, linux-kernel
On Tue, 11 Aug 2026 20:54:21 -0500
Rob Herring <robh@kernel.org> wrote:
> On Wed, Aug 05, 2026 at 03:22:24PM +0500, Shehryar Ahmad wrote:
> > The ADIS16203 has the same external interface as the already
> > documented ADIS16201/ADIS16209, for the properties covered by this
> > binding (compatible/reg, the DIO-based interrupt pin, and VDD
> > supply), verified by datasheets Table 5, Pin Function Descriptions,
> > in the respective Analog Devices datasheets. Some Auxiliary pins
> > differ (e.g. adis16209 marks a few pins DNC where adis16201/adis16203
> > use them as AUX COM), but these are not represented in this binding.
> > Add adis16203 to the existing enum rather than creating a separate
> > file.
> >
> > Tested with checkpatch.pl --strict and dt_binding_check; both pass
> > with no warnings.
>
> This is assumed, no need to record it forever in the commit.
>
> > Three prior attempts to document this part are visible on the
> > mailing list, all as separate files, each redirected toward this
> > existing binding approach instead: Saalim Quadri, March 2025 [2],
> > and Sheng Kun Chang, April 2026 [3]. See below for Jonathan
> > Cameron's earlier, related attempt [1].
Key thing here is that we generally don't take bindings for drivers
that are in staging and adis16203 remains there.
This patch looks good for when/if the driver is moved out of
staging. There have been various series on list for that so
perhaps ask those authors what current status is (just reply
to that series).
e.g.
https://lore.kernel.org/linux-iio/20260401162458.88110-1-nothingchang@mirrorstack.ai/
Which is the parent of the last link below and I think the last of
various attempts to do this.
Jonathan
> >
> > A richer version adding reset-gpios and a second interrupt
> > (interrupt-names: dio0/dio1) was proposed by Jonathan Cameron in
> > 2023 [1]. I tested the same additions locally for all three
> > parts; checkpatch and dt_binding_check both pass. It is not
> > included here, as it hasn't been verified against any real board
> > dts file, and none in-tree currently reference adis16201,
> > adis16203, or adis16209. Can send that as a follow-up if
> > wanted.
> >
> > Link: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230129155602.740743-13-jic23@kernel.org/
> > Link: https://lore.kernel.org/all/5390c973-6a92-4de8-b00a-cd62af347ccb@kernel.org/
> > Link: https://lore.kernel.org/all/20260402-fair-wakeful-okapi-3c6dba@quoll/
>
> Thanks for the history. It should be after the '---' so it too is not
> recorded in the commit.
>
> >
> > Signed-off-by: Shehryar Ahmad <shehryar.amd@gmail.com>
> > ---
> > .../devicetree/bindings/iio/accel/adi,adis16201.yaml | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-12 3:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-05 10:22 [PATCH] dt-bindings: iio: accel: adi,adis16201: add adis16203 compatible Shehryar Ahmad
2026-08-12 1:54 ` Rob Herring
2026-08-12 3:35 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox