* [PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer
@ 2026-08-11 13:08 Maxim Codita
2026-08-12 0:25 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Codita @ 2026-08-11 13:08 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman
Cc: linux-fbdev, linux-staging, linux-kernel, Maxim Codita
Fix a checkpatch.pl warning for g_def_fbmode by marking the pointer
as const. Ensures it is stored as read-only.
Note: g_fbmode[] is left as non-const as its elements are modified at
runtime by lynxfb_set_fbinfo() and sm750fb_setup().
Signed-off-by: Maxim Codita <maxkoditsa7c@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..cc38dac88a73 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -22,7 +22,7 @@ static int g_hwcursor = 1;
static int g_noaccel __ro_after_init;
static int g_nomtrr __ro_after_init;
static const char *g_fbmode[] = {NULL, NULL};
-static const char *g_def_fbmode = "1024x768-32@60";
+static const char * const g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview __ro_after_init;
static char *g_option;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer
2026-08-11 13:08 [PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer Maxim Codita
@ 2026-08-12 0:25 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-08-12 0:25 UTC (permalink / raw)
To: Maxim Codita
Cc: Sudip Mukherjee, Teddy Wang, linux-fbdev, linux-staging,
linux-kernel
On Tue, Aug 11, 2026 at 03:08:13PM +0200, Maxim Codita wrote:
> Fix a checkpatch.pl warning for g_def_fbmode by marking the pointer
> as const. Ensures it is stored as read-only.
>
> Note: g_fbmode[] is left as non-const as its elements are modified at
> runtime by lynxfb_set_fbinfo() and sm750fb_setup().
>
> Signed-off-by: Maxim Codita <maxkoditsa7c@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 89c811e0806c..cc38dac88a73 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -22,7 +22,7 @@ static int g_hwcursor = 1;
> static int g_noaccel __ro_after_init;
> static int g_nomtrr __ro_after_init;
> static const char *g_fbmode[] = {NULL, NULL};
> -static const char *g_def_fbmode = "1024x768-32@60";
> +static const char * const g_def_fbmode = "1024x768-32@60";
The spacing here looks very odd, don't you think?
And how was this tested?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-12 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-11 13:08 [PATCH] staging: sm750fb/sm750.c: mark g_def_fbmode as const pointer Maxim Codita
2026-08-12 0:25 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox