* [PATCH 1/2] ASoC: meson: aiu: Drop redundant probe error messages
@ 2026-08-14 9:42 phucduc.bui
2026-08-14 9:42 ` [PATCH 2/2] ASoC: meson: meson-card-utils: " phucduc.bui
2026-08-14 11:27 ` [PATCH 1/2] ASoC: meson: aiu: " Jerome Brunet
0 siblings, 2 replies; 4+ messages in thread
From: phucduc.bui @ 2026-08-14 9:42 UTC (permalink / raw)
To: Mark Brown, Jerome Brunet
Cc: Liam Girdwood, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jaroslav Kysela, Takashi Iwai, linux-sound, linux-arm-kernel,
linux-amlogic, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The functions called here don't log the error themselves, but the
error is already reported deeper in the call chain, so the dev_err()
calls are redundant and can be removed.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/meson/aiu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c
index 2668646e3597..2ba61e2f703a 100644
--- a/sound/soc/meson/aiu.c
+++ b/sound/soc/meson/aiu.c
@@ -242,12 +242,12 @@ static int aiu_clk_get(struct device *dev)
ret = aiu_clk_bulk_get(dev, aiu_i2s_ids, ARRAY_SIZE(aiu_i2s_ids),
&aiu->i2s);
if (ret)
- return dev_err_probe(dev, ret, "Can't get the i2s clocks\n");
+ return ret;
ret = aiu_clk_bulk_get(dev, aiu_spdif_ids, ARRAY_SIZE(aiu_spdif_ids),
&aiu->spdif);
if (ret)
- return dev_err_probe(dev, ret, "Can't get the spdif clocks\n");
+ return ret;
return ret;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ASoC: meson: meson-card-utils: Drop redundant probe error messages
2026-08-14 9:42 [PATCH 1/2] ASoC: meson: aiu: Drop redundant probe error messages phucduc.bui
@ 2026-08-14 9:42 ` phucduc.bui
2026-08-14 11:28 ` Jerome Brunet
2026-08-14 11:27 ` [PATCH 1/2] ASoC: meson: aiu: " Jerome Brunet
1 sibling, 1 reply; 4+ messages in thread
From: phucduc.bui @ 2026-08-14 9:42 UTC (permalink / raw)
To: Mark Brown, Jerome Brunet
Cc: Liam Girdwood, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jaroslav Kysela, Takashi Iwai, linux-sound, linux-arm-kernel,
linux-amlogic, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The functions called here don't log the error themselves, but the
error is already reported deeper in the call chain, so the dev_err()
calls are redundant and can be removed.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/meson/meson-card-utils.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c
index f2796dc84fa5..e4c3eda24d82 100644
--- a/sound/soc/meson/meson-card-utils.c
+++ b/sound/soc/meson/meson-card-utils.c
@@ -290,17 +290,13 @@ int meson_card_probe(struct platform_device *pdev)
ret = meson_card_parse_of_optional(&priv->card, "audio-routing",
snd_soc_of_parse_audio_routing);
- if (ret) {
- dev_err(dev, "error while parsing routing\n");
+ if (ret)
return ret;
- }
ret = meson_card_parse_of_optional(&priv->card, "audio-widgets",
snd_soc_of_parse_audio_simple_widgets);
- if (ret) {
- dev_err(dev, "error while parsing widgets\n");
+ if (ret)
return ret;
- }
ret = meson_card_add_links(&priv->card);
if (ret)
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ASoC: meson: meson-card-utils: Drop redundant probe error messages
2026-08-14 9:42 ` [PATCH 2/2] ASoC: meson: meson-card-utils: " phucduc.bui
@ 2026-08-14 11:28 ` Jerome Brunet
0 siblings, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2026-08-14 11:28 UTC (permalink / raw)
To: phucduc.bui, Mark Brown
Cc: Liam Girdwood, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jaroslav Kysela, Takashi Iwai, linux-sound, linux-arm-kernel,
linux-amlogic, linux-kernel
On lun. 14 janv. 2008 at 11:42, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The functions called here don't log the error themselves, but the
> error is already reported deeper in the call chain, so the dev_err()
> calls are redundant and can be removed.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: meson: aiu: Drop redundant probe error messages
2026-08-14 9:42 [PATCH 1/2] ASoC: meson: aiu: Drop redundant probe error messages phucduc.bui
2026-08-14 9:42 ` [PATCH 2/2] ASoC: meson: meson-card-utils: " phucduc.bui
@ 2026-08-14 11:27 ` Jerome Brunet
1 sibling, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2026-08-14 11:27 UTC (permalink / raw)
To: phucduc.bui, Mark Brown
Cc: Liam Girdwood, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jaroslav Kysela, Takashi Iwai, linux-sound, linux-arm-kernel,
linux-amlogic, linux-kernel
On lun. 14 janv. 2008 at 11:42, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The functions called here don't log the error themselves, but the
> error is already reported deeper in the call chain, so the dev_err()
> calls are redundant and can be removed.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-14 11:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14 9:42 [PATCH 1/2] ASoC: meson: aiu: Drop redundant probe error messages phucduc.bui
2026-08-14 9:42 ` [PATCH 2/2] ASoC: meson: meson-card-utils: " phucduc.bui
2026-08-14 11:28 ` Jerome Brunet
2026-08-14 11:27 ` [PATCH 1/2] ASoC: meson: aiu: " Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox