* [PATCH] selftests/mm: khugepaged: consolidate error exits via kselftest helpers
@ 2026-08-17 6:19 Hongfu Li
0 siblings, 0 replies; only message in thread
From: Hongfu Li @ 2026-08-17 6:19 UTC (permalink / raw)
To: akpm, david, ljs, ziy, baolin.wang, liam, nico.pache,
ryan.roberts, dev.jain, baohua, lance.yang, usama.arif, vbabka,
rppt, surenb, mhocko, shuah
Cc: linux-mm, linux-kselftest, linux-kernel, hongfu.li, Hongfu Li
From: Hongfu Li <lihongfu@kylinos.cn>
Replace the perror()+exit(EXIT_FAILURE) pattern with
ksft_exit_fail_perror() so failures are reported through the
kselftest framework, consistent with the rest of the file.
Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
---
tools/testing/selftests/mm/khugepaged.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c
index 0d6c71ed2fae..8d1b87f2195c 100644
--- a/tools/testing/selftests/mm/khugepaged.c
+++ b/tools/testing/selftests/mm/khugepaged.c
@@ -358,21 +358,15 @@ static void *file_setup_area_common(int nr_hpages, enum file_setup_ops setup)
ksft_exit_fail_perror("open()");
size = nr_hpages * hpage_pmd_size;
- if (ftruncate(fd, size)) {
- perror("ftruncate()");
- exit(EXIT_FAILURE);
- }
+ if (ftruncate(fd, size))
+ ksft_exit_fail_perror("ftruncate()");
p = mmap(BASE_ADDR, size, PROT_READ | PROT_WRITE,
MAP_SHARED, fd, 0);
- if (p != BASE_ADDR) {
- perror("mmap()");
- exit(EXIT_FAILURE);
- }
+ if (p != BASE_ADDR)
+ ksft_exit_fail_perror("mmap()");
fill_memory(p, 0, size);
- if (msync(p, size, MS_SYNC)) {
- perror("msync()");
- exit(EXIT_FAILURE);
- }
+ if (msync(p, size, MS_SYNC))
+ ksft_exit_fail_perror("msync()");
close(fd);
munmap(p, size);
success("OK");
@@ -447,7 +441,7 @@ static bool file_check_huge(void *addr, size_t len, int nr_hpages,
case VMA_SHMEM:
return check_huge_shmem(addr, len, nr_hpages, hpage_size);
default:
- exit(EXIT_FAILURE);
+ ksft_exit_fail_msg("Unknown VMA type\n");
return false;
}
}
--
2.54.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-17 6:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-17 6:19 [PATCH] selftests/mm: khugepaged: consolidate error exits via kselftest helpers Hongfu Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox