* [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering
@ 2026-08-18 13:13 Jiawen Liu
2026-08-18 15:06 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Jiawen Liu @ 2026-08-18 13:13 UTC (permalink / raw)
To: Jian Shen, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
Remove the redundant explicit NAPI deletion from the registered-device
remove path.
The confirmed lifecycle contract is that unregister_netdev() performs
the NAPI teardown. Probe failure cleanup before registration remains
unchanged.
Signed-off-by: jiawen <1298662399@qq.com>
---
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
--- a/drivers/net/ethernet/hisilicon/hisi_femac.c
+++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
@@ -898,7 +898,6 @@
struct net_device *ndev = platform_get_drvdata(pdev);
struct hisi_femac_priv *priv = netdev_priv(ndev);
- netif_napi_del(&priv->napi);
unregister_netdev(ndev);
phy_disconnect(ndev->phydev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering
2026-08-18 13:13 [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering Jiawen Liu
@ 2026-08-18 15:06 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-08-18 15:06 UTC (permalink / raw)
To: Jiawen Liu
Cc: Jian Shen, Andrew Lunn, David S. Miller, Eric Dumazet,
Paolo Abeni, netdev, linux-kernel
On Tue, 18 Aug 2026 17:13:29 +0400 Jiawen Liu wrote:
> Remove the redundant explicit NAPI deletion from the registered-device
> remove path.
>
> The confirmed lifecycle contract is that unregister_netdev() performs
> the NAPI teardown. Probe failure cleanup before registration remains
> unchanged.
We discourage pointless code churn like this.
If you think there's a bug explain it better.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: reject
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-18 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 13:13 [PATCH] net: hisilicon: hisi-femac: fix NAPI teardown ordering Jiawen Liu
2026-08-18 15:06 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox