From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Aaron Lu <ziqianlu@bytedance.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, williams@redhat.com, jkacur@redhat.com
Subject: Re: [PATCH 0/2] sched: Remove sched_class::balance()
Date: Thu, 20 Aug 2026 09:58:29 +0200 [thread overview]
Message-ID: <20260820075829.GI1246887@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aoav1oIBr8VTwM7W@slm.duckdns.org>
On Wed, Aug 19, 2026 at 09:42:14PM -1000, Tejun Heo wrote:
> Hello, Peter.
>
> On Thu, Aug 20, 2026 at 09:18:52AM +0200, Peter Zijlstra wrote:
> ...
> > Right, but I worry about the cases:
> >
> > - there is no ext task pulled to local because $reasons (could be
> > cpumask), and we retry, then it will see there are ext tasks, but no
> > local and it will try again?
>
> For SCX, rq lock is not dropped for "trying". It is only dropped when there
> is a task to be migrated, so if nothing has changed since the last time,
> there won't be a task to migrate and thus no lock drop.
Hmm, right. I don't think I can get fair to behave that way in a hurry.
Also, even if I could, the figuring out if there is anything to move
might still be somewhat expensive to retry multiple times.
Let me continue pondering if there is anything saner than simply
clearing rf.
> > - custom DSQs, those BPF based things, then we always need to drop the
> > lock in order to execute those BPF methods, no?
>
> No, those all nest inside rq locks. Think about enqueue path. Enqueue needs
> to run all those and we don't drop rq lock while enqueueing (unless we're
> bouncing to another rq's local DSQ at least).
Oh right.. bah, I keep forgetting how all that works :/
prev parent reply other threads:[~2026-08-20 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:13 [PATCH 0/2] sched: Remove sched_class::balance() Peter Zijlstra
2026-06-24 12:13 ` [PATCH 1/2] sched/core: Allow newidle for core-sched Peter Zijlstra
2026-06-24 23:56 ` K Prateek Nayak
2026-06-25 12:41 ` Peter Zijlstra
2026-06-25 12:42 ` Peter Zijlstra
2026-06-24 12:13 ` [PATCH 2/2] sched: Remove sched_class::balance() Peter Zijlstra
2026-07-02 11:49 ` [PATCH 0/2] " Aaron Lu
2026-07-03 3:31 ` K Prateek Nayak
2026-08-19 9:39 ` Peter Zijlstra
2026-08-19 7:58 ` Peter Zijlstra
2026-08-19 14:36 ` Peter Zijlstra
2026-08-19 19:22 ` Tejun Heo
2026-08-20 7:18 ` Peter Zijlstra
2026-08-20 7:42 ` Tejun Heo
2026-08-20 7:58 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820075829.GI1246887@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=williams@redhat.com \
--cc=ziqianlu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox