* [PATCH] ARM: BCM7XXX: Replace __ASSEMBLY__ with __ASSEMBLER__
@ 2026-08-21 8:41 Thomas Huth
2026-08-21 16:13 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2026-08-21 8:41 UTC (permalink / raw)
To: Florian Fainelli, Broadcom internal kernel review list
Cc: linux-arm-kernel, linux-kernel
While the GCC and Clang compilers already define __ASSEMBLER__ auto-
matically when compiling assembly code, __ASSEMBLY__ is a macro that
only gets defined by the Makefiles in the kernel. This can be very
confusing when switching between userspace and kernelspace coding, or
when dealing with uapi headers that rather should use __ASSEMBLER__
instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
this confusion.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Note: This has been split from an earlier bigger patch of mine into
a separate patch to ease reviewing
arch/arm/include/asm/hardware/cache-b15-rac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/hardware/cache-b15-rac.h b/arch/arm/include/asm/hardware/cache-b15-rac.h
index 3d43ec06fd359..b96365bfb2a87 100644
--- a/arch/arm/include/asm/hardware/cache-b15-rac.h
+++ b/arch/arm/include/asm/hardware/cache-b15-rac.h
@@ -1,7 +1,7 @@
#ifndef __ASM_ARM_HARDWARE_CACHE_B15_RAC_H
#define __ASM_ARM_HARDWARE_CACHE_B15_RAC_H
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
void b15_flush_kern_cache_all(void);
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: BCM7XXX: Replace __ASSEMBLY__ with __ASSEMBLER__
2026-08-21 8:41 [PATCH] ARM: BCM7XXX: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
@ 2026-08-21 16:13 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2026-08-21 16:13 UTC (permalink / raw)
To: Thomas Huth, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-arm-kernel, linux-kernel
On 8/21/26 01:41, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Please send it through Russell's patch tracker, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-21 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 8:41 [PATCH] ARM: BCM7XXX: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
2026-08-21 16:13 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox