* [PATCH] docs: iio: Correct ADXL380 filter descriptions
@ 2026-08-22 7:36 Karl Mehltretter
2026-08-22 8:05 ` Joshua Crofts
2026-08-22 17:00 ` Randy Dunlap
0 siblings, 2 replies; 6+ messages in thread
From: Karl Mehltretter @ 2026-08-22 7:36 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Karl Mehltretter, David Lechner, Nuno Sá, Andy Shevchenko,
Jonathan Corbet, Shuah Khan, Randy Dunlap, Antoniu Miclaus,
Ramona Gradinariu, linux-iio, linux-doc, linux-kernel
The high-pass attributes were described as low-pass filters and vice
versa. Correct all four descriptions.
Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
Assisted-by: Codex:gpt-5.6-sol
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Documentation/iio/adxl380.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
index 654d4c0e84a19..a1c249dc2e51c 100644
--- a/Documentation/iio/adxl380.rst
+++ b/Documentation/iio/adxl380.rst
@@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
+---------------------------------------------------+----------------------------------------------------------+
| in_accel_scale | Scale for the accelerometer channels. |
+---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
+| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
+---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
+| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
+---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
+| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
+---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
+| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
+---------------------------------------------------+----------------------------------------------------------+
| in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
+---------------------------------------------------+----------------------------------------------------------+
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
2026-08-22 7:36 [PATCH] docs: iio: Correct ADXL380 filter descriptions Karl Mehltretter
@ 2026-08-22 8:05 ` Joshua Crofts
2026-08-22 17:00 ` Randy Dunlap
1 sibling, 0 replies; 6+ messages in thread
From: Joshua Crofts @ 2026-08-22 8:05 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Jonathan Corbet, Shuah Khan, Randy Dunlap, Antoniu Miclaus,
Ramona Gradinariu, linux-iio, linux-doc, linux-kernel
On Sat, 22 Aug 2026 09:36:53 +0200
Karl Mehltretter <kmehltretter@gmail.com> wrote:
> The high-pass attributes were described as low-pass filters and vice
> versa. Correct all four descriptions.
>
> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Documentation/iio/adxl380.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> index 654d4c0e84a19..a1c249dc2e51c 100644
> --- a/Documentation/iio/adxl380.rst
> +++ b/Documentation/iio/adxl380.rst
> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
> +---------------------------------------------------+----------------------------------------------------------+
> | in_accel_scale | Scale for the accelerometer channels. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> +---------------------------------------------------+----------------------------------------------------------+
> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
> +---------------------------------------------------+----------------------------------------------------------+
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
2026-08-22 7:36 [PATCH] docs: iio: Correct ADXL380 filter descriptions Karl Mehltretter
2026-08-22 8:05 ` Joshua Crofts
@ 2026-08-22 17:00 ` Randy Dunlap
2026-08-22 18:07 ` David Lechner
1 sibling, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2026-08-22 17:00 UTC (permalink / raw)
To: Karl Mehltretter, Jonathan Cameron
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Jonathan Corbet,
Shuah Khan, Antoniu Miclaus, Ramona Gradinariu, linux-iio,
linux-doc, linux-kernel
Hi,
On 8/22/26 12:36 AM, Karl Mehltretter wrote:
> The high-pass attributes were described as low-pass filters and vice
> versa. Correct all four descriptions.
>
> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Documentation/iio/adxl380.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> index 654d4c0e84a19..a1c249dc2e51c 100644
> --- a/Documentation/iio/adxl380.rst
> +++ b/Documentation/iio/adxl380.rst
> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
> +---------------------------------------------------+----------------------------------------------------------+
> | in_accel_scale | Scale for the accelerometer channels. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
> +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> +---------------------------------------------------+----------------------------------------------------------+
> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
> +---------------------------------------------------+----------------------------------------------------------+
These changes LGTM. Thanks.
Although I am a bit confused. When I look at the adxl380 driver,
I don't see any of these device attributes.
The attributes with these names are in other drivers/iio/accel/
drivers: bma180.c, mma8452.c, and sca3000.c
Can someone try to explain this, please?
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
2026-08-22 17:00 ` Randy Dunlap
@ 2026-08-22 18:07 ` David Lechner
2026-08-22 18:19 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: David Lechner @ 2026-08-22 18:07 UTC (permalink / raw)
To: Randy Dunlap, Karl Mehltretter, Jonathan Cameron
Cc: Nuno Sá, Andy Shevchenko, Jonathan Corbet, Shuah Khan,
Antoniu Miclaus, Ramona Gradinariu, linux-iio, linux-doc,
linux-kernel
On 8/22/26 12:00 PM, Randy Dunlap wrote:
> Hi,
>
> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
>> The high-pass attributes were described as low-pass filters and vice
>> versa. Correct all four descriptions.
>>
>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
>> Assisted-by: Codex:gpt-5.6-sol
>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>> ---
>> Documentation/iio/adxl380.rst | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
>> index 654d4c0e84a19..a1c249dc2e51c 100644
>> --- a/Documentation/iio/adxl380.rst
>> +++ b/Documentation/iio/adxl380.rst
>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>> +---------------------------------------------------+----------------------------------------------------------+
>> | in_accel_scale | Scale for the accelerometer channels. |
>> +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
>> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
>> +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
>> +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
>> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
>> +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
>> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
>> +---------------------------------------------------+----------------------------------------------------------+
>> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
>> +---------------------------------------------------+----------------------------------------------------------+
>
> These changes LGTM. Thanks.
>
> Although I am a bit confused. When I look at the adxl380 driver,
> I don't see any of these device attributes.
> The attributes with these names are in other drivers/iio/accel/
> drivers: bma180.c, mma8452.c, and sca3000.c
> Can someone try to explain this, please?
> thanks.
>
The attributes come from:
.info_mask_shared_by_type = \
BIT(IIO_CHAN_INFO_SCALE) | \
BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
.info_mask_shared_by_type_available = \
BIT(IIO_CHAN_INFO_SCALE) | \
BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
in adxl380.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
2026-08-22 18:07 ` David Lechner
@ 2026-08-22 18:19 ` Randy Dunlap
2026-08-23 17:47 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2026-08-22 18:19 UTC (permalink / raw)
To: David Lechner, Karl Mehltretter, Jonathan Cameron
Cc: Nuno Sá, Andy Shevchenko, Jonathan Corbet, Shuah Khan,
Antoniu Miclaus, Ramona Gradinariu, linux-iio, linux-doc,
linux-kernel
On 8/22/26 11:07 AM, David Lechner wrote:
> On 8/22/26 12:00 PM, Randy Dunlap wrote:
>> Hi,
>>
>> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
>>> The high-pass attributes were described as low-pass filters and vice
>>> versa. Correct all four descriptions.
>>>
>>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
>>> Assisted-by: Codex:gpt-5.6-sol
>>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>>> ---
>>> Documentation/iio/adxl380.rst | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
>>> index 654d4c0e84a19..a1c249dc2e51c 100644
>>> --- a/Documentation/iio/adxl380.rst
>>> +++ b/Documentation/iio/adxl380.rst
>>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> | in_accel_scale | Scale for the accelerometer channels. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
>>> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
>>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
>>> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
>>> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
>>> +---------------------------------------------------+----------------------------------------------------------+
>>
>> These changes LGTM. Thanks.
>>
>> Although I am a bit confused. When I look at the adxl380 driver,
>> I don't see any of these device attributes.
>> The attributes with these names are in other drivers/iio/accel/
>> drivers: bma180.c, mma8452.c, and sca3000.c
>> Can someone try to explain this, please?
>> thanks.
>>
>
> The attributes come from:
>
> .info_mask_shared_by_type = \
> BIT(IIO_CHAN_INFO_SCALE) | \
> BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
> .info_mask_shared_by_type_available = \
> BIT(IIO_CHAN_INFO_SCALE) | \
> BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
>
> in adxl380.c
Thanks, David.
for the patch:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
2026-08-22 18:19 ` Randy Dunlap
@ 2026-08-23 17:47 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2026-08-23 17:47 UTC (permalink / raw)
To: Randy Dunlap
Cc: David Lechner, Karl Mehltretter, Nuno Sá, Andy Shevchenko,
Jonathan Corbet, Shuah Khan, Antoniu Miclaus, Ramona Gradinariu,
linux-iio, linux-doc, linux-kernel
On Sat, 22 Aug 2026 11:19:09 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 8/22/26 11:07 AM, David Lechner wrote:
> > On 8/22/26 12:00 PM, Randy Dunlap wrote:
> >> Hi,
> >>
> >> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
> >>> The high-pass attributes were described as low-pass filters and vice
> >>> versa. Correct all four descriptions.
> >>>
> >>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> >>> Assisted-by: Codex:gpt-5.6-sol
> >>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> >>> ---
> >>> Documentation/iio/adxl380.rst | 8 ++++----
> >>> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> >>> index 654d4c0e84a19..a1c249dc2e51c 100644
> >>> --- a/Documentation/iio/adxl380.rst
> >>> +++ b/Documentation/iio/adxl380.rst
> >>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> | in_accel_scale | Scale for the accelerometer channels. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
> >>> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> >>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
> >>> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> >>> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>
> >> These changes LGTM. Thanks.
> >>
> >> Although I am a bit confused. When I look at the adxl380 driver,
> >> I don't see any of these device attributes.
> >> The attributes with these names are in other drivers/iio/accel/
> >> drivers: bma180.c, mma8452.c, and sca3000.c
> >> Can someone try to explain this, please?
> >> thanks.
> >>
> >
> > The attributes come from:
> >
> > .info_mask_shared_by_type = \
> > BIT(IIO_CHAN_INFO_SCALE) | \
> > BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> > BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
> > .info_mask_shared_by_type_available = \
> > BIT(IIO_CHAN_INFO_SCALE) | \
> > BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> > BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
> >
> > in adxl380.c
>
> Thanks, David.
>
> for the patch:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
Applied to the testing branch of iio.git.
That will get rebased on rc1 once available.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-08-23 17:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-22 7:36 [PATCH] docs: iio: Correct ADXL380 filter descriptions Karl Mehltretter
2026-08-22 8:05 ` Joshua Crofts
2026-08-22 17:00 ` Randy Dunlap
2026-08-22 18:07 ` David Lechner
2026-08-22 18:19 ` Randy Dunlap
2026-08-23 17:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox