Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Alex Deucher]

Applied.  Thanks.

Alex

On Sat, Aug 15, 2026 at 2:22 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The is_idle method in amd_ip_funcs is never called, however
> there are some functions assigned to it.
>
> Remove the bindings to it, and if the functions aren't called
> anywhere else remove the function as well.
>
> Remove the kunit test hook for it.
>
> In many cases the wait_for_idle code either calls the
> function which was wired to is_idle or duplicates the
> code (or curiously kind of duplicates it with changes).
>
> Based on drm-next-7.3 0d710af8e4abdd1fa500bddbab7c0ee47fc98143.
> Booted on my Ryzen with RX560.
> (That is spewing some warnings of the form:
> [    9.680879] [PLANE:44:plane-0] pixel format with alpha exposed but blend mode not setup
> [    9.680881] WARNING: drivers/gpu/drm/drm_mode_config.c:872 at drm_mode_config_validate+0x3c2/0x4f0, CPU#4: (udev-worker)/538
>
> but I don't *think* I've gone anywhere near anything to do with pixel
> formats etc)
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
>
> Dr. David Alan Gilbert (4):
>   drm/amdgpu: Remove is_idle test case
>   drm/amdgpu: Remove is_idle (trivial cases)
>   drm/amdgpu: Remove is_idle (non trivial functions)
>   drm/amdgpu: Remove is_idle
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c       |  6 -----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c       |  6 -----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c      |  6 -----
>  drivers/gpu/drm/amd/amdgpu/cik.c              |  7 ------
>  drivers/gpu/drm/amd/amdgpu/cik_ih.c           | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/cik_sdma.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/cz_ih.c            | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |  6 -----
>  drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |  6 -----
>  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |  6 -----
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c        | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c        | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c        | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c        |  1 -
>  drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         | 11 ---------
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c       |  1 -
>  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         | 13 -----------
>  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  7 ------
>  drivers/gpu/drm/amd/amdgpu/iceland_ih.c       | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/ih_v6_0.c          |  7 ------
>  drivers/gpu/drm/amd/amdgpu/ih_v6_1.c          |  7 ------
>  drivers/gpu/drm/amd/amdgpu/ih_v7_0.c          |  7 ------
>  drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c        |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c        |  2 --
>  drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c        |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c        |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_2.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/jpeg_v5_3_0.c      |  1 -
>  drivers/gpu/drm/amd/amdgpu/navi10_ih.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/nv.c               |  6 -----
>  drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c        | 13 -----------
>  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c        | 13 -----------
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c      | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c        | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/si.c               |  6 -----
>  drivers/gpu/drm/amd/amdgpu/si_dma.c           |  1 -
>  drivers/gpu/drm/amd/amdgpu/si_ih.c            |  1 -
>  drivers/gpu/drm/amd/amdgpu/soc15.c            |  6 -----
>  drivers/gpu/drm/amd/amdgpu/soc21.c            |  6 -----
>  drivers/gpu/drm/amd/amdgpu/soc24.c            |  6 -----
>  drivers/gpu/drm/amd/amdgpu/soc_v1_0.c         |  6 -----
>  drivers/gpu/drm/amd/amdgpu/tonga_ih.c         | 12 ----------
>  drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c         |  8 -------
>  drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c         |  8 -------
>  drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c         |  8 -------
>  drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vce_v1_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vce_v2_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vce_v3_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c         |  1 -
>  drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c         |  2 --
>  drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c         | 16 -------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c         | 23 -------------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c       | 21 -----------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c       | 23 -------------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c       | 23 -------------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c       | 19 ---------------
>  drivers/gpu/drm/amd/amdgpu/vcn_v5_0_2.c       | 19 ---------------
>  drivers/gpu/drm/amd/amdgpu/vega10_ih.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/vega20_ih.c        |  7 ------
>  drivers/gpu/drm/amd/amdgpu/vi.c               |  6 -----
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  8 -------
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  1 -
>  .../display/amdgpu_dm/tests/amdgpu_dm_test.c  | 10 --------
>  drivers/gpu/drm/amd/include/amd_shared.h      |  2 --
>  drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c    |  6 -----
>  drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c    |  7 ------
>  .../gpu/drm/amd/pm/powerplay/amd_powerplay.c  |  6 -----
>  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     |  1 -
>  87 files changed, 639 deletions(-)
>
> --
> 2.55.0
>

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Greg KH]

On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> Applied.  Thanks.

Any hints on where this was applied and if it will get to Linus "soon"?

thanks,

greg k-h

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Alex Deucher]

On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > Applied.  Thanks.
>
> Any hints on where this was applied and if it will get to Linus "soon"?

It will show up in drm-next after the merge window closes. 7.4 material.

Alex

>
> thanks,
>
> greg k-h

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Greg KH]

On Wed, Aug 26, 2026 at 08:45:29AM -0400, Alex Deucher wrote:
> On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > > Applied.  Thanks.
> >
> > Any hints on where this was applied and if it will get to Linus "soon"?
> 
> It will show up in drm-next after the merge window closes. 7.4 material.

Sorry, but this is hitting me now, pre 7.3-rc1.  Booting and getting a
zillion kernel warnings isn't ok, that's a regression.  Please get this
merged sooner than that.

greg k-h

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Dr. David Alan Gilbert]

* Greg KH (gregkh@linuxfoundation.org) wrote:
> On Wed, Aug 26, 2026 at 08:45:29AM -0400, Alex Deucher wrote:
> > On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > > > Applied.  Thanks.
> > >
> > > Any hints on where this was applied and if it will get to Linus "soon"?
> > 
> > It will show up in drm-next after the merge window closes. 7.4 material.
> 
> Sorry, but this is hitting me now, pre 7.3-rc1.  Booting and getting a
> zillion kernel warnings isn't ok, that's a regression.  Please get this
> merged sooner than that.

Hey? This patch doesn't fix anything - it's purely dead code.
My comment about the log errors I saw were about the head of drm-next
I tested on, not about this patch.

Dave

> greg k-h
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Alex Deucher]

On Wed, Aug 26, 2026 at 9:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Aug 26, 2026 at 08:45:29AM -0400, Alex Deucher wrote:
> > On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > > > Applied.  Thanks.
> > >
> > > Any hints on where this was applied and if it will get to Linus "soon"?
> >
> > It will show up in drm-next after the merge window closes. 7.4 material.
>
> Sorry, but this is hitting me now, pre 7.3-rc1.  Booting and getting a
> zillion kernel warnings isn't ok, that's a regression.  Please get this
> merged sooner than that.

I assume this is the series that fixes the warning you are seeing:
https://lore.kernel.org/all/20260813143605.106104-1-mwen@igalia.com/
We are working on picking it up now.

Alex

>
> greg k-h

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Greg KH]

On Wed, Aug 26, 2026 at 01:10:50PM +0000, Dr. David Alan Gilbert wrote:
> * Greg KH (gregkh@linuxfoundation.org) wrote:
> > On Wed, Aug 26, 2026 at 08:45:29AM -0400, Alex Deucher wrote:
> > > On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > > > > Applied.  Thanks.
> > > >
> > > > Any hints on where this was applied and if it will get to Linus "soon"?
> > > 
> > > It will show up in drm-next after the merge window closes. 7.4 material.
> > 
> > Sorry, but this is hitting me now, pre 7.3-rc1.  Booting and getting a
> > zillion kernel warnings isn't ok, that's a regression.  Please get this
> > merged sooner than that.
> 
> Hey? This patch doesn't fix anything - it's purely dead code.
> My comment about the log errors I saw were about the head of drm-next
> I tested on, not about this patch.

Ah, my fault, my search found that and assumed this thread was the fix
for that.  Nevermind :)

greg k-h

Re: [PATCH 0/4] drm/amdgpu: Remove is_idle method

[Greg KH]

On Wed, Aug 26, 2026 at 09:15:00AM -0400, Alex Deucher wrote:
> On Wed, Aug 26, 2026 at 9:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Aug 26, 2026 at 08:45:29AM -0400, Alex Deucher wrote:
> > > On Wed, Aug 26, 2026 at 6:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Mon, Aug 17, 2026 at 11:27:41AM -0400, Alex Deucher wrote:
> > > > > Applied.  Thanks.
> > > >
> > > > Any hints on where this was applied and if it will get to Linus "soon"?
> > >
> > > It will show up in drm-next after the merge window closes. 7.4 material.
> >
> > Sorry, but this is hitting me now, pre 7.3-rc1.  Booting and getting a
> > zillion kernel warnings isn't ok, that's a regression.  Please get this
> > merged sooner than that.
> 
> I assume this is the series that fixes the warning you are seeing:
> https://lore.kernel.org/all/20260813143605.106104-1-mwen@igalia.com/
> We are working on picking it up now.

Ok, great, sorry for the confusion, my bad.

greg k-h