The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
@ 2026-11-04 13:20 Arnd Bergmann
  2026-11-04 14:41 ` Liang Haowen
  2026-11-17 11:48 ` (subset) " Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-11-04 13:20 UTC (permalink / raw)
  To: Nam Tran, Lee Jones, Pavel Machek, Liang Haowen
  Cc: Arnd Bergmann, Griffin Kroah-Hartman, linux-leds, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without the device handler support, the driver fails to link:

ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!

Add a Kconfig dependency to only show the symbol if it can
be enabled.

Fixes: 6173959c7d4d ("leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/rgb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 983f50b7ed2d..3f6786616a7d 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -4,7 +4,7 @@ if LEDS_CLASS_MULTICOLOR
 
 config LEDS_ASUS_AURA_SCSI
 	tristate "ASUS Aura RGB LEDs on ROG external NVMe enclosures"
-	depends on SCSI
+	depends on SCSI && SCSI_DH
 	help
 	  Say Y here if you want to control the RGB LEDs of ASUS ROG
 	  external NVMe enclosures such as the ROG STRIX Arion. The LEDs
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
  2026-11-04 13:20 [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency Arnd Bergmann
@ 2026-11-04 14:41 ` Liang Haowen
  2026-11-17 11:48 ` (subset) " Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Liang Haowen @ 2026-11-04 14:41 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Nam Tran, Lee Jones, Pavel Machek, Arnd Bergmann,
	Griffin Kroah-Hartman, linux-leds, linux-kernel

On Wed, 4 Nov 2026, Arnd Bergmann wrote:

> Without the device handler support, the driver fails to link:
>
> ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!
>
> Add a Kconfig dependency to only show the symbol if it can
> be enabled.

Correct, the handler registration lives under SCSI_DH, so the driver
cannot link without it. My Kconfig entry missed the dependency.

Acked-by: Liang Haowen <nbg2974@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: (subset) [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
  2026-11-04 13:20 [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency Arnd Bergmann
  2026-11-04 14:41 ` Liang Haowen
@ 2026-11-17 11:48 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2026-11-17 11:48 UTC (permalink / raw)
  To: Nam Tran, Lee Jones, Pavel Machek, Liang Haowen, Arnd Bergmann
  Cc: Arnd Bergmann, Griffin Kroah-Hartman, linux-leds, linux-kernel

On Wed, 04 Nov 2026 14:20:56 +0100, Arnd Bergmann wrote:
> Without the device handler support, the driver fails to link:
> 
> ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!
> 
> Add a Kconfig dependency to only show the symbol if it can
> be enabled.
> 
> [...]

Applied, thanks!

[1/1] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
      commit: 1b5298e11965bbac7e903314db1789dc736a1668

--
Lee Jones [李琼斯]


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17 11:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-04 13:20 [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency Arnd Bergmann
2026-11-04 14:41 ` Liang Haowen
2026-11-17 11:48 ` (subset) " Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox