The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Wayne Lin <Wayne.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: "Weijie Yuan" <kernel@wyuan.org>, "Weijie Yuan" <wy@wyuan.org>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Harry VanZyllDeJong" <hvanzyll@amd.com>,
	"Tom Chung" <chiahsuan.chung@amd.com>,
	"Sreeja Golui" <sreeja.golui@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations
Date: Sun, 15 Nov 2026 15:06:12 +0800	[thread overview]
Message-ID: <20261115070612.1464433-1-Wayne.Lin@amd.com> (raw)
In-Reply-To: <dfd520477e9987eca7719e537b2865f4abe43043.1793362629.git.wy@wyuan.org>

Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>

On Fri, 30 Oct 2026 20:27:13 +0800, Weijie Yuan wrote:
> Hi, when running 'make htmldocs', Sphinx complains:
>
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:3883 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Panel Polarity Control
>
> But since I am not familiar with your workflow, if this is duplicate,
> please feel free to ignore.
>
> Also for this file:
>
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'
>
> Thanks.
>
> -- >8 --
> From: Weijie Yuan <wy@wyuan.org>
>
> The Panel Polarity Control heading introduces several declarations
> rather than documenting a single function. Its kernel-doc opener
> causes a warning because the heading is not a valid kernel-doc block.
>
> Use an ordinary block comment for this section heading.
>
> Fixes: 7dcd85c2241f ("drm/amd/display: eDP panel polarity control and test support")
> Signed-off-by: Weijie Yuan <wy@wyuan.org>
> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index d3c484f45333..03286f6aa651 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -3880,7 +3880,7 @@ unsigned int dc_override_memory_bandwidth_request(
>  		struct dc *dc,
>  		unsigned int bw_mbps);
>  
> -/**
> +/*
>   * Panel Polarity Control
>   */
>  void dc_link_set_panel_polarity_enable(struct dc_link *link, bool enable);
> -- 
> 2.56.0.438.g30c3f27cb8

      reply	other threads:[~2026-11-15  7:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 12:27 [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations Weijie Yuan
2026-11-15  7:06 ` Wayne Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115070612.1464433-1-Wayne.Lin@amd.com \
    --to=wayne.lin@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chiahsuan.chung@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=hvanzyll@amd.com \
    --cc=kernel@wyuan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sreeja.golui@amd.com \
    --cc=sunpeng.li@amd.com \
    --cc=wy@wyuan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox