The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations
@ 2026-10-30 12:27 Weijie Yuan
  2026-11-15  7:06 ` Wayne Lin
  0 siblings, 1 reply; 2+ messages in thread
From: Weijie Yuan @ 2026-10-30 12:27 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, David Airlie, Simona Vetter,
	Harry VanZyllDeJong, Tom Chung, Sreeja Golui
  Cc: amd-gfx, dri-devel, linux-kernel

Hi, when running 'make htmldocs', Sphinx complains:

WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:3883 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Panel Polarity Control

But since I am not familiar with your workflow, if this is duplicate,
please feel free to ignore.

Also for this file:

WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'
WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'

Thanks.

-- >8 --
From: Weijie Yuan <wy@wyuan.org>

The Panel Polarity Control heading introduces several declarations
rather than documenting a single function. Its kernel-doc opener
causes a warning because the heading is not a valid kernel-doc block.

Use an ordinary block comment for this section heading.

Fixes: 7dcd85c2241f ("drm/amd/display: eDP panel polarity control and test support")
Signed-off-by: Weijie Yuan <wy@wyuan.org>
---
 drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index d3c484f45333..03286f6aa651 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -3880,7 +3880,7 @@ unsigned int dc_override_memory_bandwidth_request(
 		struct dc *dc,
 		unsigned int bw_mbps);
 
-/**
+/*
  * Panel Polarity Control
  */
 void dc_link_set_panel_polarity_enable(struct dc_link *link, bool enable);
-- 
2.56.0.438.g30c3f27cb8


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations
  2026-10-30 12:27 [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations Weijie Yuan
@ 2026-11-15  7:06 ` Wayne Lin
  0 siblings, 0 replies; 2+ messages in thread
From: Wayne Lin @ 2026-11-15  7:06 UTC (permalink / raw)
  To: amd-gfx
  Cc: Weijie Yuan, Weijie Yuan, Harry Wentland, Leo Li,
	Rodrigo Siqueira, Alex Deucher, Christian König,
	David Airlie, Simona Vetter, Harry VanZyllDeJong, Tom Chung,
	Sreeja Golui, dri-devel, linux-kernel

Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>

On Fri, 30 Oct 2026 20:27:13 +0800, Weijie Yuan wrote:
> Hi, when running 'make htmldocs', Sphinx complains:
>
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:3883 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Panel Polarity Control
>
> But since I am not familiar with your workflow, if this is duplicate,
> please feel free to ignore.
>
> Also for this file:
>
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:329 struct member 'max_gamut_remap_coeff' not described in 'mpc_color_caps'
> WARNING: ./drivers/gpu/drm/amd/display/dc/dc.h:2225 struct member 'u' not described in 'dc_probe_status'
>
> Thanks.
>
> -- >8 --
> From: Weijie Yuan <wy@wyuan.org>
>
> The Panel Polarity Control heading introduces several declarations
> rather than documenting a single function. Its kernel-doc opener
> causes a warning because the heading is not a valid kernel-doc block.
>
> Use an ordinary block comment for this section heading.
>
> Fixes: 7dcd85c2241f ("drm/amd/display: eDP panel polarity control and test support")
> Signed-off-by: Weijie Yuan <wy@wyuan.org>
> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index d3c484f45333..03286f6aa651 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -3880,7 +3880,7 @@ unsigned int dc_override_memory_bandwidth_request(
>  		struct dc *dc,
>  		unsigned int bw_mbps);
>  
> -/**
> +/*
>   * Panel Polarity Control
>   */
>  void dc_link_set_panel_polarity_enable(struct dc_link *link, bool enable);
> -- 
> 2.56.0.438.g30c3f27cb8

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-15  7:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 12:27 [PATCH] drm/amd/display: Use a plain comment for panel polarity declarations Weijie Yuan
2026-11-15  7:06 ` Wayne Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox