The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups
@ 2026-11-18  0:06 Maximo Manriquez Lizarraga via B4 Relay
  2026-11-18 10:10 ` Joshua Crofts
  0 siblings, 1 reply; 2+ messages in thread
From: Maximo Manriquez Lizarraga via B4 Relay @ 2026-11-18  0:06 UTC (permalink / raw)
  To: jic23, Michael.Hennerich, dlechner, gregkh, andy, nuno.sa
  Cc: linux-iio, krzk, linux, linux-kernel, linux-staging,
	Maximo Manriquez Lizarraga

From: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>

GPIO lookups can return -EPROBE_DEFER.  Convert the rdwr and convert
GPIO lookup failures in ad7816_probe() to dev_err_probe(), which
suppresses the error message on deferral and records the deferral
reason.  The busy-GPIO path is left untouched: its optionality is the
subject of a separate proposed change.

No functional change other than defer handling.

Signed-off-by: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>
---
Changes in v2:
- Resend under my real name (From/Signed-off-by: Maximo Manriquez Lizarraga).
- Apologies for the improper sign-off on v1; no code change.
- Link to v1: https://patch.msgid.link/20261107-batch1-s3-warn-v1-1-4fc38341ca38@tubot.lat
---
 drivers/staging/iio/adc/ad7816.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 2a15d7598abb..11292216dfb5 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -381,20 +381,14 @@ static int ad7816_probe(struct spi_device *spi_dev)
 
 	chip->id = spi_get_device_id(spi_dev)->driver_data;
 	chip->rdwr_pin = devm_gpiod_get(&spi_dev->dev, "rdwr", GPIOD_OUT_HIGH);
-	if (IS_ERR(chip->rdwr_pin)) {
-		ret = PTR_ERR(chip->rdwr_pin);
-		dev_err(&spi_dev->dev, "Failed to request rdwr GPIO: %d\n",
-			ret);
-		return ret;
-	}
+	if (IS_ERR(chip->rdwr_pin))
+		return dev_err_probe(&spi_dev->dev, PTR_ERR(chip->rdwr_pin),
+				     "Failed to request rdwr GPIO\n");
 	chip->convert_pin = devm_gpiod_get(&spi_dev->dev, "convert",
 					   GPIOD_OUT_HIGH);
-	if (IS_ERR(chip->convert_pin)) {
-		ret = PTR_ERR(chip->convert_pin);
-		dev_err(&spi_dev->dev, "Failed to request convert GPIO: %d\n",
-			ret);
-		return ret;
-	}
+	if (IS_ERR(chip->convert_pin))
+		return dev_err_probe(&spi_dev->dev, PTR_ERR(chip->convert_pin),
+				     "Failed to request convert GPIO\n");
 	if (chip->id == ID_AD7816 || chip->id == ID_AD7817) {
 		chip->busy_pin = devm_gpiod_get(&spi_dev->dev, "busy",
 						GPIOD_IN);

---
base-commit: fa4ad798f6f681031775266044ba1b0cf3c670bd
change-id: 20261107-batch1-s3-warn-289c98c7b118

Best regards,
--  
Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups
  2026-11-18  0:06 [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups Maximo Manriquez Lizarraga via B4 Relay
@ 2026-11-18 10:10 ` Joshua Crofts
  0 siblings, 0 replies; 2+ messages in thread
From: Joshua Crofts @ 2026-11-18 10:10 UTC (permalink / raw)
  To: Maximo Manriquez Lizarraga via B4 Relay
  Cc: DelaySystem, jic23, Michael.Hennerich, dlechner, gregkh, andy,
	nuno.sa, linux-iio, krzk, linux, linux-kernel, linux-staging

On Tue, 17 Nov 2026 16:06:03 -0800
Maximo Manriquez Lizarraga via B4 Relay <devnull+DelaySystem.tubot.lat@kernel.org> wrote:

> From: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>
> 
> GPIO lookups can return -EPROBE_DEFER.  Convert the rdwr and convert
> GPIO lookup failures in ad7816_probe() to dev_err_probe(), which
> suppresses the error message on deferral and records the deferral
> reason.  The busy-GPIO path is left untouched: its optionality is the
> subject of a separate proposed change.
> 
> No functional change other than defer handling.
> 
> Signed-off-by: Maximo Manriquez Lizarraga <DelaySystem@tubot.lat>
> ---
> Changes in v2:
> - Resend under my real name (From/Signed-off-by: Maximo Manriquez Lizarraga).
> - Apologies for the improper sign-off on v1; no code change.
> - Link to v1: https://patch.msgid.link/20261107-batch1-s3-warn-v1-1-4fc38341ca38@tubot.lat
> ---

You've missed the following segment starting line 398:

	if (chip->id == ID_AD7816 || chip->id == ID_AD7817) {
		chip->busy_pin = devm_gpiod_get(&spi_dev->dev, "busy",
						GPIOD_IN);
		if (IS_ERR(chip->busy_pin)) {
			ret = PTR_ERR(chip->busy_pin);
			dev_err(&spi_dev->dev, "Failed to request busy GPIO: %d\n",
				ret);
			return ret;

Otherwise the existing changes are fine.

-- 
Kind regards,
Joshua Crofts

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-18 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  0:06 [PATCH v2] staging: iio: adc: ad7816: use dev_err_probe() for GPIO lookups Maximo Manriquez Lizarraga via B4 Relay
2026-11-18 10:10 ` Joshua Crofts

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox