* [PATCH v5] hwmon: sy7636a: read the temperature only while the rails are on
@ 2026-11-19 21:54 Pablo Mazzini
0 siblings, 0 replies; only message in thread
From: Pablo Mazzini @ 2026-11-19 21:54 UTC (permalink / raw)
To: Mark Brown
Cc: Pablo Mazzini, Guenter Roeck, Alistair Francis, Andreas Kemnade,
linux-hwmon, linux-kernel
The driver enables VCOM at probe, which keeps the panel's high voltage
rails on for good. Read the temperature only while the rails are on, when
the chip samples it, and return -ENODATA otherwise. Read power good with
it in one transfer, so the value can not be from before the first sample
or after the rails went off.
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>
---
v5: rebased on regulator for-7.5, which now has fc8519fab34e ("hwmon:
(sy7636a) fix negative temperatures"). No code change. Added Guenter's
ack. v4 2/2 (imx defconfig) is unchanged and stays for the i.MX tree.
drivers/hwmon/sy7636a-hwmon.c | 35 ++++++++++++++++++++++++-----------
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c
index a6b47452e29e..a8bfbf1716a1 100644
--- a/drivers/hwmon/sy7636a-hwmon.c
+++ b/drivers/hwmon/sy7636a-hwmon.c
@@ -9,26 +9,43 @@
*/
#include <linux/auxiliary_bus.h>
+#include <linux/bits.h>
#include <linux/err.h>
#include <linux/hwmon.h>
#include <linux/module.h>
#include <linux/regmap.h>
-#include <linux/regulator/machine.h>
-#define SY7636A_REG_TERMISTOR_READOUT 0x08
+#define SY7636A_REG_FAULT_FLAG 0x07
+#define SY7636A_FAULT_FLAG_PG BIT(0)
static int sy7636a_read(struct device *dev, enum hwmon_sensor_types type,
u32 attr, int channel, long *temp)
{
struct regmap *regmap = dev_get_drvdata(dev);
- int ret, reg_val;
-
- ret = regmap_read(regmap,
- SY7636A_REG_TERMISTOR_READOUT, ®_val);
+ u8 buf[2];
+ int ret;
+
+ /*
+ * The thermistor is sampled while ON_OFF is set, but the first sample
+ * is only ready after the ADC sampling and conversion time (ADC_SPL +
+ * ADC_DEL in the datasheet); until then it holds its reset value, 0.
+ * PG is only set once all rails are up, after the first sample, so
+ * read it in the same transfer and report the temperature only while
+ * it is set.
+ *
+ * With ON_OFF set but PG low (rails still ramping up, or a fault), no
+ * temperature is reported even if one may be available. That is
+ * accepted: the display driver reads the temperature only while it
+ * holds the rails on, after power good.
+ */
+ ret = regmap_bulk_read(regmap, SY7636A_REG_FAULT_FLAG, buf, sizeof(buf));
if (ret)
return ret;
- *temp = (s8)reg_val * 1000;
+ if (!(buf[0] & SY7636A_FAULT_FLAG_PG))
+ return -ENODATA;
+
+ *temp = (s8)buf[1] * 1000;
return 0;
}
@@ -72,10 +89,6 @@ static int sy7636a_sensor_probe(struct auxiliary_device *adev,
if (!regmap)
return -ENODEV;
- err = devm_regulator_get_enable(&adev->dev, "vcom");
- if (err)
- return err;
-
hwmon_dev = devm_hwmon_device_register_with_info(&adev->dev,
"sy7636a_temperature", regmap,
&sy7636a_chip_info, NULL);
base-commit: d979b780718905dcbb55c10a5ecb26cc1ff1762f
--
2.52.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-19 21:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 21:54 [PATCH v5] hwmon: sy7636a: read the temperature only while the rails are on Pablo Mazzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox