* [PATCH v3] usb: gadget: f_tcm: reject a short write data-out transfer
@ 2026-10-13 1:54 Yehyeong Lee
2026-11-20 11:34 ` Yehyeong Lee
0 siblings, 1 reply; 3+ messages in thread
From: Yehyeong Lee @ 2026-10-13 1:54 UTC (permalink / raw)
To: gregkh, linux-usb
Cc: Thinh Nguyen, Sebastian Andrzej Siewior, target-devel,
linux-kernel, stable
usbg_data_write_cmpl() commits the WRITE buffer to the backend as soon as
the OUT request completes successfully, looking only at req->status and
never at req->actual. A host that declares an 8192-byte WRITE but ends the
data-out after 4096 bytes still reaches target_execute_cmd() with the full
length.
The buffer is not zeroed (transport_generic_new_cmd() leaves zero_flag
clear for a data CDB), so the bytes that never arrived keep the previous
page contents, which the backend writes to the device for the host to read
back. The target core refuses a WRITE whose declared length is wrong, but
it does not see a data phase that simply falls short.
Fail the command when the data-out is short. The OUT data phase is over
once this completion runs, so clear cmd->data_len unconditionally here:
otherwise a later BOT CHECK CONDITION - from the short write, or from any
WRITE that finishes its data phase and then fails in the backend - takes it
as outstanding data and queues an OUT request to drain a host that has
already stopped, wedging the bulk pipe. Rate-limit the failure message,
which a host can now trigger at will.
There is no oops; poisoning the buffer and ending an 8192-byte write at
4096 bytes leaves 4096 stale bytes committed before the change, and after
it the command is aborted with nothing committed.
Fixes: c52661d60f63 ("usb-gadget: Initial merge of target module for UASP + BOT")
Cc: stable@vger.kernel.org
Signed-off-by: Yehyeong Lee <yhlee@isslab.korea.ac.kr>
---
v3: clear cmd->data_len unconditionally once the data phase is over, not
only on the short-write path, so a WRITE that finishes its data phase
and then fails in the backend does not wedge the bulk pipe either.
v2: fail short data-out and clear cmd->data_len; rate-limit the message.
drivers/usb/gadget/function/f_tcm.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index 9e6d4f39900a2..cf6a394c4196b 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -1090,8 +1090,15 @@ static void usbg_data_write_cmpl(struct usb_ep *ep, struct usb_request *req)
return;
}
- if (req->status) {
- pr_err("%s() state %d transfer failed\n", __func__, cmd->state);
+ /* the OUT data phase is over; nothing left for the status phase to drain */
+ cmd->data_len = 0;
+
+ /* a short data-out left the buffer unwritten; don't commit stale data */
+ if (req->status || req->actual != req->length) {
+ struct usb_gadget *gadget = fuas_to_gadget(cmd->fu);
+
+ dev_err_ratelimited(&gadget->dev, "%s() state %d transfer failed\n",
+ __func__, cmd->state);
goto cleanup;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] usb: gadget: f_tcm: reject a short write data-out transfer
2026-10-13 1:54 [PATCH v3] usb: gadget: f_tcm: reject a short write data-out transfer Yehyeong Lee
@ 2026-11-20 11:34 ` Yehyeong Lee
2026-11-20 13:44 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Yehyeong Lee @ 2026-11-20 11:34 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, Thinh.Nguyen, bigeasy, target-devel, linux-kernel
This is superseded by v8:
https://lore.kernel.org/all/20261118124005.2428068-1-yhlee@isslab.korea.ac.kr/
Best regards,
Yehyeong Lee
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] usb: gadget: f_tcm: reject a short write data-out transfer
2026-11-20 11:34 ` Yehyeong Lee
@ 2026-11-20 13:44 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-11-20 13:44 UTC (permalink / raw)
To: Yehyeong Lee; +Cc: linux-usb, Thinh.Nguyen, bigeasy, target-devel, linux-kernel
On Fri, Nov 20, 2026 at 08:34:11PM +0900, Yehyeong Lee wrote:
> This is superseded by v8:
> https://lore.kernel.org/all/20261118124005.2428068-1-yhlee@isslab.korea.ac.kr/
Please fix your email quoting. This does not mean anything to me.
Remember, some of us get 1000+ emails a day, there's a reason your email
client wants to properly quote context.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-13 1:54 [PATCH v3] usb: gadget: f_tcm: reject a short write data-out transfer Yehyeong Lee
2026-11-20 11:34 ` Yehyeong Lee
2026-11-20 13:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox