* [PATCH] staging: bcm2835-audio: remove unused bcm2835_audio_retrieve_buffers() declaration
@ 2026-11-12 4:29 Yusuke Hayashi via B4 Relay
2026-11-20 7:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Yusuke Hayashi via B4 Relay @ 2026-11-12 4:29 UTC (permalink / raw)
To: Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list
Cc: linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Yusuke Hayashi
From: Yusuke Hayashi <yusuke8h@gmail.com>
bcm2835_audio_retrieve_buffers() is declared in bcm2835.h, but its
definition and sole caller were removed in commit d7ca3a71545b
("staging: bcm2835-audio: Operate non-atomic PCM ops").
Remove the orphaned function declaration.
Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
---
Found while scanning staging headers for declarations without definitions
with an AI coding assistant, verified against commit d7ca3a71545b, and
compile-tested with Clang 18 (LLVM=1 W=1 C=2) and GCC 13 (W=1 C=2) with
CONFIG_SND_BCM2835=m.
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
index 5a1348747ff4..54ad749129fc 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
@@ -107,6 +107,5 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream,
void *src);
void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream,
unsigned int size);
-unsigned int bcm2835_audio_retrieve_buffers(struct bcm2835_alsa_stream *alsa_stream);
#endif /* __SOUND_ARM_BCM2835_H */
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261112-bcm2835-audio-unused-decl-426a1123b3e8
Best regards,
--
Yusuke Hayashi <yusuke8h@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: bcm2835-audio: remove unused bcm2835_audio_retrieve_buffers() declaration
2026-11-12 4:29 [PATCH] staging: bcm2835-audio: remove unused bcm2835_audio_retrieve_buffers() declaration Yusuke Hayashi via B4 Relay
@ 2026-11-20 7:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-11-20 7:21 UTC (permalink / raw)
To: yusuke8h
Cc: Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, linux-staging,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
On Thu, Nov 12, 2026 at 04:29:55AM +0000, Yusuke Hayashi via B4 Relay wrote:
> From: Yusuke Hayashi <yusuke8h@gmail.com>
>
> bcm2835_audio_retrieve_buffers() is declared in bcm2835.h, but its
> definition and sole caller were removed in commit d7ca3a71545b
> ("staging: bcm2835-audio: Operate non-atomic PCM ops").
>
> Remove the orphaned function declaration.
>
> Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> ---
> Found while scanning staging headers for declarations without definitions
> with an AI coding assistant, verified against commit d7ca3a71545b, and
> compile-tested with Clang 18 (LLVM=1 W=1 C=2) and GCC 13 (W=1 C=2) with
> CONFIG_SND_BCM2835=m.
> ---
> drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 1 -
> 1 file changed, 1 deletion(-)
Please read: https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12 4:29 [PATCH] staging: bcm2835-audio: remove unused bcm2835_audio_retrieve_buffers() declaration Yusuke Hayashi via B4 Relay
2026-11-20 7:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox