From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] clk: versatile: add missing header dependencies
Date: Sat, 24 Sep 2016 11:09:17 +0200 [thread overview]
Message-ID: <2048131.z1JiX2E8WD@wuerfel> (raw)
In-Reply-To: <1474691500-19793-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in
> include/linux/platform_data/clk-realview.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
I think I commented on this one already: the only caller of the
function is getting removed in v4.9, so we should remove the
definition of the function subsequently in the next release.
We could in theory try to remove this at the same time, but
the effort to synchronize the git trees is not worth the benefit.
Arnd
next prev parent reply other threads:[~2016-09-24 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 4:31 [PATCH] clk: versatile: add missing header dependencies Baoyou Xie
2016-09-24 9:09 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-14 6:29 Baoyou Xie
2016-09-14 7:31 ` Arnd Bergmann
2016-09-14 9:04 ` Linus Walleij
2016-09-14 9:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2048131.z1JiX2E8WD@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox