* [PATCH V1 09/13] accel/amdxdna: Use unsigned long for nr_pages in amdxdna_hmm_register()
@ 2026-06-16 6:15 Lizhi Hou
2026-07-06 22:01 ` Max Zhen
0 siblings, 1 reply; 3+ messages in thread
From: Lizhi Hou @ 2026-06-16 6:15 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, mario.limonciello,
karol.wachowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan
nr_pages is declared as u32 in amdxdna_hmm_register(), which may not be
large enough to represent the number of pages for large mappings.
Use unsigned long for nr_pages to avoid potential overflow.
Fixes: ac49797c1815 ("accel/amdxdna: Add GEM buffer object management")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/amdxdna_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c
index aef4c23a1a66..201536aff440 100644
--- a/drivers/accel/amdxdna/amdxdna_gem.c
+++ b/drivers/accel/amdxdna/amdxdna_gem.c
@@ -351,7 +351,7 @@ static int amdxdna_hmm_register(struct amdxdna_gem_obj *abo,
unsigned long len = vma->vm_end - vma->vm_start;
unsigned long addr = vma->vm_start;
struct amdxdna_umap *mapp;
- u32 nr_pages;
+ unsigned long nr_pages;
int ret;
if (!amdxdna_pasid_on(abo->client)) {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V1 09/13] accel/amdxdna: Use unsigned long for nr_pages in amdxdna_hmm_register()
2026-06-16 6:15 [PATCH V1 09/13] accel/amdxdna: Use unsigned long for nr_pages in amdxdna_hmm_register() Lizhi Hou
@ 2026-07-06 22:01 ` Max Zhen
2026-07-07 5:47 ` Lizhi Hou
0 siblings, 1 reply; 3+ messages in thread
From: Max Zhen @ 2026-07-06 22:01 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, mario.limonciello,
karol.wachowski
Cc: linux-kernel, sonal.santan
On 6/15/2026 Mon 23:15, Lizhi Hou wrote:
> nr_pages is declared as u32 in amdxdna_hmm_register(), which may not be
> large enough to represent the number of pages for large mappings.
>
> Use unsigned long for nr_pages to avoid potential overflow.
>
> Fixes: ac49797c1815 ("accel/amdxdna: Add GEM buffer object management")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Max Zhen <max.zhen@amd.com>> ---
> drivers/accel/amdxdna/amdxdna_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c
> index aef4c23a1a66..201536aff440 100644
> --- a/drivers/accel/amdxdna/amdxdna_gem.c
> +++ b/drivers/accel/amdxdna/amdxdna_gem.c
> @@ -351,7 +351,7 @@ static int amdxdna_hmm_register(struct amdxdna_gem_obj *abo,
> unsigned long len = vma->vm_end - vma->vm_start;
> unsigned long addr = vma->vm_start;
> struct amdxdna_umap *mapp;
> - u32 nr_pages;
> + unsigned long nr_pages;
> int ret;
>
> if (!amdxdna_pasid_on(abo->client)) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V1 09/13] accel/amdxdna: Use unsigned long for nr_pages in amdxdna_hmm_register()
2026-07-06 22:01 ` Max Zhen
@ 2026-07-07 5:47 ` Lizhi Hou
0 siblings, 0 replies; 3+ messages in thread
From: Lizhi Hou @ 2026-07-07 5:47 UTC (permalink / raw)
To: Max Zhen, ogabbay, quic_jhugo, dri-devel, mario.limonciello,
karol.wachowski
Cc: linux-kernel, sonal.santan
Applied to drm-misc-fixes
On 7/6/26 15:01, Max Zhen wrote:
>
>
> On 6/15/2026 Mon 23:15, Lizhi Hou wrote:
>> nr_pages is declared as u32 in amdxdna_hmm_register(), which may not be
>> large enough to represent the number of pages for large mappings.
>>
>> Use unsigned long for nr_pages to avoid potential overflow.
>>
>> Fixes: ac49797c1815 ("accel/amdxdna: Add GEM buffer object management")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Max Zhen <max.zhen@amd.com>> ---
>> drivers/accel/amdxdna/amdxdna_gem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c
>> b/drivers/accel/amdxdna/amdxdna_gem.c
>> index aef4c23a1a66..201536aff440 100644
>> --- a/drivers/accel/amdxdna/amdxdna_gem.c
>> +++ b/drivers/accel/amdxdna/amdxdna_gem.c
>> @@ -351,7 +351,7 @@ static int amdxdna_hmm_register(struct
>> amdxdna_gem_obj *abo,
>> unsigned long len = vma->vm_end - vma->vm_start;
>> unsigned long addr = vma->vm_start;
>> struct amdxdna_umap *mapp;
>> - u32 nr_pages;
>> + unsigned long nr_pages;
>> int ret;
>> if (!amdxdna_pasid_on(abo->client)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-07 5:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 6:15 [PATCH V1 09/13] accel/amdxdna: Use unsigned long for nr_pages in amdxdna_hmm_register() Lizhi Hou
2026-07-06 22:01 ` Max Zhen
2026-07-07 5:47 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox