From: "Jérôme Pouiller" <Jerome.Pouiller@silabs.com>
To: "driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'
Date: Tue, 11 Feb 2020 15:24:07 +0000 [thread overview]
Message-ID: <2132688.TkN2MAnNKH@pc-42> (raw)
In-Reply-To: <7641155.kNzuLtrjOU@pc-42>
On Tuesday 11 February 2020 16:21:41 CET Jérôme Pouiller wrote:
> On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote:
> > drivers/staging/wfx/queue.c: In function wfx_tx_queues_get:
> > drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable]
> >
> > commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense")
> > left behind this unused variable.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Maybe it could make sens to add a Fixes tag with the commit id that
introduce the warning?
--
Jérôme Pouiller
prev parent reply other threads:[~2020-02-11 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 14:03 [PATCH -next] staging: wfx: remove set but not used variable 'tx_priv' YueHaibing
2020-02-11 15:21 ` Jérôme Pouiller
2020-02-11 15:24 ` Jérôme Pouiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2132688.TkN2MAnNKH@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox